Spec URL: http://jbowes.dangerouslyinc.com/tmp/giggle.spec SRPM URL: http://jbowes.dangerouslyinc.com/tmp/giggle-0.1-1.src.rpm Description: Giggle is a graphical frontend for the git directory tracker (think of gitk on GTK+).
You missed to use desktop-file-install command in SPEC to install .desktop files. See http://fedoraproject.org/wiki/Packaging/Guidelines#desktop
(In reply to comment #1) > You missed to use desktop-file-install command in SPEC to install .desktop files. > See http://fedoraproject.org/wiki/Packaging/Guidelines#desktop Ah, good point. Updated spec and srpm are here: Spec URL: http://jbowes.dangerouslyinc.com/tmp/giggle.spec SRPM URL: http://jbowes.dangerouslyinc.com/tmp/giggle-0.1-2.src.rpm
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and RPMS. + source files match upstream. 26f43b6e79bd27701daeb83281cf1966 giggle-0.1.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. License text included in package. + %doc is small; no -doc subpackage required. + %doc does not affect runtime. + COPYING included in %doc. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no static libraries. + no .pc file present. + no -devel subpackage exists. + Desktop file installed correclty. + no .la files. + translations are available + Does owns the directories it creates. + no duplicates in %files. + file permissions are appropriate. + GUI app.
It will be good if you avoid hardcoding version and name in SOURCE URL Change http://ftp.imendio.com/pub/imendio/giggle/src/giggle-0.1.tar.gz to http://ftp.imendio.com/pub/imendio/giggle/src/%{name}-%{version}.tar.gz You can do that at time of importing a package. so for now I am approving this. APPROVED.
From a quick look at -2 spec file it seems that %{_datadir}/giggle/glade/ is not owned by any package.
Oops my eyes missed to catch that. Thanks for catching that.
Okay, other things I noticed is that: * perhaps "AUTHORS" should be added to %doc * category "Application" (in desktop file) is deprecated and should be removed.
Looks wiki page http://fedoraproject.org/wiki/Packaging/Guidelines#desktop needs some cleanup on Category as not to have Application issue.
New Package CVS Request ======================= Package Name: giggle Short Description: A Gtk frontend to git Owners: jbowes Branches: FC-6 InitialCC:
I'll make sure to fix up the other bits before I build. Thanks for the review!