Spec URL: https://kiilerix.fedorapeople.org/qlcplus.spec SRPM URL: https://kiilerix.fedorapeople.org/qlcplus-4.13.1-1.fc42.src.rpm Description: Q Light Controller Plus Fedora Account System Username: kiilerix
Koji scratch build on https://koji.fedoraproject.org/koji/taskinfo?taskID=123850880 . i686 seems to fail for unrelated reasons.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8062534 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314290-qlcplus/fedora-rawhide-x86_64/08062534-qlcplus/fedora-review/review.txt Found issues: - Unversioned so-files directly in %_libdir. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages - udev rules should not be installed in /etc but /lib as the former is for local override change %{_sysconfdir} to %{_libdir} in %files section - Add comment about upstream commit 5fb8842 that fixes hotplugmonitor static lib - Remove duplicate BuildRequires: pkgconfig(libudev) - Change %{_datadir} to %{_mandir} for /man/man1/*.1.gz - Make sure /usr/lib64/qt5 and /usr/lib64/qt5/plugins are owned by adding Requires: qt5-filesystem - Make sure /lib/udev/rules.d is owned by adding Requires: systemd-udev - Application specific .so should be put into sub directory, ex. /usr/lib64/glcplus/ Use %{_libdir}/glcplus/ in %files section - Changelog is missing version, ex. - 4.13.1-1 - Package contain unit tests that should be executed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [ ]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "Apache License 2.0", "GNU General Public License, Version 3", "MIT License", "BSD 3-Clause License", "SIL Open Font License 1.1", "*No copyright* Apache License 2.0 and/or GNU General Public License, Version 2", "*No copyright* GNU General Public License, Version 2". 3848 files have unknown license. Detailed output of licensecheck in /var/lib/copr-rpmbuild/results/qlcplus/licensecheck.txt [ ]: License file installed when any subpackage combination is installed. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/qt5, /etc/udev, /usr/lib64/qt5/plugins, /etc/udev/rules.d [ ]: %build honors applicable compiler flags or justifies otherwise. [ ]: Package contains no bundled libraries without FPC exception. [!]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [ ]: Development files must be in a -devel package [ ]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [!]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [!]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [ ]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10989 bytes in 1 files. [ ]: Package complies to the Packaging Guidelines [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [!]: Reviewer should test that the package builds in mock. [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [!]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [!]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [!]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 26255360 bytes in /usr/share qlcplus-4.13.1-1.fc42.x86_64.rpm:26255360 See: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines#Package_Review_Guidelines [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. Rpmlint ------- Checking: qlcplus-4.13.1-1.fc42.x86_64.rpm qlcplus-debuginfo-4.13.1-1.fc42.x86_64.rpm qlcplus-debugsource-4.13.1-1.fc42.x86_64.rpm qlcplus-4.13.1-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpfivzekh5')] checks: 32, packages: 4 qlcplus.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/z65-anyma-udmx.rules qlcplus.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/z65-dmxusb.rules qlcplus.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/z65-fx5-hid.rules qlcplus.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/z65-peperoni.rules qlcplus.x86_64: W: udev-rule-in-etc /etc/udev/rules.d/z65-spi.rules qlcplus.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/z65-anyma-udmx.rules qlcplus.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/z65-dmxusb.rules qlcplus.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/z65-fx5-hid.rules qlcplus.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/z65-peperoni.rules qlcplus.x86_64: W: non-conffile-in-etc /etc/udev/rules.d/z65-spi.rules qlcplus.src: W: no-version-in-last-changelog qlcplus.x86_64: W: no-version-in-last-changelog qlcplus-debuginfo.x86_64: W: no-version-in-last-changelog qlcplus-debugsource.x86_64: W: no-version-in-last-changelog qlcplus.x86_64: E: invalid-soname /usr/lib64/libqlcplusengine.so libqlcplusengine.so qlcplus.x86_64: E: invalid-soname /usr/lib64/libqlcplusui.so libqlcplusui.so qlcplus.x86_64: E: invalid-soname /usr/lib64/ libqlcpluswebaccess.so libqlcpluswebaccess.so qlcplus-debugsource.x86_64: E: files-duplicated-waste 2810535 qlcplus.x86_64: W: files-duplicate /usr/share/qlcplus/gobos/GLP/gobo00006.svg /usr/share/qlcplus/gobos/Chauvet/gobo00017.svg qlcplus.x86_64: W: files-duplicate /usr/share/qlcplus/gobos/ClayPaky/gobo00006.svg /usr/share/qlcplus/gobos/Chauvet/gobo00020.svg qlcplus.x86_64: W: files-duplicate /usr/share/qlcplus/gobos/ClayPaky/gobo00007.svg /usr/share/qlcplus/gobos/Chauvet/gobo00021.svg qlcplus.x86_64: W: files-duplicate /usr/share/qlcplus/gobos/ClayPaky/gobo00008.svg /usr/share/qlcplus/gobos/Chauvet/gobo00022.svg qlcplus.x86_64: W: files-duplicate /usr/share/qlcplus/gobos/ClayPaky/gobo00009.svg /usr/share/qlcplus/gobos/Chauvet/gobo00023.svg qlcplus.x86_64: W: files-duplicate /usr/share/qlcplus/gobos/ClayPaky/gobo00011.svg /usr/share/qlcplus/gobos/Chauvet/gobo00024.svg 4 packages and 0 specfiles checked; 4 errors, 20 warnings, 758 filtered, 4 badness; has taken 4.4 s Rpmlint (debuginfo) ------------------- Checking: qlcplus-debuginfo-4.13.1-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp_snvi7sm')] checks: 32, packages: 1 qlcplus-debuginfo.x86_64: W: no-version-in-last-changelog 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 50 filtered, 0 badness; has taken 1.5 s Rpmlint (installed packages) ---------------------------- (none): E: there is no installed rpm "qlcplus-debugsource". (none): E: there is no installed rpm "qlcplus". (none): E: there is no installed rpm "qlcplus-debuginfo". There are no files to process nor additional arguments. Nothing to do, aborting. ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 3 0 packages and 0 specfiles checked; 0 errors, 0 warnings, 0 filtered, 0 badness; has taken 0.0 s Unversioned so-files -------------------- qlcplus: /usr/lib64/libqlcplusengine.so qlcplus: /usr/lib64/libqlcplusui.so qlcplus: /usr/lib64/libqlcpluswebaccess.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/audio/libmadplugin.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/audio/libsndfileplugin.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libartnet.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libdmx4linux.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libdmxusb.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libe131.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libenttecwing.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libhidplugin.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libloopback.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libmidiplugin.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libos2l.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libosc.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libpeperoni.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libspi.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libudmx.so qlcplus: /usr/lib64/qt5/plugins/qlcplus/libvelleman.so Source checksums ---------------- https://github.com/mcallegari/qlcplus/archive/refs/tags/QLC+_4.13.1.tar.gz : CHECKSUM(SHA256) this package : de3f4803e9f80e28728e4f835b114ec8894b47b33f6dfb2cf2755b283818d770 CHECKSUM(SHA256) upstream package : de3f4803e9f80e28728e4f835b114ec8894b47b33f6dfb2cf2755b283818d770 Requires -------- qlcplus (rpmlib, GLIBC filtered): libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.15)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Multimedia.so.5()(64bit) libQt5Multimedia.so.5(Qt_5)(64bit) libQt5MultimediaWidgets.so.5()(64bit) libQt5MultimediaWidgets.so.5(Qt_5)(64bit) libQt5Network.so.5()(64bit) libQt5Network.so.5(Qt_5)(64bit) libQt5Script.so.5()(64bit) libQt5Script.so.5(Qt_5)(64bit) libQt5SerialPort.so.5()(64bit) libQt5SerialPort.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libasound.so.2()(64bit) libasound.so.2(ALSA_0.9)(64bit) libc.so.6()(64bit) libfftw3.so.3()(64bit) libftdi1.so.2()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libm.so.6()(64bit) libmad.so.0()(64bit) libqlcplusengine.so()(64bit) libqlcplusui.so()(64bit) libqlcpluswebaccess.so()(64bit) libsndfile.so.1()(64bit) libsndfile.so.1(libsndfile.so.1.0)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.15)(64bit) libstdc++.so.6(CXXABI_1.3.8)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libudev.so.1()(64bit) libudev.so.1(LIBUDEV_183)(64bit) libusb-1.0.so.0()(64bit) rtld(GNU_HASH) qlcplus-debuginfo (rpmlib, GLIBC filtered): qlcplus-debugsource (rpmlib, GLIBC filtered): Provides -------- qlcplus: application() application(qlcplus-fixtureeditor.desktop) application(qlcplus.desktop) libartnet.so()(64bit) libdmx4linux.so()(64bit) libdmxusb.so()(64bit) libe131.so()(64bit) libenttecwing.so()(64bit) libhidplugin.so()(64bit) libloopback.so()(64bit) libmadplugin.so()(64bit) libmidiplugin.so()(64bit) libos2l.so()(64bit) libosc.so()(64bit) libpeperoni.so()(64bit) libqlcplusengine.so()(64bit) libqlcplusui.so()(64bit) libqlcpluswebaccess.so()(64bit) libsndfileplugin.so()(64bit) libspi.so()(64bit) libudmx.so()(64bit) libvelleman.so()(64bit) metainfo() metainfo(org.qlcplus.QLCPlus.appdata.xml) metainfo(org.qlcplus.QLCPlus.dmx4linux.metainfo.xml) metainfo(org.qlcplus.QLCPlus.dmxusb.metainfo.xml) metainfo(org.qlcplus.QLCPlus.e131.metainfo.xml) metainfo(org.qlcplus.QLCPlus.enttecwing.metainfo.xml) metainfo(org.qlcplus.QLCPlus.hid.metainfo.xml) metainfo(org.qlcplus.QLCPlus.loopback.metainfo.xml) metainfo(org.qlcplus.QLCPlus.os2l.metainfo.xml) metainfo(org.qlcplus.QLCPlus.osc.metainfo.xml) metainfo(org.qlcplus.QLCPlus.peperoni.metainfo.xml) metainfo(org.qlcplus.QLCPlus.spi.metainfo.xml) metainfo(org.qlcplus.QLCPlus.udmx.metainfo.xml) metainfo(org.qlcplus.QLCPlusFixtureEditor.appdata.xml) mimehandler(application/x-qlc-fixture) mimehandler(application/x-qlc-workspace) qlcplus qlcplus(x86-64) qlcplus-debuginfo: debuginfo(build-id) libartnet.so-4.13.1-1.fc42.x86_64.debug()(64bit) libdmx4linux.so-4.13.1-1.fc42.x86_64.debug()(64bit) libdmxusb.so-4.13.1-1.fc42.x86_64.debug()(64bit) libe131.so-4.13.1-1.fc42.x86_64.debug()(64bit) libenttecwing.so-4.13.1-1.fc42.x86_64.debug()(64bit) libhidplugin.so-4.13.1-1.fc42.x86_64.debug()(64bit) libloopback.so-4.13.1-1.fc42.x86_64.debug()(64bit) libmadplugin.so-4.13.1-1.fc42.x86_64.debug()(64bit) libmidiplugin.so-4.13.1-1.fc42.x86_64.debug()(64bit) libos2l.so-4.13.1-1.fc42.x86_64.debug()(64bit) libosc.so-4.13.1-1.fc42.x86_64.debug()(64bit) libpeperoni.so-4.13.1-1.fc42.x86_64.debug()(64bit) libqlcplusengine.so-4.13.1-1.fc42.x86_64.debug()(64bit) libqlcplusui.so-4.13.1-1.fc42.x86_64.debug()(64bit) libqlcpluswebaccess.so-4.13.1-1.fc42.x86_64.debug()(64bit) libsndfileplugin.so-4.13.1-1.fc42.x86_64.debug()(64bit) libspi.so-4.13.1-1.fc42.x86_64.debug()(64bit) libudmx.so-4.13.1-1.fc42.x86_64.debug()(64bit) libvelleman.so-4.13.1-1.fc42.x86_64.debug()(64bit) qlcplus-debuginfo qlcplus-debuginfo(x86-64) qlcplus-debugsource: qlcplus-debugsource qlcplus-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/bin/fedora-review --no-colors --prebuilt --rpm-spec --name qlcplus --mock-config /var/lib/copr-rpmbuild/results/configs/child.cfg Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: Haskell, R, PHP, Python, Java, fonts, Ocaml, SugarActivity, Perl Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH