Spec URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-css.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-css-0.9.0-1.fc40/rust-relm4-css-0.9.0-1.fc42.src.rpm Description: Idiomatic GUI library inspired by Elm and based on gtk4-rs Fedora Account System Username: jsteffan
Copr build: https://copr.fedorainfracloud.org/coprs/build/8062791 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314328-rust-relm4-css/fedora-rawhide-x86_64/08062791-rust-relm4-css/fedora-review/review.txt Found issues: - License file LICENSE-APACHE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks like you forgot to replace ``` # FIXME: no license files detected %doc %{crate_instdir}/README.md %{crate_instdir}/ ``` with ``` %license %{crate_instdir}/LICENSE-APACHE %license %{crate_instdir}/LICENSE-MIT %doc %{crate_instdir}/README.md %{crate_instdir}/ ``` ?
Sure did. Updated. Spec URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-css.spec SRPM URL: https://jsteffan.fedorapeople.org/envision/rust-relm4-css-0.9.0-1.fc40/rust-relm4-css-0.9.0-1.fc42.src.rpm
Created attachment 2048378 [details] The .spec file difference from Copr build 8062791 to 8062985
Copr build: https://copr.fedorainfracloud.org/coprs/build/8062985 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2314328-rust-relm4-css/fedora-rawhide-x86_64/08062985-rust-relm4-css/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (there are no tests) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora 🫤 license files are included with %license in %files (temporarily manually included from upstream) ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Sorry, forgot to set the fedora-review+ flag.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-relm4-css