Copr build:
https://copr.fedorainfracloud.org/coprs/build/8086388
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315381-glycin/fedora-rawhide-x86_64/08086388-glycin/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

This is intended to be a replacement of the "glycin-loaders" package.

Upstream published under the "glycin-loaders" name until 1.0.*:
https://download.gnome.org/sources/glycin-loaders/

But version 1.1.* are published as "glycin":
https://download.gnome.org/sources/glycin/

The packaging is based on the one for glycin-loaders, with additions for the new "libglycin" library and its development headers.
I have confirmed that the build for ELN works too (locally in fedora-eln-x86_64 mock chroot).

The Fedora build depends on updates that are not yet pushable to Rawhide because they would break the current glycin-loaders package (the jpegxl-sys 0.10 and jpegxl-sys 0.10 updates), but I already built them in a side-tag, and just launched a scratch build against it:
https://koji.fedoraproject.org/koji/taskinfo?taskID=124076310

glycin 1.1 is part of the GNOME 47 release, so we need this in Fedora Rawhide and 41 soon.

CC Kalev who is the current maintainer of glycin-loaders.

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide (in a side-tag)
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license file is included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter: alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

(In reply to Neal Gompa from comment #3)
> Package was generated with rust2rpm, simplifying the review.
> 
> ✅ package contains only permissible content
> ✅ package builds and installs without errors on rawhide (in a side-tag)
> ✅ test suite is run and all unit tests pass
> ✅ latest version of the crate is packaged
> ✅ license matches upstream specification and is acceptable for Fedora
> ✅ license file is included with %license in %files
> ✅ package complies with Rust Packaging Guidelines
> 
> Package APPROVED.


Well, actually, this isn't done with rust2rpm, but the review checks are largely the same anyway. :)

> ===
> 
> Recommended post-import rust-sig tasks:
> 
> - set up package on release-monitoring.org:
>   project: $crate
>   homepage: https://crates.io/crates/$crate
>   backend: crates.io
>   version scheme: semantic
>   version filter: alpha;beta;rc;pre
>   distro: Fedora
>   Package: rust-$crate
> 
> - add @rust-sig with "commit" access as package co-maintainer
>   (should happen automatically)
> 
> - set bugzilla assignee overrides to @rust-sig (optional)
> 
> - track package in koschei for all built branches
>   (should happen automatically once rust-sig is co-maintainer)

Most of this doesn't apply, but adding gnome-sig and rust-sig as co-maintainers would be good too.

(This is what I get for using a formula and pressing enter too quickly before finishing modifying the response...)

Also, minor thing to ask for, I'd prefer the gtk4 stuff to be split out into their own subpackages. That way environments that don't need it can get the rest of the stack just fine.

(In reply to Neal Gompa from comment #5)
> Also, minor thing to ask for, I'd prefer the gtk4 stuff to be split out into
> their own subpackages. That way environments that don't need it can get the
> rest of the stack just fine.

This can be done on import, as I expect you know how to subpackage things. :)

Thank you for the review!

I'll split off the GTK4 stuff after importing the current version and submit a PR for it, just to get another set of eyes on the necessary changes.

The Pagure repository was created at https://src.fedoraproject.org/rpms/glycin

FEDORA-2024-14e4b17ce8 (glycin-1.1.1-2.fc42, rust-jpegxl-rs-0.10.4-2.fc42, and 1 more) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-14e4b17ce8

FEDORA-2024-14e4b17ce8 (glycin-1.1.1-2.fc42, rust-jpegxl-rs-0.10.4-2.fc42, and 1 more) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.