Spec URL: https://dcavalca.fedorapeople.org/review/python-u-boot-pylib/python-u-boot-pylib.spec SRPM URL: https://dcavalca.fedorapeople.org/review/python-u-boot-pylib/python-u-boot-pylib-0.0.6-1.fc42.src.rpm Description: This is a Python library used by various U-Boot tools, including patman, buildman and binman. Fedora Account System Username: dcavalca
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=124190904
Copr build: https://copr.fedorainfracloud.org/coprs/build/8091465 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2315590-python-u-boot-pylib/fedora-rawhide-x86_64/08091465-python-u-boot-pylib/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
A %license entry would be good to have. Looking at u-boot, this is project is used by several other projects in tools/ including the dtoc one, there is buildman,binman and patman. Would it be easier to combine all of these into a single package ? If not, are you planning on packaging buildman,binman and patman ?
> A %license entry would be good to have. This is picked up automatically by the Python packaging macros: $ rpm -q --licensefiles -p python3-u-boot-pylib-0.0.6-1.fc42.noarch.rpm /usr/lib/python3.13/site-packages/u_boot_pylib-0.0.6.dist-info/LICENSE > Looking at u-boot, this is project is used by several other projects in tools/ including the dtoc one, there is buildman,binman and patman. Would it be easier to combine all of these into a single package ? If not, are you planning on packaging buildman,binman and patman ? Yes, I've already submitted all of these for review: https://bugzilla.redhat.com/show_bug.cgi?id=2316562 https://bugzilla.redhat.com/show_bug.cgi?id=2316563 https://bugzilla.redhat.com/show_bug.cgi?id=2316566 https://bugzilla.redhat.com/show_bug.cgi?id=2316567 They're all separate packages because they're all published separately on PyPI.
Thanks for giving u-boot some attention. I have taken these reviews. If you have the time, could you review this package of mine ? https://bugzilla.redhat.com/show_bug.cgi?id=2259449 ATM ROCm is a bit broken in rawhide, but that should settle out with when llvm18 stablizes. LGTM. Approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-u-boot-pylib
FEDORA-2024-d2755ae2e8 (python-u-boot-pylib-0.0.6-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-d2755ae2e8
FEDORA-2024-d2755ae2e8 (python-u-boot-pylib-0.0.6-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.