Bug 231639 - [Symantec 5.1 bug] kernel thread current->mm dereference in grab_swap_token causes oops
[Symantec 5.1 bug] kernel thread current->mm dereference in grab_swap_token c...
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
All Linux
medium Severity high
: ---
: ---
Assigned To: Jerome Marchand
Martin Jenner
: Regression
Depends On: IT_71391
Blocks: 243319 217203
  Show dependency treegraph
Reported: 2007-03-09 12:51 EST by Andrius Benokraitis
Modified: 2015-07-14 00:25 EDT (History)
8 users (show)

See Also:
Fixed In Version: RHBA-2007-0959
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-11-07 14:43:34 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Comment 2 Andrius Benokraitis 2007-03-09 13:02:48 EST
Neena, please post an updated patch here, or provide a link to the patch
required for inclusion in RHEL 5.1.
Comment 3 RHEL Product and Program Management 2007-03-09 13:04:24 EST
This bugzilla has Keywords: Regression.  

Since no regressions are allowed between releases, 
it is also being proposed as a blocker for this release.  

Please resolve ASAP.
Comment 5 Neena Bhatnagar 2007-03-09 13:13:26 EST
The patch in is linux-2.6.9-vm-swaptoken-null-mm.patch
>>>> --- linux-2.6.9/mm/thrash.c~    2005-04-27 23:35:17.000000000 -0400
>>>> +++ linux-2.6.9/mm/thrash.c     2005-04-27 23:35:49.000000000 -0400
>>>> @@ -50,6 +50,10 @@ void grab_swap_token(void)
>>>>         struct mm_struct *mm;
>>>>         int reason;
>>>> +       /* Some kernel threads without mm can fault on behalf of
> others.
>>>> */
>>>> +       if (unlikely(!current->mm))
>>>> +               return;
>>>> +
>>>>         /* We have the token. Let others know we still need it. */
>>>>         if (has_swap_token(current->mm)) {

Comment 9 Andrius Benokraitis 2007-03-09 13:28:51 EST
Thanks Neena, I've included RH kernel management to assess this issue.
Comment 12 Andrius Benokraitis 2007-03-21 23:43:42 EDT
Ram, can you verify the code in Comment #5 has been tested by Symantec?
Comment 13 Peter Kettle 2007-03-22 08:03:04 EDT
Yes, we have tried this in a patched kernel and it definitely fixes the 

Regards, Peter Kettle, peter_kettle@symantec.com
Comment 14 Jerome Marchand 2007-03-26 13:25:59 EDT
Patch submitted to rhkernel-list:
Comment 15 RHEL Product and Program Management 2007-03-28 08:21:55 EDT
This request was evaluated by Red Hat Kernel Team for inclusion in a Red
Hat Enterprise Linux maintenance release, and has moved to bugzilla 
status POST.
Comment 16 Don Zickus 2007-05-09 14:21:00 EDT
in 2.6.18-18.el5
Comment 17 Rita Sequeira 2007-05-10 05:45:23 EDT
2.6.18-18.el5 - Where can I pick this kernel

Comment 18 Andrius Benokraitis 2007-05-10 10:23:38 EDT

Comment 19 Andrius Benokraitis 2007-07-06 01:21:27 EDT
Rita, any word on the testing? I'm assuming Peter's comments above still hold?

Also, our QE group is looking into how we can reproduce this, is the setup
pretty involved?
Comment 22 Mike Gahagan 2007-08-28 15:14:28 EDT
Confirmed by running testcase in rhts manually... systems stays up running the
-43 kernel, panics with ga kernel.
Comment 23 Peter Kettle 2007-08-30 05:51:19 EDT
We've now completed our own testing and we are happy for you to close this 
case.  Thanks for all of your help.

Peter Kettle
Comment 25 errata-xmlrpc 2007-11-07 14:43:34 EST
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.