Red Hat Bugzilla – Bug 231675
Review Request: librra - Connection to Pocket PC devices, part of SynCE
Last modified: 2007-11-30 17:11:58 EST
Spec URL: http://gauret.free.fr/fichiers/rpms/fedora/synce/librra.spec SRPM URL: http://gauret.free.fr/fichiers/rpms/fedora/synce/librra-0.9.1-1.src.rpm Description: RRA is part of the SynCE project: http://www.synce.org SynCE is already in Fedora Extras, but in the form of a monolithic package : all the libraries are in the same RPM. I've splitted it, this is one of the libraries.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 * OK: rpmlint is silent * OK: package is named according to the guidelines * OK: spec file name matches base package name * OK: package meets packaging guidelines * OK: license * OK: license field matches actual license * OK: license is not included as own file and thus is not included in %doc * OK: Spec file seems to be in AE * OK: no obfuscated code spec * OK: sources match upstream: 72742f93f19d5727159989ec80a725f0 synce-rra-0.9.1.tar.gz 72742f93f19d5727159989ec80a725f0 /homes/awjb/rpmbuild/SOURCES/synce-rra-0.9.1.tar.gz * OK: Builds fine on x86_64/fc6 * OK: BR seem fine * OK: package has no locale support * OK: ldconfig is run * OK: package is not explicitly designed to be relocatable * OK: package owns %{_includedir}/rra * OK: no duplicate files in file listing * OK: %defattr and permissions seem ok * OK: %clean section is present * OK: macros are used consistently * OK: content is ok * OK: no doc package needed * OK: %doc files do not affect runtime * OK: header files are in -devel * OK: no static lib * OK: pkgconfig is not needed * OK: no .so file * OK: -devel requires main package * OK: package does not contain .la archives * OK: no .desktop needed * OK: does not own files/directories from other packages * OK: buildroot is rm at beginning of install * OK: filenames seem to be valid utf8 Package d9d02a54ebbab717ec4ec0fa55aa9405 librra-0.9.1-1.src.rpm is APPROVED with the following patch: - --- librra.spec.1 2007-03-09 22:58:01.000000000 +0100 +++ librra.spec 2007-04-27 11:13:08.000000000 +0200 @@ -11,6 +11,7 @@ BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) BuildRequires: libsynce-devel, librapi-devel, libmimedir-devel +BuildRequires: libtool # Provide an upgrade path from the monilithic synce package Provides: synce = %{version}-%{release} @@ -35,14 +36,14 @@ %build %configure --disable-static --disable-rpath - -make %{?_smp_mflags} +make LIBTOOL=%{_bindir}/libtool %{?_smp_mflags} %install rm -rf $RPM_BUILD_ROOT make install DESTDIR=$RPM_BUILD_ROOT - -rm -f $RPM_BUILD_ROOT%{_libdir}/*.la +rm -f $RPM_BUILD_ROOT%{_libdir}/*.{la,a} %clean -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.7 (GNU/Linux) iD8DBQFGMb/JQEQyPsWM8csRApGNAKCm5tpg0LrxBKoAud3PQH4/Sfef/gCfdsWV 2VBWLC3r5yvtiFQJQXKXmGo= =gIso -----END PGP SIGNATURE-----
New Package CVS Request ======================= Package Name: librra Short Description: Connection to Pocket PC devices, part of SynCE Owners: andreas.bierfert@lowlatency.de,gauret@free.fr Branches: FC-6 InitialCC: