Spec URL: https://decathorpe.fedorapeople.org/rust-aligned-vec.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-aligned-vec-0.5.0-1.fc41.src.rpm Description: Aligned vector and box containers. Fedora Account System Username: decathorpe
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=124528194
Copr build: https://copr.fedorainfracloud.org/coprs/build/8115728 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2317004-rust-aligned-vec/fedora-rawhide-x86_64/08115728-rust-aligned-vec/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
This is 0.5.0, but the latest version is 0.6.1. An unreleased (but merged!) commit in rust-v_frame upstream allows it to work with the latest version simply by loosening the version specification: https://github.com/rust-av/v_frame/commit/313b3529435b2acf2a922b63edbc3419eb877a83 Can we backport that commit to rust-v_frame and package the latest release of rust-aligned-vec instead?
That should be possible, but v0.6.0 adds a new dependency (equator ^0.2) which is not available in Fedora yet. If you prefer packaging rust-equator ^0.2 first and updating this review to v0.6.1, then I'll do that.
I think that packaging the latest version now makes more sense than planning a SemVer-incompatible update later. The only reason not to package 0.6.x now would be if getting two more reviews would slow things down a lot. However, in this case, I’ll happily take all three reviews (rust-aligned-vec, rust-equator, and rust-equator-macro).
There's some problems with this plan: - aligned-vec currently depends on equator v0.2, but the latest version is v0.4.1 - neither equator nor equator-macro contains a license file I don't really have time to deal with any of these right now (help appreciated).
(In reply to Fabio Valentini from comment #6) > There's some problems with this plan: > > - aligned-vec currently depends on equator v0.2, but the latest version is > v0.4.1 Looks like no source code changes are required. PR offered: https://github.com/sarah-quinones/aligned-vec/pull/9 This can be replicated downstream as a metadata patch until there’s a new release. > - neither equator nor equator-macro contains a license file Fixed the usual missing symlinks: https://github.com/sarah-quinones/equator/pull/2 This will require the usual dance of including LICENSE from https://github.com/sarah-quinones/equator/raw/bca8e32847400e629d9e1e677b56620d4c353da1/LICENSE (releases are not tagged, thus the commit corresponding to equator/equator-macro 0.4.1) as an additional source until there’s a new release. > I don't really have time to deal with any of these right now (help > appreciated). Is there anything else I can do to help besides the linked upstream PR’s? I could package the equator crates and post them for review, but I don’t know which is less work for you, reviewing or packaging.
Thank you for the upstream PRs! I'll try to get review requests for equator* up soon.
(In reply to Fabio Valentini from comment #8) > Thank you for the upstream PRs! > > I'll try to get review requests for equator* up soon. I just put them up for review.
Thank you for your help, I've now updated this package for 0.6.1 and equator 0.4: Spec URL: https://decathorpe.fedorapeople.org/rust-aligned-vec.spec SRPM URL: https://decathorpe.fedorapeople.org/rust-aligned-vec-0.6.1-1.fc41.src.rpm
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated The spec file is exactly as generated by rust2rpm with no configuration file, except for a metadata patch: # Manually created patch for downstream crate metadata changes # * bump equator dependency from 0.2 to 0.4: # https://github.com/sarah-quinones/aligned-vec/commit/bad4971 Patch: aligned-vec-fix-metadata.diff The patch file does what it claims to, the change is reasonable, and upstream status is present. Issues: ======= - Package does not contain duplicates in %files. Note: warning: File listed twice: /usr/share/cargo/registry/aligned- vec-0.6.1/LICENSE See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_duplicate_files This is due to reasonable design choices in rust2rpm and is not a serious problem. ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 6 files have unknown license. Detailed output of licensecheck in /home/ben/fedora/review/2317004-rust-aligned-vec/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Fully versioned dependency in subpackages if applicable. Note: No Requires: %{name}%{?_isa} = %{version}-%{release} in rust- aligned-vec-devel , rust-aligned-vec+default-devel , rust-aligned- vec+serde-devel , rust-aligned-vec+std-devel [x]: Package functions as described. (Tests pass.) [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. https://koji.fedoraproject.org/koji/taskinfo?taskID=129506609 [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: rust-aligned-vec-devel-0.6.1-1.fc43.noarch.rpm rust-aligned-vec+default-devel-0.6.1-1.fc43.noarch.rpm rust-aligned-vec+serde-devel-0.6.1-1.fc43.noarch.rpm rust-aligned-vec+std-devel-0.6.1-1.fc43.noarch.rpm rust-aligned-vec-0.6.1-1.fc43.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.6.1 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpo5qv9zbr')] checks: 32, packages: 5 rust-aligned-vec+default-devel.noarch: W: no-documentation rust-aligned-vec+serde-devel.noarch: W: no-documentation rust-aligned-vec+std-devel.noarch: W: no-documentation 5 packages and 0 specfiles checked; 0 errors, 3 warnings, 22 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.7.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 4 rust-aligned-vec+std-devel.noarch: W: no-documentation rust-aligned-vec+serde-devel.noarch: W: no-documentation rust-aligned-vec+default-devel.noarch: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings, 18 filtered, 0 badness; has taken 0.0 s Source checksums ---------------- https://crates.io/api/v1/crates/aligned-vec/0.6.1/download#/aligned-vec-0.6.1.crate : CHECKSUM(SHA256) this package : 7e0966165eaf052580bd70eb1b32cb3d6245774c0104d1b2793e9650bf83b52a CHECKSUM(SHA256) upstream package : 7e0966165eaf052580bd70eb1b32cb3d6245774c0104d1b2793e9650bf83b52a Requires -------- rust-aligned-vec-devel (rpmlib, GLIBC filtered): (crate(equator/default) >= 0.4.0 with crate(equator/default) < 0.5.0~) cargo rust-aligned-vec+default-devel (rpmlib, GLIBC filtered): cargo crate(aligned-vec) crate(aligned-vec/std) rust-aligned-vec+serde-devel (rpmlib, GLIBC filtered): (crate(serde) >= 1.0.0 with crate(serde) < 2.0.0~) cargo crate(aligned-vec) rust-aligned-vec+std-devel (rpmlib, GLIBC filtered): cargo crate(aligned-vec) Provides -------- rust-aligned-vec-devel: crate(aligned-vec) rust-aligned-vec-devel rust-aligned-vec+default-devel: crate(aligned-vec/default) rust-aligned-vec+default-devel rust-aligned-vec+serde-devel: crate(aligned-vec/serde) rust-aligned-vec+serde-devel rust-aligned-vec+std-devel: crate(aligned-vec/std) rust-aligned-vec+std-devel Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2317004 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, C/C++, Java, PHP, Python, Haskell, Perl, SugarActivity, Ocaml, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Thank you for the review! Sorry for the delay in getting back to this.
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-aligned-vec
Imported and updated to the latest version: https://bodhi.fedoraproject.org/updates/FEDORA-2025-416b04d581