SRPM URL: http://home.comcast.net/~ckweyl/perl-DBD-Mock-1.34-1.fc6.src.rpm SPEC URL: http://home.comcast.net/~ckweyl/perl-DBD-Mock.spec Description: Testing with databases can be tricky. If you are developing a system married to a single database then you can make some assumptions about your environment and ask the user to provide relevant connection information. But if you need to test a framework that uses DBI, particularly a framework that uses different types of persistence schemes, then it may be more useful to simply verify what the framework is trying to do -- ensure the right SQL is generated and that the correct parameters are bound. DBD::Mock makes it easy to just modify your configuration (presumably held outside your code) and just use it instead of DBD::Foo (like DBD::Pg or DBD::mysql) in your framework.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 5070cfde75059aa2273e09b39c4d2d5f DBD-Mock-1.34.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + ./Build test t/000_basic............................ok t/001_db_handle........................ok t/002_dr_handle........................ok t/003_db_can_connect...................ok t/004_misc_mock_attr...................ok t/005_db_parser........................ok t/006_prepare_cached...................ok t/007_mock_attribute_aliases...........ok t/008_db_connect_cached................ok t/009_info.............................ok t/010_rollback.........................ok t/011_st_execute_empty.................ok t/012_st_handle........................ok t/013_st_execute_bound_params..........ok t/014_st_execute_pass_params...........ok t/015_st_fetch_records.................ok t/016_mock_add_resultset_test..........ok t/017_st_can_connect...................ok t/018_mock_statement_track.............ok t/019_mock_statement_track_iterator....ok t/020_db_pool..........................ok t/021_DBD_Mock_Session.................ok t/022_DBD_Mock_Session_bound_params....ok t/023_statement_failure................ok t/024_selcol_fetchhash.................ok t/025_mock_last_insert_id..............ok t/998_pod..............................ok t/999_pod_coverage.....................ok t/bug_0001.............................ok All tests successful. Files=29, Tests=572, 3 wallclock secs ( 2.16 cusr + 0.37 csys = 2.53 CPU) + Provides: perl(DBD::Mock) = 1.34 perl(DBD::Mock::Pool) perl(DBD::Mock::Pool::db) perl(DBD::Mock::Session) perl(DBD::Mock::StatementTrack) perl(DBD::Mock::StatementTrack::Iterator) perl(DBD::Mock::db) perl(DBD::Mock::dr) perl(DBD::Mock::st) APPROVED.
For F7 you should add in SPEC %if "%fedora" >= "7" BuildRequires: perl-devel %endif
I confused over my above comment. Not able to find in Fedora-* archive about final decision to add above in SPEC or not?
This will be presented to the packaging committee in tomorrow's meeting: http://www.redhat.com/archives/fedora-packaging/2007-March/msg00028.html
Thanks for pointing that. So I think Reporter Can either import package as it is now or wait for final conclusion on perl-devel issue and then import it.
New Package CVS Request ======================= Package Name: perl-DBD-Mock Short Description: Mock database driver for testing Owners: cweyl.edu Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list
*** Bug 232614 has been marked as a duplicate of this bug. ***
Branched, imported and building... Thanks for the review! :)
Please request EL6 branch for perl-DBD-Mock. If you are not willing to do it I am volunteer to maintain the branch myself (FAS username pradac).
Package Change Request ====================== Package Name: perl-DBD-Mock New Branches: el6 epel7 Owners: pradac lkundrak My e-mail. Adding el6 branch too, since the above comment got no response. > Feel free to request for and maintain the EL-7 branch yourself.
Git done (by process-git-requests).