Spec URL: https://peter.fedorapeople.org/packages/python-eth-utils.spec SRPM URL: https://peter.fedorapeople.org/packages/python-eth-utils-5.0.0-1.fc40.src.rpm Description: Utility functions for working with Ethereum related codebases Fedora Account System Username: peter Koji scratch build for Fedora 41: * https://koji.fedoraproject.org/koji/taskinfo?taskID=125066883
[fedora-review-service-build]
Perhaps exclude failing tests as pycryptodome and pycryptodome-test-vectors are missing (may package if time allows to see if they enable tests to pass associated copr https://copr.fedorainfracloud.org/coprs/fed500/python-eth-utils): FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element0-0xde78e78a] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element1-0xc51bf934] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element2-0xa31d5580] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element3-0xc1772ae8] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element4-0xfa89ea29] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element5-0xbef4876b] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element6-0xc2985578] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element7-0x77c874c7] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element8-0x552079dc] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element9-0xa3e76c0f] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element10-0x90fa17bb] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element11-0x2757c293] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_abi_to_4byte_selector[abi_element12-0x236ac042] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_signature_to_4byte_selector[tokenLaunched()-0xde78e78a] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_signature_to_4byte_selector[CEILING()-0xc51bf934] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_signature_to_4byte_selector[Registrar(address,bytes32,address) -0xa31d5580] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_signature_to_4byte_selector[failed(bytes32,str)-0x236ac042] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_signature_to_4byte_selector[receive()-0xa3e76c0f] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_signature_to_4byte_selector[fallback()-0x552079dc] FAILED tests/core/abi-utils/test_abi_utils.py::test_fn_signature_to_4byte_selector[constructor()-0x90fa17bb] FAILED tests/core/abi-utils/test_abi_utils.py::test_event_abi_to_log_topic[abi_event0-0xddf252ad1be2c89b69c2b068fc378 daa952ba7f163c4a11628f55a4df523b3ef] FAILED tests/core/abi-utils/test_abi_utils.py::test_event_abi_to_log_topic[abi_event1-0xbef4876bcdde2983a1ba9fe22b598 3b09081cf602d266f72a613d0d9c2f78e28] FAILED tests/core/abi-utils/test_abi_utils.py::test_event_abi_to_log_topic[abi_event2-0x56d2ef3c5228bf5d88573621e325a 4672ab50e033749a601e4f4a5e1dce905d4] FAILED tests/core/abi-utils/test_abi_utils.py::test_event_abi_to_log_topic[abi_event3-0x77c874c798a153cb8bb91a65910a8 f49033a603329228caa4b3b1bb4bb5b9e18] FAILED tests/core/abi-utils/test_abi_utils.py::test_event_signature_to_log_topic[Transfer(address,address,uint256)-0x ddf252ad1be2c89b69c2b068fc378daa952ba7f163c4a11628f55a4df523b3ef] FAILED tests/core/abi-utils/test_abi_utils.py::test_event_signature_to_log_topic[Event_2(bytes32,uint256)-0x115494e95 409cd09eaa4590f66d8938bb342c170bc2edcca5fd14ad46fb7dcb8] FAILED tests/core/abi-utils/test_abi_utils.py::test_event_signature_to_log_topic[event()-0x4980500b48d9072058dce7e522 2cd23e11759678f8aa74b3a6f0e891bb888979] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0x52908400098527886E0F7030069857D2E41 69EE7-True] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0x8617E340B3D01FA5F11F306F4090FD50E23 8070D-True] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0xde709f2102306220921060314715629080e 2fb77-True] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0x27b1fdb04752bbc536007a920d24acb0455 61c26-True] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0x5aAeb6053F3E94C9b9A09f33669435E7Ef1 BeAed-True] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0xfB6916095ca1df60bB79Ce92cE3Ea74c37c 5d359-True] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0xdbF03B407c01E7cD3CBea99509d93f8DDDC 8C6FB-True] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0xD1220A0cf47c7B9Be7A2E6BA89F429762e7 b9aDb-True] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0xd3cda913deb6f67967b99d67acdfa1712c2 93601-False] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0xD3CDA913DEB6F67967B99D67ACDFA1712C2 93601-False] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0XD1220A0CF47C7B9BE7A2E6BA89F429762E7 B9ADB-False] FAILED tests/core/address-utils/test_address_utils.py::test_is_checksum_address[0xd1220a0cf47c7b9be7a2e6ba89f429762e7 b9adb-False0] FAILED tests/core/address-utils/test_address_utils.py::test_to_checksum_address[0xd3cda913deb6f67967b99d67acdfa1712c2 93601-0xd3CdA913deB6f67967B99D67aCDFa1712C293601] FAILED tests/core/address-utils/test_address_utils.py::test_to_checksum_address[0xD3CDA913DEB6F67967B99D67ACDFA1712C2 93601-0xd3CdA913deB6f67967B99D67aCDFa1712C293601] FAILED tests/core/address-utils/test_address_utils.py::test_to_checksum_address[0xd3CdA913deB6f67967B99D67aCDFa1712C2 93601-0xd3CdA913deB6f67967B99D67aCDFa1712C293601] FAILED tests/core/address-utils/test_address_utils.py::test_to_checksum_address[\xd3\xcd\xa9\x13\xde\xb6\xf6yg\xb9\x9 dg\xac\xdf\xa1q,)6\x01-0xd3CdA913deB6f67967B99D67aCDFa1712C293601] FAILED tests/core/address-utils/test_address_utils.py::test_to_checksum_address[0xc6d9d2cd449a754c494264e1809c50e34d6 4562b-0xc6d9d2cD449A754c494264e1809c50e34D64562b] FAILED tests/core/address-utils/test_address_utils.py::test_to_checksum_address[c6d9d2cd449a754c494264e1809c50e34d645 62b-0xc6d9d2cD449A754c494264e1809c50e34D64562b] FAILED tests/core/address-utils/test_address_utils.py::test_to_checksum_address[\xc6\xd9\xd2\xcdD\x9auLIBd\xe1\x80\x9 cP\xe3MdV+-0xc6d9d2cD449A754c494264e1809c50e34D64562b] =
Copr build: https://copr.fedorainfracloud.org/coprs/build/8169043 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2320639-python-eth-utils/fedora-rawhide-x86_64/08169043-python-eth-utils/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
(In reply to Benson Muite from comment #2) > Perhaps exclude failing tests as pycryptodome and pycryptodome-test-vectors > are missing (may package > if time allows to see if they enable tests to pass associated copr > https://copr.fedorainfracloud.org/coprs/fed500/python-eth-utils): Sorry I can't reproduce these failures in Rawhide. All the tests seems to pass just fine there - see comment #3.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License". 71 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python-eth- utils/2320639-python-eth-utils/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3066 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [!]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-eth-utils-5.0.0-1.fc42.noarch.rpm python-eth-utils-5.0.0-1.fc42.src.rpm =============================================== rpmlint session starts ============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp1q87rlyd')] checks: 32, packages: 2 python-eth-utils.src: E: spelling-error ('codebases', 'Summary(en_US) codebases -> co debases, co-debases, code bases') python-eth-utils.src: E: spelling-error ('codebases', '%description -l en_US codebases -> co debases, co-debases, code bases') python3-eth-utils.noarch: E: spelling-error ('codebases', 'Summary(en_US) codebases -> co debases, co-debases, code bases') python3-eth-utils.noarch: E: spelling-error ('codebases', '%description -l en_US codebases -> co debases, co-debases, code bases') ========= 2 packages and 0 specfiles checked; 4 errors, 0 warnings, 11 filtered, 4 badness; has taken 2.9 s ========= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-eth-utils.noarch: E: spelling-error ('codebases', 'Summary(en_US) codebases -> co debases, co-debases, code bases') python3-eth-utils.noarch: E: spelling-error ('codebases', '%description -l en_US codebases -> co debases, co-debases, code bases') 1 packages and 0 specfiles checked; 2 errors, 0 warnings, 7 filtered, 2 badness; has taken 1.0 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/e/eth_utils/eth_utils-5.0.0.tar.gz : CHECKSUM(SHA256) this package : a5eb9555f43f4579eb83cb84f9dda9f3d6663bbd4a5a6b693f8d35045f305a1f CHECKSUM(SHA256) upstream package : a5eb9555f43f4579eb83cb84f9dda9f3d6663bbd4a5a6b693f8d35045f305a1f Requires -------- python3-eth-utils (rpmlib, GLIBC filtered): python(abi) python3.13dist(cytoolz) python3.13dist(eth-hash) python3.13dist(eth-typing) python3.13dist(hexbytes) Provides -------- python3-eth-utils: python-eth-utils python3-eth-utils python3.13-eth-utils python3.13dist(eth-utils) python3dist(eth-utils) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2320639 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: R, Java, fonts, SugarActivity, Perl, Haskell, PHP, Ocaml, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Ran correctly and did not get test failures b) Please upgrade to latest release 5.1.0 c) Source has egg-info directory. May want to remove this in the prep stage. d) Approved.
Thank you! I'll upgrade it and remove egg-infos before uploading .
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-eth-utils
FEDORA-2024-7ef4ef4469 (python-eth-utils-5.0.0-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7ef4ef4469
FEDORA-2024-2ad82d8fd9 (python-eth-utils-5.0.0-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2ad82d8fd9
FEDORA-2024-eed028bcfc (python-eth-utils-5.0.0-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-eed028bcfc
FEDORA-2024-eed028bcfc has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-eed028bcfc \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-eed028bcfc See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-2ad82d8fd9 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2ad82d8fd9 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2ad82d8fd9 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-7ef4ef4469 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7ef4ef4469 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7ef4ef4469 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-7ef4ef4469 (python-eth-utils-5.0.0-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-2ad82d8fd9 (python-eth-utils-5.0.0-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-eed028bcfc (python-eth-utils-5.0.0-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.