Fedora Account System
Red Hat Associate
Red Hat Customer
The execution of those macros kills the build. It seems due to a non-zero exit status when sourcing environment-modules. Though, there is no specific error printed. This seems to be the same issue we saw a while ago [1] and it boils down to what package is selected for providing `environment(modules)`. If the honor falls upon Lmod the build breaks. I fit happens to be `environment-modules` everything works. Last time this was hotfixed by having rpm-mpi-hooks depend on environment-modules instead of environment(modules) [2]. However, that fix was only applied to rawhide at the time. Ultimately, I think whatever package provides environment(modules) should also be useable in out build environments. In other words, I consider the dependency change applied a hack rather than a solution. [1] https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/SL4IL4SWBYIUZVGXNHTX6CRYDHPIXWMO/#7DPVV7PRXTR73BSXHQXLD6R5LANFIZUV [2] https://src.fedoraproject.org/rpms/rpm-mpi-hooks/c/90f8dfbf925a815820cd1bcdd469c8827a757b19?branch=rawhide Reproducible: Always Steps to Reproduce: 1. fedpkg clone python-lfpy 2. cd python-lfpy 3. fedpkg --release f40 mockbuild --no-cleanup-after Actual Results: Build fails if Lmod is selected as provider of environment(modules). Expected Results: Build succeeds regardless of selected environment(modules) provider. Both packages, Lmod and environment-modules, provide /etc/profile.d/modules.sh. The version from the latter appears to work while the former doesn't. Or I'm missing something and the issue is manifesting somewhere else entirely. For F40/F39 there's a workaround by explicitly specifying environment-modules as a build dependency. However, the reverse, specifying Lmod to get a breaking build in F41/rawhide, does not work. It will install both packages and apparently environment-modules gets to install environment-modules. I'm not sure that's desirable either. Maybe two providers of the same capability should conflict each other?
cc'ing the maintainers of environment-modules and rpm-mpi-hooks for awareness
I've been a bit hasty and sloppy. Let me clarify... (In reply to Sandro from comment #0) > The execution of those macros kills the build. It seems due to a non-zero > exit status when sourcing environment-modules. when sourcing /etc/profile.d/modules.sh > For F40/F39 there's a workaround by explicitly specifying > environment-modules as a build dependency. However, the reverse, specifying > Lmod to get a breaking build in F41/rawhide, does not work. It will install > both packages and apparently environment-modules gets to install > environment-modules. gets to install /etc/profile.d/modules.sh Let me know if anything else is unclear.
There are quite some packages affected by this issue. https://koschei.fedoraproject.org/affected-by/Lmod?epoch1=0&version1=8.7.37&release1=1.fc40&epoch2=0&version2=8.7.48&release2=1.fc40&collection=f40 I just recently came across this issue, when trying to update gretl in f40 and the build failed https://koji.fedoraproject.org/koji/buildinfo?buildID=2572608
I was working on cp2k update for unrelated reasons and I've made a change to remove the `source /etc/profile.d/modues.sh` and I have the pure `module load` commands running. The build seems to have detected the mpi environments just fine. Not sure why it is working though. I will re-run the builds for F40 and check the build logs again
I thik this is fixed in later Lmod releases. Starting some tests now...
Confirmed that 8.7.53 is working. FYI - for future debugging, this helps: export LMOD_SH_DBG_ON=1
FEDORA-2024-14d553a254 (Lmod-8.7.53-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-14d553a254
FEDORA-EPEL-2024-7ca00cd70b (Lmod-8.7.53-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7ca00cd70b
FEDORA-2024-b883c27c18 (Lmod-8.7.53-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b883c27c18
FEDORA-2024-602fe3db71 (Lmod-8.7.53-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-602fe3db71
FEDORA-EPEL-2024-14060f4306 (Lmod-8.7.53-1.el8) has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-14060f4306
I've also submitted buildroot overrides for the Fedora releases.
First of all thanks for the fix. Purely out of curiosity, do you happen to know or have a pointer to what got fixed where? When investigating the issue, I also tried running the first two commands %{_mpich_load} expands to inside the mock chroot. Nothing blew up. I just did so again with `export LMOD_SH_DBG_ON=1` (still on Lmod-8.7.49). It didn't give me any additional output. Anyway, I can confirm I'm able to build again (in Koji with the override) using Lmod as the environment(modules) provider.
FEDORA-2024-602fe3db71 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-602fe3db71` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-602fe3db71 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-7ca00cd70b has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7ca00cd70b See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-14060f4306 has been pushed to the Fedora EPEL 8 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-14060f4306 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-14d553a254 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-14d553a254` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-14d553a254 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b883c27c18 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b883c27c18` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b883c27c18 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b883c27c18 (Lmod-8.7.53-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-14d553a254 (Lmod-8.7.53-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-7ca00cd70b (Lmod-8.7.53-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-14060f4306 (Lmod-8.7.53-1.el8) has been pushed to the Fedora EPEL 8 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-602fe3db71 (Lmod-8.7.53-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.