Spec URL: https://www.ellert.se/review/xrootd-s3-http.spec SRPM URL: https://www.ellert.se/review/xrootd-s3-http-0.1.7-1.fc42.src.rpm Description: These filesystem plugins for XRootD allow you to serve objects from S3 and HTTP backends through an XRootD server. Fedora Account System Username: ellert
Copr build: https://copr.fedorainfracloud.org/coprs/build/8173380 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2321590-xrootd-s3-http/fedora-rawhide-x86_64/08173380-xrootd-s3-http/fedora-review/review.txt Found issues: - Unversioned so-files directly in %_libdir. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Hello, I've inspected the package according to the review guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/ReviewGuidelines/ Also ran the "fedora-review" tool with the following result: Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files directly in %_libdir. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_devel_packages ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [ ]: Package contains desktop file if it is a GUI application. [ ]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [ ]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [ ]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 4259 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [ ]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane. [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [ ]: Patches link to upstream bugs/comments/lists or are otherwise justified. [ ]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. [x]: Package should compile and build into binary rpms on all supported architectures. [ ]: %check is present and all tests pass. [ ]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). [x]: Rpmlint is run on all installed packages. [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: xrootd-s3-http-0.1.7-1.fc42.x86_64.rpm xrootd-s3-http-0.1.7-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmphlw28knr')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 20 filtered, 0 badness; has taken 0.8 s Rpmlint (debuginfo) ------------------- Checking: xrootd-s3-http-debuginfo-0.1.7-1.fc42.x86_64.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpe7ncth82')] checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 12 filtered, 0 badness; has taken 0.3 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 27 filtered, 0 badness; has taken 0.6 s Unversioned so-files -------------------- xrootd-s3-http: /usr/lib64/libXrdHTTPServer-5.so xrootd-s3-http: /usr/lib64/libXrdS3-5.so Source checksums ---------------- https://github.com/PelicanPlatform/xrootd-s3-http/archive/refs/tags/v0.1.7/xrootd-s3-http-0.1.7.tar.gz : CHECKSUM(SHA256) this package : aef7c27fb8ad3b6de6ebddff0a6b47c425720386d519b099000339f18bbcf498 CHECKSUM(SHA256) upstream package : aef7c27fb8ad3b6de6ebddff0a6b47c425720386d519b099000339f18bbcf498 Requires -------- xrootd-s3-http (rpmlib, GLIBC filtered): libXrdServer.so.3()(64bit) libXrdUtils.so.3()(64bit) libc.so.6()(64bit) libcrypto.so.3()(64bit) libcrypto.so.3(OPENSSL_3.0.0)(64bit) libcurl.so.4()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.7)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libtinyxml2.so.9()(64bit) rtld(GNU_HASH) xrootd-server Provides -------- xrootd-s3-http: libXrdHTTPServer-5.so()(64bit) libXrdS3-5.so()(64bit) xrootd-s3-http xrootd-s3-http(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review --bug 2321590 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Ocaml, SugarActivity, Perl, Java, R, fonts, Python, C/C++, PHP, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH ------------------------ The only non-conformity I see are the unversioned ".so" libraries. According to https://docs.fedoraproject.org/en-US/packaging-guidelines/#_unversioned_shared_objects , the use-case is acceptable if the libraries are plugins (as is the case) AND placed in a private folder of the main package. However, to my knowledge, xrootd-server plugins don't have a private folder where to put plugin .SO libraries. Please comment on the above, then we can close the review. Everything else looks ok! Cheers, Mihai
As you already pointed out, these are plugins. Xrootd expects the plugins to be in the default library path and does not use a separate subfolder for plugins. However, xrootd has something similar to a soname for its plugins, namely the plugin version. In this case the -5 in the plugin names indicate these are plugins for xrootd major version 5: /usr/lib64/libXrdHTTPServer-5.so /usr/lib64/libXrdS3-5.so This plugin version serves the same purpose as the soname, in a way. It is possible to install e.g. both an xrootd with major version 4 and major version 5 in parallel and have both versions have their plugins in /usr/lib(64) without filename conflicts. The plugin interfaces are guaranteed not to change within the same major version.
Hello Mattias, You are right, I overlooked the "-5" major version that's part of the library name. Ok, marking package review as approved. Cheers, Mihai
The Pagure repository was created at https://src.fedoraproject.org/rpms/xrootd-s3-http
FEDORA-EPEL-2024-4cec45bf51 (xrootd-s3-http-0.1.7-2.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-4cec45bf51
FEDORA-2024-d29e01f191 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-d29e01f191 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-d29e01f191 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-a05baa97e7 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-a05baa97e7 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-a05baa97e7 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-4cec45bf51 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-4cec45bf51 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-4cec45bf51 (xrootd-s3-http-0.1.7-2.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-d29e01f191 (xrootd-s3-http-0.1.7-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-a05baa97e7 (xrootd-s3-http-0.1.7-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.