Bug 232171 - (pear-File-SMBPasswd) Review Request: php-pear-File-SMBPasswd - Class for managing SAMBA style password files
Review Request: php-pear-File-SMBPasswd - Class for managing SAMBA style pass...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
:
Depends On:
Blocks:
  Show dependency treegraph
 
Reported: 2007-03-13 22:20 EDT by Christopher Stone
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-05-15 10:16:23 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
tibbs: fedora‑review+
wtogami: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Christopher Stone 2007-03-13 22:20:51 EDT
Spec URL: http://tkmame.retrogames.com/fedora-extras/php-pear-File-SMBPasswd.spec
SRPM URL: http://tkmame.retrogames.com/fedora-extras/php-pear-File-SMBPasswd-1.0.2-1.src.rpm

Description:
With this package, you can maintain smbpasswd-files, usualy used by SAMBA.
Comment 1 Jason Tibbitts 2007-05-06 14:11:41 EDT
As usual, builds cleanly and rpmlint is silent.

* source files match upstream:
   93b1c58ea0576629c97a6eb6ab45b474191957866503760432721ea21dd7296d  
   File_SMBPasswd-1.0.2.tgz
* package meets naming and versioning guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is OK.
* license field matches the actual license.
* license is open source-compatible.
* license text not included upstream.
* latest version is being packaged.
* BuildRequires are proper.
* %clean is present.
* package builds in mock (development, x86_64).
* package installs properly
* rpmlint is silent.
* final provides and requires are sane:
   php-pear(File_SMBPasswd) = 1.0.2
   php-pear-File-SMBPasswd = 1.0.2-1.fc7
  =
   /bin/sh
   /usr/bin/pear
   php-pear(Crypt_CHAP) >= 1.0.0
   php-pear(PEAR)

* %check is not present; no test suite upstream.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
  /usr/share/pear/File is also owned by php-pear-File, but it's not a dependency
  and doesn't need to be.
* no duplicates in %files.
* file permissions are appropriate.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.

APPROVED
Comment 2 Christopher Stone 2007-05-13 02:15:07 EDT
New Package CVS Request
=======================
Package Name: php-pear-File-SMBPasswd
Short Description: Class for managing SAMBA style password files
Owners: chris.stone@gmail.com
Branches: FC-5 FC-6 EL-5
InitialCC: 
Comment 3 Christopher Stone 2007-05-15 10:16:23 EDT
Build for all branches successful, thanks for the review!

Note You need to log in before you can comment on or make changes to this bug.