Spec URL: https://lecris.fedorapeople.org/reviews/rust-auto_enums/rust-auto_enums.spec SRPM URL: https://lecris.fedorapeople.org/reviews/rust-auto_enums/rust-auto_enums-0.8.6-1.fc42.src.rpm Description: A library for to allow multiple return types by automatically generated enum.
Created attachment 2054249 [details] rust2rpm.toml
Copr build: https://copr.fedorainfracloud.org/coprs/build/8186337 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2322418-rust-auto_enums/fedora-rawhide-x86_64/08186337-rust-auto_enums/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
[fedora-review-service-build]
Copr build: https://copr.fedorainfracloud.org/coprs/build/8362133 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2322418-rust-auto_enums/fedora-rawhide-x86_64/08362133-rust-auto_enums/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I really don't like it when Cargo.toml is manipulated in two different ways (both patch *and* tomcli), but that's your choice. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass (some tests that don't work disabled) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
I usually go for `tomcli` patches for persistent patches and normal `patch` for ephemeral or spec-changing ones. I believe I chose the latter because it is necessary, but also manually patching out the tests since they are persistently unsupported. I guess I could also change the `features.enable-all` and hide the relevant ones, but I want to see more how this project evolves in its releases on how these features change.
Thank you for the review, Fabio
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-auto_enums
FEDORA-2024-21e2a892a4 (rust-auto_enums-0.8.6-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-21e2a892a4
FEDORA-2024-21e2a892a4 (rust-auto_enums-0.8.6-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-54caa81186 (rust-auto_enums-0.8.6-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-54caa81186
FEDORA-2024-7e989a87ec (rust-auto_enums-0.8.6-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7e989a87ec
FEDORA-2024-54caa81186 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-54caa81186` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-54caa81186 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-7e989a87ec has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7e989a87ec` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7e989a87ec See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-54caa81186 (rust-auto_enums-0.8.6-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7e989a87ec (rust-auto_enums-0.8.6-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.