Spec URL: https://jjelen.fedorapeople.org/rust-bimap.spec SRPM URL: https://jjelen.fedorapeople.org/rust-bimap-0.6.3-1.fc42.src.rpm Description: bimap-rs is a pure Rust library for dealing with bijective maps, aiming to feel like an extension of the standard library's data structures whenever possible. Fedora Account System Username: jjelen Copr build on rawhide+f41: https://copr.fedorainfracloud.org/coprs/jjelen/kryoptic/build/8189433/
Copr build: https://copr.fedorainfracloud.org/coprs/build/8189466 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2322726-rust-bimap/fedora-rawhide-x86_64/08189466-rust-bimap/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> # Manually created patch for downstream crate metadata changes > Patch: bimap-fix-metadata.diff Please add a comment line what this patch actually changes.
Thanks! Updated the spec file to contain the description of the patch + link to upstream PR. Spec URL: https://jjelen.fedorapeople.org/rust-bimap.spec SRPM URL: https://jjelen.fedorapeople.org/rust-bimap-0.6.3-1.fc42.src.rpm
Created attachment 2054371 [details] The .spec file difference from Copr build 8189466 to 8190261
Copr build: https://copr.fedorainfracloud.org/coprs/build/8190261 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2322726-rust-bimap/fedora-rawhide-x86_64/08190261-rust-bimap/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Thanks, looks good to me now! The description field is a bit too wide (should be <= 72 characters, AFAIK), but that's not that important. You can persist your manual modifications with a rust2rpm.toml settings file like this (usually committed into dist-git): ```toml [package] description = """\ bimap-rs is a pure Rust library for dealing with bijective maps, aiming to feel like an extension of the standard librarys data structures whenever possible.""" cargo-toml-patch-comments = [ "Bump hashbrown to current version: https://github.com/billyrieger/bimap-rs/pull/48", ] """ Though I would recommend to change the comment for the patch to not say "latest", but "0.15". As soon as 0.16 is released by upstream, the current comment will be wrong :) === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-bimap
Thank you! Adjusted and pushing and building now. Added monitoring now and will keep an eye on the other steps if they will be done or not.
FEDORA-2024-2c068587e5 (rust-bimap-0.6.3-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2c068587e5
FEDORA-2024-2c068587e5 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2c068587e5 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2c068587e5 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-2c068587e5 (rust-bimap-0.6.3-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.