Description of problem:
You can shut down the clvmd daemon with active volume groups.
The clvmd init script does a vgchange -aln for each clustered vg.
If the vgchange is unsuccessful, it returns $? as 0, but if it's
successful, it returns 1.  Later in the script, it checks the
return code, but it checks the wrong value.  So either vgchange
is returning the opposite return code, or else the init script
should be changed to check it correctly.

Version-Release number of selected component (if applicable):
RHEL5

How reproducible:
Very

Steps to Reproduce:

[root@trin-10 ~]# service clvmd start
Starting clvmd:                                            [  OK  ]
Activating VGs:   1 logical volume(s) in volume group "bob_vg" now active
  1 logical volume(s) in volume group "trin_vg" now active
  2 logical volume(s) in volume group "VolGroup00" now active
                                                           [  OK  ]
[root@trin-10 ~]# mount -tgfs /dev/bob_vg/lvol0 /mnt/gfs1
[root@trin-10 ~]# service clvmd stop
Deactivating VG bob_vg:   Can't deactivate volume group "bob_vg" with 1 open
logical volume(s)
                                                           [FAILED]
Deactivating VG trin_vg:   0 logical volume(s) in volume group "trin_vg" now active
                                                           [  OK  ]
Stopping clvm:                                             [  OK  ]
  
Actual results:
The clvmd daemon is stopped with bob_vg still active.

Expected results:
The clvmd daemon should not be stopped with active volume groups.

Additional info:
The following patch fixes the init script so that it works.
It also fixes an annoying typo:

[root@trin-10 /etc/init.d]# diff clvmd.orig clvmd
86c86
<               [ $rtrn -ne 0 ] && break
---
>               [ $rtrn -eq 0 ] && break
88c88
<               echo -n "Stopping clvm:"
---
>               echo -n "Stopping clvmd:"

The script would work just fine if vgchange returned a non-zero
return code on (active vg) errors and zero on (inactive vg) successes.