spec: https://download.copr.fedorainfracloud.org/results/fed500/chibicc/fedora-rawhide-x86_64/08239727-chibicc/chibicc.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/chibicc/fedora-rawhide-x86_64/08239727-chibicc/chibicc-0.0%5E20201207.90d1f7f-1.fc42.src.rpm description: chibicc is yet another small C compiler that implements most C11 features. Even though it still probably falls into the "toy compilers" category just like other small compilers do, chibicc can compile several real-world programs, including Git, SQLite, libpng and chibicc itself, without making modifications to the compiled programs. Generated executables of these programs pass their corresponding test suites. So, chibicc actually supports a wide variety of C11 features and is able to compile hundreds of thousands of lines of real-world C code correctly. If you like this project, please consider purchasing a copy of the book when it becomes available! I publish the source code here to give people early access to it, because I was planing to do that anyway with a permissive open-source license after publishing the book. If I don't charge for the source code, it doesn't make much sense to me to keep it private. fas: fed500 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8239729 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2325026-chibicc/fedora-rawhide-x86_64/08239729-chibicc/fedora-review/review.txt Found issues: - chibicc : /usr/include/chibicc.h chibicc : /usr/include/chibicc/float.h chibicc : /usr/include/chibicc/stdalign.h chibicc : /usr/include/chibicc/stdarg.h chibicc : /usr/include/chibicc/stdatomic.h chibicc : /usr/include/chibicc/stdbool.h chibicc : /usr/include/chibicc/stddef.h chibicc : /usr/include/chibicc/stdnoreturn.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Indicate only for x86_64 architecture spec: https://download.copr.fedorainfracloud.org/results/fed500/chibicc/fedora-rawhide-x86_64/08240671-chibicc/chibicc.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/chibicc/fedora-rawhide-x86_64/08240671-chibicc/chibicc-0.0%5E20201207.90d1f7f-1.fc42.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=125738596
Created attachment 2057009 [details] The .spec file difference from Copr build 8239729 to 8240712
Copr build: https://copr.fedorainfracloud.org/coprs/build/8240712 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2325026-chibicc/fedora-rawhide-x86_64/08240712-chibicc/fedora-review/review.txt Found issues: - chibicc : /usr/include/chibicc.h chibicc : /usr/include/chibicc/float.h chibicc : /usr/include/chibicc/stdalign.h chibicc : /usr/include/chibicc/stdarg.h chibicc : /usr/include/chibicc/stdatomic.h chibicc : /usr/include/chibicc/stdbool.h chibicc : /usr/include/chibicc/stddef.h chibicc : /usr/include/chibicc/stdnoreturn.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
A couple of issues. 1) Delete the block at the top, it's not needed at all: ## START: Set by rpmautospec ## (rpmautospec version 0.7.2) ## RPMAUTOSPEC: autorelease, autochangelog %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: release_number = 1; base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}")); print(release_number + base_release_number - 1); }%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}} ## END: Set by rpmautospec 2) For the Version field, since you are declaring the %shortcommit macro above, please use in the Version field: Version: 0.0^20201207.%{shortcommit} Personally, I would do it like the following: %global commit 90d1f7f199cc55b13c7fdb5839d1409806633fdb %global shortcommit %(c=%{commit}; echo ${c:0:7}) %global date 20201207 Name: chibicc Version: 0.0^%{date}.%{shortcommit} 3) In the install section, whenever you are using the install command, please also pass "-p" to preserve timestamps: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_timestamps 4) In the %changelog section, remove everything and just use %autochangelog to have the changelog automatically populated with git commit messages: %changelog %autochangelog
btw, just out of curiosity, why are you trying to package what it looks like an unfinished compiler which was last updated more than 4 years ago?
(In reply to Simone Caronni from comment #6) > btw, just out of curiosity, why are you trying to package what it looks like > an unfinished compiler which was last updated more than 4 years ago? It is helpful to have a number of small C compilers to use when building other projects where clang or gcc would produce output that is more difficult to understand. Fixed other issues. spec: https://fed500.fedorapeople.org/chibicc.spec srpm: https://fed500.fedorapeople.org/chibicc-0.0^20201207.90d1f7f-1.fc42.src.rpm
Created attachment 2064307 [details] The .spec file difference from Copr build 8240712 to 8455875
Copr build: https://copr.fedorainfracloud.org/coprs/build/8455875 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2325026-chibicc/fedora-rawhide-x86_64/08455875-chibicc/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package approved.
The Pagure repository was created at https://src.fedoraproject.org/rpms/chibicc
FEDORA-2025-a105d85122 (chibicc-0.0^20201207.90d1f7f-2.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2025-a105d85122
FEDORA-2025-b3dbacb6d2 (chibicc-0.0^20201207.90d1f7f-2.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2025-b3dbacb6d2
Thanks for the review.
FEDORA-2025-a105d85122 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-a105d85122 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-a105d85122 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-b3dbacb6d2 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-b3dbacb6d2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-b3dbacb6d2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2025-a105d85122 (chibicc-0.0^20201207.90d1f7f-2.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2025-b3dbacb6d2 (chibicc-0.0^20201207.90d1f7f-2.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.