Spec URL: https://music.fedorapeople.org/python-pytest-freezer.spec SRPM URL: https://music.fedorapeople.org/python-pytest-freezer-0.4.8-1.fc41.src.rpm Description: Pytest plugin providing a fixture interface for freezegun. Fedora Account System Username: music
Copr build: https://copr.fedorainfracloud.org/coprs/build/8240206 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2325070-python-pytest-freezer/fedora-rawhide-x86_64/08240206-python-pytest-freezer/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "*No copyright* MIT License", "Unknown or generated". 4 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python-pytest- freezer/2325070-python-pytest-freezer/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13/site-packages/__pycache__, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-pytest-freezer-0.4.8-1.fc42.noarch.rpm python-pytest-freezer-0.4.8-1.fc42.src.rpm =============================================== rpmlint session starts ============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpjf2kedbv')] checks: 32, packages: 2 python-pytest-freezer.src: E: spelling-error ('freezegun', 'Summary(en_US) freezegun -> freeze gun, freeze-gun, freezer') python-pytest-freezer.src: E: spelling-error ('freezegun', '%description -l en_US freezegun -> freeze gun, freeze-gun, freezer') python3-pytest-freezer.noarch: E: spelling-error ('freezegun', 'Summary(en_US) freezegun -> freeze gun, freeze-gun, freezer') python3-pytest-freezer.noarch: E: spelling-error ('freezegun', '%description -l en_US freezegun -> freeze gun, freeze-gun, freezer') python3-pytest-freezer.noarch: W: no-documentation ========== 2 packages and 0 specfiles checked; 4 errors, 1 warnings, 9 filtered, 4 badness; has taken 3.3 s ========= Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-pytest-freezer.noarch: E: spelling-error ('freezegun', 'Summary(en_US) freezegun -> freeze gun, freeze-gun, freezer') python3-pytest-freezer.noarch: E: spelling-error ('freezegun', '%description -l en_US freezegun -> freeze gun, freeze-gun, freezer') python3-pytest-freezer.noarch: W: no-documentation 1 packages and 0 specfiles checked; 2 errors, 1 warnings, 5 filtered, 2 badness; has taken 0.9 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/p/pytest_freezer/pytest_freezer-0.4.8.tar.gz : CHECKSUM(SHA256) this package : 8ee2f724b3ff3540523fa355958a22e6f4c1c819928b78a7a183ae4248ce6ee6 CHECKSUM(SHA256) upstream package : 8ee2f724b3ff3540523fa355958a22e6f4c1c819928b78a7a183ae4248ce6ee6 Requires -------- python3-pytest-freezer (rpmlib, GLIBC filtered): python(abi) python3.13dist(freezegun) python3.13dist(pytest) Provides -------- python3-pytest-freezer: python-pytest-freezer python3-pytest-freezer python3.13-pytest-freezer python3.13dist(pytest-freezer) python3dist(pytest-freezer) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2325070 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: fonts, SugarActivity, Haskell, Perl, C/C++, Java, Ocaml, R, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) license file is available at both /usr/share/license/python3-pytest-freezer/LICENSE /usr/lib/python3.13/site-packages/pytest_freezer-0.4.8.dist-info/LICENSE though only the first has metadata. Thus neither %pyproject_save_files pytest_freezer -l nor %pyproject_save_files pytest_freezer -L is appropriate, but maybe worth updating this macro to have a flag for this case at some point? b) Approved c) Review of one of: https://bugzilla.redhat.com/show_bug.cgi?id=2322084 https://bugzilla.redhat.com/show_bug.cgi?id=2322082 would be appreciated if time allows.
Thank you for the review! (In reply to Benson Muite from comment #2) > - Package must not depend on deprecated() packages. > Note: python3-pytest7 is deprecated, you must not depend on it. Just noting that this is a false positive. > Comments: > a) license file is available at both > /usr/share/license/python3-pytest-freezer/LICENSE > /usr/lib/python3.13/site-packages/pytest_freezer-0.4.8.dist-info/LICENSE > though only the first has metadata. Thus neither > %pyproject_save_files pytest_freezer -l > nor > %pyproject_save_files pytest_freezer -L > is appropriate, but maybe worth updating this macro to have a flag for this > case at some point? Thanks for bringing this up. This is actually a perfect case for adding -L. Adding it isn’t required, but it’s a good idea. Passing -L asserts that %pyproject_save_files didn’t mark any license files. There is almost always still a license file in the .dist-info directory, but the build backend (flit-core in this case) didn’t support PEP 639 so it wasn’t installed with %license. If I add -L, then the build will start failing if the build backend is updated to support PEP 639 or the project switches to a different build backend that supports it, and that will be my cue to remove the manually- installed license file. > > b) Approved Again, thanks for the review! > c) Review of one of: > https://bugzilla.redhat.com/show_bug.cgi?id=2322084 > https://bugzilla.redhat.com/show_bug.cgi?id=2322082 > would be appreciated if time allows. Sure, they look straightforward enough. I’ll take both of them.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pytest-freezer
On import, I changed "%pyproject_save_files pytest_freezer" to "%pyproject_save_files -L pytest_freezer" and added "%doc README.rst" to %files. I also added a .rpmlintrc file, configured Packit, and added the distribution mapping for release monitoring at https://release-monitoring.org/project/299003/.
FEDORA-2024-5a227ee7fb (python-pytest-freezer-0.4.8-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-5a227ee7fb
FEDORA-2024-5a227ee7fb (python-pytest-freezer-0.4.8-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7dc04894ba (python-pytest-freezer-0.4.8-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-7dc04894ba
FEDORA-2024-af59332717 (python-pytest-freezer-0.4.8-1.fc39) has been submitted as an update to Fedora 39. https://bodhi.fedoraproject.org/updates/FEDORA-2024-af59332717
FEDORA-EPEL-2024-c6a1c596a3 (python-pytest-freezer-0.4.8-1.el10_0) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-c6a1c596a3
FEDORA-EPEL-2024-7dea30a258 (python-pytest-freezer-0.4.8-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7dea30a258
FEDORA-2024-25141ecfd1 (python-inline-snapshot-0.14.0-3.fc41 and python-pytest-freezer-0.4.8-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-25141ecfd1
FEDORA-EPEL-2024-7dea30a258 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-7dea30a258 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-25141ecfd1 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-25141ecfd1` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-25141ecfd1 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-7dc04894ba has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-7dc04894ba \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-7dc04894ba See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-af59332717 has been pushed to the Fedora 39 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-af59332717 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-af59332717 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-c6a1c596a3 has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-c6a1c596a3 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-af59332717 (python-pytest-freezer-0.4.8-1.fc39) has been pushed to the Fedora 39 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-7dea30a258 (python-pytest-freezer-0.4.8-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-7dc04894ba (python-pytest-freezer-0.4.8-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-25141ecfd1 (python-inline-snapshot-0.14.0-3.fc41 and python-pytest-freezer-0.4.8-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-c6a1c596a3 (python-pytest-freezer-0.4.8-1.el10_0) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.