Spec URL: https://download.copr.fedorainfracloud.org/results/finlike/nota/srpm-builds/08249466/nota.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/finlike/nota/srpm-builds/08249466/nota-4.0.0-1.fc41.src.rpm Description: Nota is a simple text editor for desktop and mobile computers that use the Maui framework Fedora Account System Username: finlike This is my first package and i'm looking for a sponsor :)
Copr build: https://copr.fedorainfracloud.org/coprs/build/8249526 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2325807-nota/fedora-rawhide-x86_64/08249526-nota/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Cannot sponsor, but can review.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Package contains no static executables. [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "GNU General Public License, Version 3", "Unknown or generated", "Creative Commons CC0 1.0", "GNU Lesser General Public License, Version 3", "*No copyright* GNU Lesser General Public License, Version 3", "BSD 3-Clause License", "LGPL (v2.1 or v3)". 81 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/nota/2325807-nota/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [ ]: Sources contain only permissible code or content. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [ ]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [ ]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package contains desktop file if it is a GUI application. [x]: Package installs a %{name}.desktop using desktop-file-install or desktop-file-validate if there is such a file. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [ ]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Cannot parse rpmlint output: Rpmlint (debuginfo) ------------------- Cannot parse rpmlint output: Rpmlint (installed packages) ---------------------------- Cannot parse rpmlint output: Source checksums ---------------- https://invent.kde.org/maui/nota/-/archive/v4.0.0/nota-v4.0.0.tar.gz : CHECKSUM(SHA256) this package : 19100bd92a2148cd2508cc4ff1268cde8844d632a4d345c291bbd9ddfa3f99c6 CHECKSUM(SHA256) upstream package : 19100bd92a2148cd2508cc4ff1268cde8844d632a4d345c291bbd9ddfa3f99c6 Requires -------- nota (rpmlib, GLIBC filtered): hicolor-icon-theme libKF6CoreAddons.so.6()(64bit) libKF6I18n.so.6()(64bit) libMauiKit4.so.4()(64bit) libMauiKitFileBrowsing4.so.4()(64bit) libMauiKitTextEditor4.so.4()(64bit) libQt6Core.so.6()(64bit) libQt6Core.so.6(Qt_6)(64bit) libQt6Core.so.6(Qt_6.8)(64bit) libQt6DBus.so.6()(64bit) libQt6DBus.so.6(Qt_6)(64bit) libQt6Gui.so.6()(64bit) libQt6Gui.so.6(Qt_6)(64bit) libQt6Qml.so.6()(64bit) libQt6Qml.so.6(Qt_6)(64bit) libQt6Quick.so.6()(64bit) libQt6Quick.so.6(Qt_6)(64bit) libQt6Widgets.so.6()(64bit) libQt6Widgets.so.6(Qt_6)(64bit) libc.so.6()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) maui-mauikit-documents maui-mauikit-filebrowsing maui-mauikit-terminal rtld(GNU_HASH) nota-debuginfo (rpmlib, GLIBC filtered): nota-debugsource (rpmlib, GLIBC filtered): Provides -------- nota: application() application(org.kde.nota.desktop) metainfo() metainfo(org.kde.nota.metainfo.xml) mimehandler(text/plain) nota nota(x86-64) nota-debuginfo: debuginfo(build-id) nota-debuginfo nota-debuginfo(x86-64) nota-debugsource: nota-debugsource nota-debugsource(x86-64) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2325807 Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Generic, Shell-api Disabled plugins: Java, SugarActivity, Perl, PHP, Ocaml, R, fonts, Python, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Consider using %autorelease and %autochangelog macros to ease maintenance b) Metainfo file which is installed is under CC0 license Creative Commons CC0 1.0 ------------------------ nota-4.0.0-build/nota-v4.0.0/org.kde.nota.metainfo.xml Please add a license breakdown in the spec file and indicate this. c) A jar file is distributed with the source: https://invent.kde.org/maui/nota/-/tree/master/src/android_files/gradle/wrapper?ref_type=heads It is not used, but the licensing is unclear. Get clarification on the licensing and remove it in the prep section if it is something that can be distributed, or remove it as a pre-processing step: https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#prebuilt-binaries-or-libraries https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code Ideally, ensure that the jar file is removed from the releases for Linux distributions. d) Library requires are usually automatically generated, so can remove: Requires: maui-mauikit-filebrowsing Requires: maui-mauikit-terminal Requires: maui-mauikit-documents
updated spec: https://download.copr.fedorainfracloud.org/results/finlike/nota/fedora-rawhide-x86_64/08256032-maui-mauikit-nota/maui-mauikit-nota.spec updated srpm: https://download.copr.fedorainfracloud.org/results/finlike/nota/fedora-rawhide-x86_64/08256032-maui-mauikit-nota/maui-mauikit-nota-4.0.0-1.fc42.src.rpm
Created attachment 2057780 [details] The .spec file difference from Copr build 8249526 to 8261912
Copr build: https://copr.fedorainfracloud.org/coprs/build/8261912 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2325807-nota/fedora-rawhide-x86_64/08261912-maui-mauikit-nota/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Comments: a) Thanks for name update b) The file src/android_files/gradle/wrapper/gradle-wrapper.jar is still in the source tarball. It is unclear where it comes from, raise an issue in the upstream repository or remove it. See: https://docs.fedoraproject.org/en-US/packaging-guidelines/what-can-be-packaged/#prebuilt-binaries-or-libraries https://docs.fedoraproject.org/en-US/packaging-guidelines/SourceURL/#when-upstream-uses-prohibited-code c) Packagers should not change licenses. Check with upstream if they want to update the licenses, and if so add a link to the corresponding accepted merge request in the spec file. See https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_fedora_licensing
updated srpm: https://download.copr.fedorainfracloud.org/results/finlike/nota/fedora-rawhide-x86_64/08269187-maui-mauikit-nota/maui-mauikit-nota-4.0.0-1.fc42.src.rpm updated spec: https://download.copr.fedorainfracloud.org/results/finlike/nota/fedora-rawhide-x86_64/08269187-maui-mauikit-nota/maui-mauikit-nota.spec just now i saw that fedora-review automatically build the copr lol, anyway i updated the spec to indicate that i already made the pr to fix the licensing, it was accepted not merged yet, here is the github that i put the original files https://github.com/vinicius-daros/maui-mauikit-nota.rpm and here's the copr that i was testing https://copr.fedorainfracloud.org/coprs/finlike/nota/build/8269187/
Copr build: https://copr.fedorainfracloud.org/coprs/build/8269640 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2325807-maui-mauikit-nota/fedora-rawhide-x86_64/08269640-maui-mauikit-nota/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
a) Merge request has been approved, but a rebase is needed: https://invent.kde.org/maui/nota/-/merge_requests/11/diffs b) jar file is under an appropriate license: https://github.com/gradle/gradle/issues/14968 Please add a note in the spec file indicating it can be re-distributed as it is under Apache 2.0 license. c) Approved. Please resolve above two issues before importing. Once these are resolved please see: https://docs.fedoraproject.org/en-US/package-maintainers/Joining_the_Package_Maintainers/ https://docs.fedoraproject.org/en-US/package-maintainers/How_to_Get_Sponsored_into_the_Packager_Group/#how_to_find_a_sponsor
Hello @finlike, since this is your first Fedora package, you need to get sponsored by a package sponsor before it can be accepted. A sponsor is an experienced package maintainer who will guide you through the processes that you will follow and the tools that you will use as a future maintainer. A sponsor will also be there to answer your questions related to packaging. You can find all active sponsors here: https://docs.pagure.org/fedora-sponsors/ I created a sponsorship request for you: https://pagure.io/packager-sponsors/issue/694 Please take a look and make sure the information is correct. Thank you, and best of luck on your packaging journey. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service
(In reply to Benson Muite from comment #10) > a) Merge request has been approved, but a rebase is needed: > https://invent.kde.org/maui/nota/-/merge_requests/11/diffs > > b) jar file is under an appropriate license: > https://github.com/gradle/gradle/issues/14968 > Please add a note in the spec file indicating it can be > re-distributed as it is under Apache 2.0 license. > > c) Approved. Please resolve above two issues before importing. > Once these are resolved please see: > https://docs.fedoraproject.org/en-US/package-maintainers/ > Joining_the_Package_Maintainers/ > https://docs.fedoraproject.org/en-US/package-maintainers/ > How_to_Get_Sponsored_into_the_Packager_Group/#how_to_find_a_sponsor Fixed!, thanks for all the help