Red Hat Bugzilla – Bug 232602
Kernel %prep should not modify files in SOURCES (patch included)
Last modified: 2009-05-26 16:45:56 EDT
Description of problem:
In %prep the *.config files from SOURCES are modified (merge.pl etc.) and the
original files are replaced by the modified ones! This is IMHO a serious RPM
packaging bug, as now (for example) the src.rpm files created with "rpmbuild
-bs" and with "rpmbuild -ba" will have different contents (source files)!
Version-Release number of selected component (if applicable):
2.6.18-8.1.1.el5 (but this problem seems to be in since a while, sorry I didn't
notice it during the beta period ;-)).
Compare the src.rpm's created with "rpmbuild -bs" and with "rpmbuild -ba".
Modify the *.config files in the build directory, don't change the files in
SOURCES. Attached is a patch for the kerrnel spec file that does this. Note
that the wildcards will not always match files now, that's why I included the
test (-f), so that if there is no match, the "$i" will still have the "*" and
the file does not exist.
Created attachment 150212 [details]
Patch for kernel-2.6.spec (2.6.18-8.1.1.el5)
Thanks. It's been like that for about a year now. We just have never noticed.
I'll look into making these changes for 5.2. They look straightforward.
Funny, I just started work on a patch for the rawhide spec last night that does
a lot of the same things... :) Yeah, those changes definitely look sane and
correct for the RHEL5 spec.
You can download this test kernel from http://people.redhat.com/dzickus/el5
This should have went out with the 5.2 release. I am just going to close this a CURRENT RELEASE unless someone has a better idea.