Red Hat Bugzilla – Bug 232612
Review Request: perl-Class-Observable - Allow other classes and objects to respond to events in yours
Last modified: 2007-11-30 17:11:59 EST
Spec URL: http://home.bawue.de/~ixs/perl-Class-Observable/perl-Class-Observable.spec
SRPM URL: http://home.bawue.de/~ixs/perl-Class-Observable/perl-Class-Observable-1.04-1.src.rpm
If you have ever used Java, you may have run across the
java.util.Observable class and the java.util.Observer interface. With them
you can decouple an object from the one or more objects that wish to be
notified whenever particular events occur.
*** Bug 231755 has been marked as a duplicate of this bug. ***
%if "%fedora" >= "7"
Is highly non-portable, and indeed, causes the package to fail to rebuild even
on Fedora machines if %fedora hasn't been defined somewhere. With the
still-being-worked-through perl/perl-devel split, the preferred (well, to me
at least) and, more importantly, portable way of pulling in perl-devel is to
have a buildrequires on the module used to handle the build. In this case,
we're in a standard Makefile.PL situation, so adding a buildrequires against
perl(ExtUtils::MakeMaker) will be both portable and cause perl-devel to be
Replace the conditional with a BuildRequires: perl(ExtUtils::MakeMaker) and
I'll approve the package.
+ source files match upstream:
+ package meets naming and versioning guidelines.
+ specfile is properly named, is cleanly written and uses macros consistently.
+ dist tag is present.
+ build root is correct.
+ license field matches the actual license.
+ license is open source-compatible. License text not included upstream.
+ latest version is being packaged.
+ BuildRequires are proper.
+ compiler flags are appropriate.
+ %clean is present.
+ package installs properly
O noarch -- no debuginfo package
+ rpmlint is silent.
+ final provides and requires are sane:
perl-Class-Observable = 1.04-1.fc6
+ %check is present and all tests pass:
All tests successful.
Files=2, Tests=39, 0 wallclock secs ( 0.10 cusr + 0.04 csys = 0.14 CPU)
+ no shared libraries are added to the regular linker search paths.
+ owns the directories it creates.
+ doesn't own any directories it shouldn't.
+ no duplicates in %files.
+ file permissions are appropriate.
+ no scriptlets present.
+ code, not content.
+ documentation is small, so no -docs subpackage is necessary.
+ %docs are not necessary for the proper functioning of the package.
+ no headers.
+ no pkgconfig files.
+ no libtool .la droppings.
+ not a GUI app.
New srpm and spec, fixing the issue of the perl-devel req.
New Package CVS Request
Package Name: perl-Class-Observable
Short Description: Allow other classes and objects to respond to events in yours
Branches: FC-5, FC-6, devel
Thanks for the review, package has been built for FC-5, FC-6 and rawhide.