Red Hat Bugzilla – Bug 232626
Review Request: perl-MD5 - Perl interface to the MD5 Message-Digest Algorithm
Last modified: 2007-11-30 17:11:59 EST
Spec URL: http://home.bawue.de/~ixs/perl-MD5/perl-MD5.spec SRPM URL: http://home.bawue.de/~ixs/perl-MD5/perl-MD5-2.03-1.src.rpm Description: This module (MD5.pm) is just a thin wrapper around the Digest::MD5 module. It is provided so that legacy code that rely on the old interface continue to work with the speed benefit of the new module.
Source URL not working Change it to http://www.cpan.org/modules/by-module/MD5/GAAS/MD5-2.03.tar.gz
This module is deprecated then why you want to include it in package. Instead fo on adding perl-Digest-MD5, I think its not yet in Fedora.
Thanks for the correction of the URL. perl(MD5) has been removed in favour of perl(Digest::MD5) as it is faster. This module however is a wrapper for Digest::MD5 which provdes the perl(MD5) interface. We do have quite some scripts in use which use perl(MD5) and thus do benefit from this module. Stuff like websieve, a web interface for the sieve mailfilter part of the cyrus imap daemon is one of these scrips e.g.
Review: + package builds in mock (development i386). + rpmlint is silent for SRPM and for RPM. + source files match upstream url 0957f02fc30bc2106b3286ba854917bc MD5-2.03.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test 236f38f0dc33163ad5dbb0181e4bf7cL_DL_NONLAZY=1 /usr/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/md5....ok All tests successful. Files=1, Tests=14, 0 wallclock secs ( 0.02 cusr + 0.01 csys = 0.03 CPU) + Provides: perl(MD5) = 2.03 APPROVED.
New Package CVS Request ======================= Package Name: perl-MD5 Short Description: Perl interface to the MD5 Message-Digest Algorithm Owners: andreas@bawue.net Branches: FC-5, FC-6, devel InitialCC: fedora-perl-devel-list@redhat.com
Thx for the review. Package has been built for devel, FC-5 and FC-6. Closing as NEXTRELEASE.