Spec URL: https://smani.fedorapeople.org/review/python-flask-sqlalchemy-light.spec SRPM URL: https://smani.fedorapeople.org/review/python-flask-sqlalchemy-lite-0.1.0-1.src.rpm Description: Adds SQLAlchemy support to Flask application Fedora Account System Username: smani
Cannot find any valid SRPM URL for this ticket. Common causes are: - You didn't specify `SRPM URL: ...` in the ticket description or any of your comments - The URL schema isn't HTTP or HTTPS - The SRPM package linked in your URL doesn't match the package name specified in the ticket summary --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
I'll review it
* You accidentally misnamed spec-file as *light. has to be lite. * pypi_source usage w/o parameter is deprecated ( https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_convenience_macros ).
Ah whoops, thanks! Spec URL: https://smani.fedorapeople.org/review/python-flask-sqlalchemy-lite.spec SRPM URL: https://smani.fedorapeople.org/review/python-flask-sqlalchemy-lite-0.1.0-2.src.rpm %changelog * Sun Nov 17 2024 Sandro Mani <manisandro> - 0.1.0-2 - Specify parameter to pypi_source
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Dist tag is present. ^^^ false positive - Package must not depend on deprecated() packages. Note: python3-sqlalchemy1.3 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ^^^ false positive (picked up automatically) ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package owns all directories that it creates. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package does not contain desktop file (not a GUI application). [-]: No separate development files [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: The package is not a rename of another package. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package does not contain systemd file(s). [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1326 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: No Python eggs. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: I did not test if the package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources weren't verified with gpgverify. [?]: I did not test if the package compiles and builds into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-flask-sqlalchemy-lite-0.1.0-2.noarch.rpm python-flask-sqlalchemy-lite-0.1.0-2.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpxrn5dloc')] checks: 32, packages: 2 2 packages and 0 specfiles checked; 0 errors, 0 warnings, 13 filtered, 0 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 1 packages and 0 specfiles checked; 0 errors, 0 warnings, 7 filtered, 0 badness; has taken 0.1 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/f/flask_sqlalchemy_lite/flask_sqlalchemy_lite-0.1.0.tar.gz : CHECKSUM(SHA256) this package : 953173780a974940e6d0cfde1b1fe7097dae66dd7d18bc728f441847f6c48e09 CHECKSUM(SHA256) upstream package : 953173780a974940e6d0cfde1b1fe7097dae66dd7d18bc728f441847f6c48e09 Requires -------- python3-flask-sqlalchemy-lite (rpmlib, GLIBC filtered): python(abi) python3.13dist(flask) python3.13dist(flask[async]) python3.13dist(sqlalchemy) python3.13dist(sqlalchemy[asyncio]) Provides -------- python3-flask-sqlalchemy-lite: python-flask-sqlalchemy-lite python-flask_sqlalchemy_lite python3-flask-sqlalchemy-lite python3-flask_sqlalchemy_lite python3.13-flask-sqlalchemy-lite python3.13-flask_sqlalchemy_lite python3.13dist(flask-sqlalchemy-lite) python3dist(flask-sqlalchemy-lite) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2326830 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Haskell, Perl, fonts, PHP, C/C++, Java, Ocaml, R, SugarActivity Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH LGTM. This package is ================ === APPROVED === ================
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-flask-sqlalchemy-lite
Thanks a lot for the quick review, let me know if I can review something in exchange!
(In reply to Sandro Mani from comment #7) > Thanks a lot for the quick review, let me know if I can review something in > exchange! Sure. Could you please grab any of these * https://bugzilla.redhat.com/2324138 python-eth-rlp - RLP definitions for common Ethereum objects in Python * https://bugzilla.redhat.com/2324137 python-eth-keyfile - Tools for handling the encrypted keyfile format used to store private keys * https://bugzilla.redhat.com/2324136 python-trie - Library which implements the Ethereum Trie structure