Bug 2326842 - Review Request: python-dnspython - DNS toolkit for python
Summary: Review Request: python-dnspython - DNS toolkit for python
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Peter Lemenkov
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2324539
TreeView+ depends on / blocked
 
Reported: 2024-11-17 17:53 UTC by Benson Muite
Modified: 2024-11-22 14:51 UTC (History)
2 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
lemenkov: fedora-review?


Attachments (Terms of Use)

Description Benson Muite 2024-11-17 17:53:23 UTC
spec: https://download.copr.fedorainfracloud.org/results/fed500/python-dnspython/fedora-rawhide-x86_64/08273489-python-dnspython/python-dnspython.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/python-dnspython/fedora-rawhide-x86_64/08273489-python-dnspython/python-dnspython-2.7.0-1.fc42.src.rpm

description:
dnspython is a DNS toolkit for Python. It supports almost all record types.
It can be used for queries, zone transfers, and dynamic updates. It supports
TSIG-authenticated messages and EDNS0.

dnspython provides both high- and low-level access to DNS. The high-level
classes perform queries for data of a given name, type, and class, and
return an answer set. The low-level classes allow direct manipulation of
DNS zones, messages, names, and records.

dnspython is a utility to work with DNS, /etc/hosts is thus not used. For
simple forward DNS lookups, it's better to use socket.getaddrinfo() or
socket.gethostbyname().

dnspython originated at Nominum where it was developed to facilitate the
testing of DNS software.

fas: fed500

Reproducible: Always

Comment 1 Fedora Review Service 2024-11-17 17:58:08 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8273515
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2326842-python-dnspython/fedora-rawhide-x86_64/08273515-python-dnspython/fedora-review/review.txt

Found issues:

- python3-pytest7 is deprecated, you must not depend on it.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Peter Lemenkov 2024-11-21 15:23:41 UTC
I'll review it

Comment 3 Peter Lemenkov 2024-11-21 17:29:51 UTC
* I've got a Mock failure. Looks like python-aioquic is not very recent (python3-dnspython+doq requires python3.13dist(aioquic) >= 1). Take a look at this.
* Mixed tabs and spaces in spec-file.
* Wrong line-ending in one of the examples (./examples/dot.py).

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed

Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/

^^^ See my comments above.

- Package must not depend on deprecated() packages.
  Note: python3-pytest7 is deprecated, you must not depend on it.
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/deprecating-packages/


^^^ false positive

===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license (ISC).
[x]: Package owns all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[x]: Macros in Summary, %description expandable at SRPM build time.
[-]: Package does not contain desktop file (not a GUI application).
[-]: No need for separate -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: The package is not a rename of another package.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package does not contain systemd file(s).
[x]: Package is not known to require an ExcludeArch tag.
[-]: No extremely large documentation files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[-]: No python eggs must not download any dependencies during the build
     process.
[-]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: I did not test if the package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources weren't verified with gpgverify.
[?]: I did not test if the package compiles and builds into binary rpms
     on all supported architectures. Noarch anyway.
[x]: %check is present and all tests pass. Except for those who were
     skipped.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Spec use %global instead of %define unless justified.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.


Installation errors
-------------------
INFO: mock.py version 5.9 starting (python version = 3.13.0, NVR = mock-5.9-1.fc41), args: /usr/libexec/mock/mock -r fedora-rawhide-x86_64 --no-cleanup-after --no-clean --plugin-option=tmpfs:keep_mounted=True --resultdir=/home/petro/rpmbuild/SPECS/2326842-python-dnspython/results install /home/petro/rpmbuild/SPECS/2326842-python-dnspython/results/python3-dnspython+doh-2.7.0-1.fc42.noarch.rpm /home/petro/rpmbuild/SPECS/2326842-python-dnspython/results/python3-dnspython+trio-2.7.0-1.fc42.noarch.rpm /home/petro/rpmbuild/SPECS/2326842-python-dnspython/results/python3-dnspython+idna-2.7.0-1.fc42.noarch.rpm /home/petro/rpmbuild/SPECS/2326842-python-dnspython/results/python3-dnspython+doq-2.7.0-1.fc42.noarch.rpm /home/petro/rpmbuild/SPECS/2326842-python-dnspython/results/python3-dnspython-2.7.0-1.fc42.noarch.rpm /home/petro/rpmbuild/SPECS/2326842-python-dnspython/results/python3-dnspython+dnssec-2.7.0-1.fc42.noarch.rpm
Start(bootstrap): init plugins
INFO: selinux enabled
Finish(bootstrap): init plugins
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Mock Version: 5.9
INFO: Mock Version: 5.9
Start(bootstrap): chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start(bootstrap): cleaning package manager metadata
Finish(bootstrap): cleaning package manager metadata
INFO: Package manager dnf5 detected and used (fallback)
Finish(bootstrap): chroot init
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
INFO: Package manager dnf5 detected and used (direct choice)
Finish: chroot init
INFO: installing package(s): /builddir/python3-dnspython+doh-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython+trio-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython+idna-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython+doq-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython+dnssec-2.7.0-1.fc42.noarch.rpm
ERROR: Command failed: 
 # /usr/bin/systemd-nspawn -q -M e22a677384854853b542c8e1cb797a49 -D /var/lib/mock/fedora-rawhide-x86_64-bootstrap/root -a --capability=cap_ipc_lock --bind=/tmp/mock-resolv.0qs85fuq:/etc/resolv.conf --console=pipe --setenv=TERM=vt100 --setenv=SHELL=/bin/bash --setenv=HOME=/var/lib/mock/fedora-rawhide-x86_64/root/installation-homedir --setenv=HOSTNAME=mock --setenv=PATH=/usr/bin:/bin:/usr/sbin:/sbin '--setenv=PROMPT_COMMAND=printf "\033]0;<mock-chroot>\007"' '--setenv=PS1=<mock-chroot> \s-\v\$ ' --setenv=LANG=C.UTF-8 --setenv=LC_MESSAGES=C.UTF-8 --resolv-conf=off /usr/bin/dnf5 --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 42 install /builddir/python3-dnspython+doh-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython+trio-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython+idna-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython+doq-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython-2.7.0-1.fc42.noarch.rpm /builddir/python3-dnspython+dnssec-2.7.0-1.fc42.noarch.rpm --setopt=deltarpm=False --setopt=allow_vendor_change=yes --allowerasing --setopt=tsflags=nocontexts



Rpmlint
-------
Checking: python3-dnspython-2.7.0-1.fc42.noarch.rpm
          python-dnspython-2.7.0-1.fc42.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.5.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpdvmhf0d6')]
checks: 32, packages: 2

python3-dnspython.noarch: E: wrong-script-end-of-line-encoding /usr/share/doc/python3-dnspython/examples/dot.py
python-dnspython.src: E: spelling-error ('lookups', '%description -l en_US lookups -> lookup, lockups, hookups')
python-dnspython.src: E: spelling-error ('getaddrinfo', '%description -l en_US getaddrinfo -> overinflated')
python-dnspython.src: E: spelling-error ('gethostbyname', '%description -l en_US gethostbyname ')
python3-dnspython.noarch: E: spelling-error ('lookups', '%description -l en_US lookups -> lookup, lockups, hookups')
python3-dnspython.noarch: E: spelling-error ('getaddrinfo', '%description -l en_US getaddrinfo -> overinflated')
python3-dnspython.noarch: E: spelling-error ('gethostbyname', '%description -l en_US gethostbyname ')

^^^ false positives.

python-dnspython.spec:87: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 87)
 2 packages and 0 specfiles checked; 7 errors, 1 warnings, 7 filtered, 7 badness; has taken 0.9 s 




Source checksums
----------------
https://github.com/rthalley/dnspython/archive/v2.7.0/dnspython-2.7.0.tar.gz :
  CHECKSUM(SHA256) this package     : a18503bcd166c9ecb6b9ed91f38ed03d0d7ca282c4ac57282c9fd6b85726fc4b
  CHECKSUM(SHA256) upstream package : a18503bcd166c9ecb6b9ed91f38ed03d0d7ca282c4ac57282c9fd6b85726fc4b


Requires
--------
python3-dnspython (rpmlib, GLIBC filtered):
    python(abi)



Provides
--------
python3-dnspython:
    python-dnspython
    python3-dnspython
    python3.13-dnspython
    python3.13dist(dnspython)
    python3dist(dnspython)



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2326842
Buildroot used: fedora-rawhide-x86_64
Active plugins: Generic, Python, Shell-api
Disabled plugins: Java, fonts, PHP, Haskell, C/C++, R, SugarActivity, Perl, Ocaml
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comment 4 Benson Muite 2024-11-22 14:51:47 UTC
Thanks. Waiting on:
https://src.fedoraproject.org/rpms/python-aioquic/pull-request/1
to update aioquic


Note You need to log in before you can comment on or make changes to this bug.