Bug 232715 - fix double AIO completion due to invalidate_inode_pages2 failure
fix double AIO completion due to invalidate_inode_pages2 failure
Product: Red Hat Enterprise Linux 5
Classification: Red Hat
Component: kernel (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jeff Moyer
Martin Jenner
Depends On:
  Show dependency treegraph
Reported: 2007-03-16 15:39 EDT by Jeff Moyer
Modified: 2007-11-30 17:07 EST (History)
2 users (show)

See Also:
Fixed In Version: RHBA-2007-0959
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2007-11-07 14:44:34 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
fix double AIO completion due to invalidate_inode_pages2_range failure (5.33 KB, patch)
2007-03-16 16:56 EDT, Jeff Moyer
no flags Details | Diff

  None (edit)
Description Jeff Moyer 2007-03-16 15:39:01 EDT
Description of problem:
Before this patch we had the problem where this invalidation failure would
clobber -EIOCBQUEUED as it made its way from fs/direct-io.c to fs/aio.c.  Both
fs/aio.c and bio completion call aio_complete() and we reference freed memory,
usually oopsing.

This patch addresses this problem by invalidating before the write so that we
can cleanly return -EIO before ->direct_IO() has had a chance to return

Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Run the aio_dio_bugs tests in the autotest test suite.
Actual results:
Kernel panic

Expected results:
No kernel panic

Additional info:
Fix posted to lkml:

Comment 1 Jeff Moyer 2007-03-16 16:56:11 EDT
Created attachment 150279 [details]
fix double AIO completion due to invalidate_inode_pages2_range failure
Comment 2 RHEL Product and Program Management 2007-03-16 17:04:26 EDT
This request was evaluated by Red Hat Product Management for inclusion in a Red
Hat Enterprise Linux maintenance release.  Product Management has requested
further review of this request by Red Hat Engineering, for potential
inclusion in a Red Hat Enterprise Linux Update release for currently deployed
products.  This request is not yet committed for inclusion in an Update
Comment 5 Don Zickus 2007-06-15 20:32:12 EDT
in 2.6.18-27.el5
You can download this test kernel from http://people.redhat.com/dzickus/el5
Comment 8 errata-xmlrpc 2007-11-07 14:44:34 EST
An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on the solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.


Note You need to log in before you can comment on or make changes to this bug.