Bug 2327322 - Missing shell completion (bash)
Summary: Missing shell completion (bash)
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: rust-lsd
Version: 41
Hardware: x86_64
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-11-19 17:06 UTC by Simon Hammes
Modified: 2024-12-13 01:37 UTC (History)
2 users (show)

Fixed In Version: rust-lsd-1.1.5-3.fc41 rust-lsd-1.1.5-3.fc40
Clone Of:
Environment:
Last Closed: 2024-12-13 01:34:27 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description Simon Hammes 2024-11-19 17:06:32 UTC
I recently switched from Debian to Fedora and noticed that the RPM package for `lsd` does not contain the shell completions (I'm using bash).

Is it possible to add them to the package?

Reproducible: Always

Steps to Reproduce:
1. Type `lsd`
2. Press <TAB>
Actual Results:  
bash suggests filenames and directories inside the current directory

Expected Results:  
bash suggests flags and options from `lsd`

Debian seems to vendor these files: https://salsa.debian.org/rust-team/debcargo-conf/-/tree/master/src/lsd/debian

I believe the files are automatically generated during a build: https://github.com/lsd-rs/lsd/blob/c1e7a596861815554916a61a5a4e5fa8866f625a/ci/before_deploy.bash#L38 (maybe this reference is helpful)

Comment 1 Fabio Valentini 2024-11-19 17:10:00 UTC
Indeed, these are generated during the build:
https://github.com/lsd-rs/lsd/blob/master/build.rs#L26-L30

So debian needlessly vendors them :(

I'll add the completions to the Fedora package with the next update, thanks for the report.

Comment 2 Simon Hammes 2024-11-19 17:12:04 UTC
Damn, you are quick :)

Thank you very much!

Comment 3 Fedora Update System 2024-12-04 19:11:13 UTC
FEDORA-2024-612044098c (rust-lsd-1.1.5-3.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-612044098c

Comment 4 Fedora Update System 2024-12-04 19:11:13 UTC
FEDORA-2024-59bee4aa6c (rust-lsd-1.1.5-3.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-59bee4aa6c

Comment 5 Fedora Update System 2024-12-05 01:27:18 UTC
FEDORA-2024-612044098c has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-612044098c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-612044098c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 6 Fedora Update System 2024-12-05 01:38:50 UTC
FEDORA-2024-59bee4aa6c has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-59bee4aa6c`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-59bee4aa6c

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 7 Fedora Update System 2024-12-13 01:34:27 UTC
FEDORA-2024-59bee4aa6c (rust-lsd-1.1.5-3.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 8 Fedora Update System 2024-12-13 01:37:28 UTC
FEDORA-2024-612044098c (rust-lsd-1.1.5-3.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.