Spec URL: https://pemensik.fedorapeople.org/python-magic-wormhole-transit-relay.spec SRPM URL: https://pemensik.fedorapeople.org/python-magic-wormhole-transit-relay-0.4.0-1.fc42.src.rpm Description: This package contains the Magic-Wormhole "Transit Relay", a server that helps clients establish bulk-data transit connections even when both are behind NAT boxes. Each side makes a TCP connection to this server and presents a handshake. Two connections with identical handshakes are glued together, allowing them to pretend they have a direct connection. This server used to be included in the magic-wormhole repository, but was split out into a separate repo to aid deployment and development. Fedora Account System Username: pemensik
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126033850
Copr build: https://copr.fedorainfracloud.org/coprs/build/8282457 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327535-python-magic-wormhole-transit-relay/fedora-rawhide-x86_64/08282457-python-magic-wormhole-transit-relay/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-magic-wormhole-transit-relay Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ - Package does not use a name that already exists. Note: A package with this name already exists. Please check https://src.fedoraproject.org/rpms/python-magic-wormhole-transit-relay See: https://docs.fedoraproject.org/en-US/packaging- guidelines/Naming/#_conflicting_package_names ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License", "*No copyright* Public domain". 38 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python-magic-wormhole-transit- relay/2327535-python-magic-wormhole-transit-relay/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13 [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/lib/python3.13/site- packages/twisted/plugins/__pycache__(python3-daphne, python3-twisted, python3-autobahn, python3-carbon) [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1844 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-magic-wormhole-transit-relay-0.4.0-1.fc42.noarch.rpm python-magic-wormhole-transit-relay-0.4.0-1.fc42.src.rpm =============================================== rpmlint session starts =============================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp5g04b2a7')] checks: 32, packages: 2 python-magic-wormhole-transit-relay.src: E: spelling-error ('repo', '%description -l en_US repo -> rope, rep, reps') python3-magic-wormhole-transit-relay.noarch: E: spelling-error ('repo', '%description -l en_US repo -> rope, rep, reps') ========== 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 9 filtered, 2 badness; has taken 6.8 s ========== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-magic-wormhole-transit-relay.noarch: E: spelling-error ('repo', '%description -l en_US repo -> rope, rep, reps') 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 5 filtered, 1 badness; has taken 1.2 s Source checksums ---------------- https://files.pythonhosted.org/packages/source/m/magic-wormhole-transit-relay/magic-wormhole-transit-relay-0.4.0.tar.gz : CHECKSUM(SHA256) this package : 912d835da21b11266c77111dc9b5e5800263fc0b98f0a179962267df41819e8c CHECKSUM(SHA256) upstream package : 912d835da21b11266c77111dc9b5e5800263fc0b98f0a179962267df41819e8c Requires -------- python3-magic-wormhole-transit-relay (rpmlib, GLIBC filtered): python(abi) python3.13dist(autobahn) python3.13dist(twisted) Provides -------- python3-magic-wormhole-transit-relay: python-magic-wormhole-transit-relay python3-magic-wormhole-transit-relay python3.13-magic-wormhole-transit-relay python3.13dist(magic-wormhole-transit-relay) python3dist(magic-wormhole-transit-relay) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2327535 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: Perl, Java, fonts, Ocaml, Haskell, PHP, SugarActivity, R, C/C++ Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Would be good to use the newer python packaging guidelines, but not a blocker. b) Warning during build: /usr/lib/python3.13/site-packages/setuptools/_distutils/cmd.py:66: SetuptoolsDeprecationWarning: setup.py install is deprecated. Not blocker, but perhaps make upstream aware to transition c) Tests are run using tox not pytest: https://github.com/magic-wormhole/magic-wormhole-transit-relay/blob/master/.github/workflows/test.yml#L29 Not a blocker, but would be good to update.
This is attempt to revive dead package, which needs a new review. I have marked it is such, according to review instructions. My fast attempt to use %tox has failed with: + PYTHONPATH=/builddir/build/BUILD/python-magic-wormhole-transit-relay-0.4.0-build/BUILDROOT/usr/lib64/python3.13/site-packages:/builddir/build/BUILD/python-magic-wormhole-transit-relay-0.4.0-build/BUILDROOT/usr/lib/python3.13/site-packages + PYTHONDONTWRITEBYTECODE=1 + PYTEST_XDIST_AUTO_NUM_WORKERS=4 + HOSTNAME=rpmbuild + /usr/bin/python3 -m tox --current-env -q --recreate -e py313 usage: tox [-h] [--colored {yes,no}] [-v | -q] [--exit-and-dump-after seconds] [-c file] [--workdir dir] [--root dir] [--runner {virtualenv}] [--version] [--no-provision [REQ_JSON]] [--no-recreate-provision] [-r] [-x OVERRIDE] {run,r,run-parallel,p,depends,de,list,l,devenv,d,config,c,quickstart,q,exec,e,legacy,le} ... tox: error: unrecognized arguments: --current-env hint: if you tried to pass arguments to a command use -- to separate them from tox ones error: Bad exit status from /var/tmp/rpm-tmp.dDtLVM (%check) Bad exit status from /var/tmp/rpm-tmp.dDtLVM (%check) %pytest has worked fine for other dependencies of magic-wormhole. But gets stuck in this, therefore I have disabled the test. I am not depending on pytest < 0.8 anywhere. Unless there is any blocker, can I get the review passed? :) Hints to improve noted, but first I would like to get python-magic-wormhole package into working state.
Checking on tests, give me a day https://copr.fedorainfracloud.org/coprs/build/8290012
Consider trying: https://packages.fedoraproject.org/pkgs/pyp2spec/pyp2spec/ https://github.com/befeleme/pyp2spec
Created attachment 2059037 [details] Suggested spec file Way to run tests