Spec URL: https://alebastr.fedorapeople.org/review/rust-derive-where.spec SRPM URL: https://alebastr.fedorapeople.org/review/rust-derive-where-1.2.7-1.fc41.src.rpm Description: Deriving with custom trait bounds. Fedora Account System Username: alebastr
This package built on koji: https://koji.fedoraproject.org/koji/taskinfo?taskID=126074467
Copr build: https://copr.fedorainfracloud.org/coprs/build/8295432 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2327746-rust-derive-where/fedora-rawhide-x86_64/08295432-rust-derive-where/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Can you please submit the fix for the executable files to upstream? The package itself looks good to me, though. === Package was generated with rust2rpm, simplifying the review. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license files are included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
(In reply to Fabio Valentini from comment #3) > Can you please submit the fix for the executable files to upstream? > The package itself looks good to me, though. Thanks a lot for the review! Submitted https://github.com/ModProg/derive-where/pull/102
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-derive-where
FEDORA-2024-46cbbcd9f4 (rust-derive-where-1.2.7-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-46cbbcd9f4
FEDORA-2024-46cbbcd9f4 (rust-derive-where-1.2.7-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.