Description of problem: Please fix lazy written PHP scripts in gettext-tools/tests/. There *always* should be "<?php" used in favor over "<?". Version-Release number of selected component (if applicable): gettext-0.16.1-7 How reproducible: Possible problems are caused when "short_open_tag = Off" is set in /etc/php.ini Actual results: Lazy written PHP scripts in gettext-tools/tests/ Expected results: Apply the following fixes or better. Hopefully I forgot no file to patch... --- ./gettext-tools/tests/xgettext-php-1 2006-11-27 18:02:11.000000000 +0100 +++ ./gettext-tools/tests/xgettext-php-1.rsc 2007-03-18 16:03:40.000000000 +0100 @@ -7,7 +7,7 @@ tmpfiles="$tmpfiles xg-ph-1.php" cat <<EOF > xg-ph-1.php -<? +<?php // This comment will not be extracted. echo _("help"); // TRANSLATORS: This is an extracted comment. --- ./gettext-tools/tests/xgettext-php-2 2006-05-15 14:23:49.000000000 +0200 +++ ./gettext-tools/tests/xgettext-php-2.rsc 2007-03-18 16:03:52.000000000 +0100 @@ -7,7 +7,7 @@ tmpfiles="$tmpfiles xg-ph-2.php" cat <<EOF > xg-ph-2.php -<? +<?php echo _("Egyptians"); echo <<<EOTMARKER Ramses --- ./gettext-tools/tests/lang-php 2006-11-27 18:02:08.000000000 +0100 +++ ./gettext-tools/tests/lang-php.rsc 2007-03-18 16:04:42.000000000 +0100 @@ -9,7 +9,7 @@ tmpfiles="$tmpfiles prog.php" cat <<\EOF > prog.php -<? +<?php setlocale (LC_ALL, ""); textdomain ("prog"); bindtextdomain ("prog", "."); --- ./gettext-tools/tests/prog.php 2007-03-18 15:41:56.000000000 +0100 +++ ./gettext-tools/tests/prog.php.rsc 2007-03-18 16:04:53.000000000 +0100 @@ -1,4 +1,4 @@ -<? +<?php setlocale (LC_ALL, ""); textdomain ("prog"); bindtextdomain ("prog", ".");
Patch sent upstream to bug-gnu-utils.
prog.php is a generated file I think.
Thanks, patch added in package cvs.
Thank you. Yeah, it's possible that I took a generated file, too. I did a make and after a make clean I worked out the replacements. But unfortunately I noticed the following error a few minutes ago when doing a local rebuild: SKIP: lang-perl-2 2c2 < EUR remplace FF. --- > EUR remplace FF.16 FAIL: lang-php Any ideas?
I just tried and it fails for me both with and without the patch.
Yepp, patch doesn't change anything, but it fixes the lame upstream coding behaviour ;-)
Oh, the Gentoo guys have the same problem: http://bugs.gentoo.org/ show_bug.cgi?id=159640
BTW upstream only applied the patch to lang-php saying the other test php code is not actually executed.
Ping?
Should be fixed in gettext-0.16.1-8.fc7.