Created attachment 2059518 [details] Configuration file for rust2rpm Spec URL: https://music.fedorapeople.org/rust-icu_collections.spec SRPM URL: https://music.fedorapeople.org/rust-icu_collections-1.5.0-1.fc41.src.rpm Description: Collection of API for use in ICU libraries. Fedora Account System Username: music
Copr build: https://copr.fedorainfracloud.org/coprs/build/8306513 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328487-rust-icu_collections/fedora-rawhide-x86_64/08306513-rust-icu_collections/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8306514 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328487-rust-icu_collections/fedora-rawhide-x86_64/08306514-rust-icu_collections/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package was generated with rust2rpm, simplifying the review. Both askalono and licensecheck identify the license as Unicode-DFS-2016, but it is clearly the text for the Unicode-3.0 license (as specified in crate metadata). There are quite a number of packages that start to depend on postcard, it might make sense to package it eventually. ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide 🫤 test suite is run and all unit tests pass (some tests skipped with justification) ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version (*NOT* pre-release) filter: alpha;beta;rc;pre distro: Fedora Package: rust-$crate - add @rust-sig with "commit" access as package co-maintainer (should happen automatically) - set bugzilla assignee overrides to @rust-sig (optional) - track package in koschei for all built branches (should happen automatically once rust-sig is co-maintainer)
Thank you for the review. (In reply to Fabio Valentini from comment #3) > There are quite a number of packages that start to depend on postcard, it > might make sense to package it eventually. I thought about it, just to avoid having to carry so many patches, but I gave it a quick attempt and it seemed “annoying.” While postcard seems actively maintained, it requires the cobs crate by the same author, which has a few languishing issues and PR’s (https://github.com/jamesmunns/cobs.rs). Then, depending on whether one wants to try to support all the features, one might be packaging postcard-derive, defmt, and/or embedded-io crates. There are also co-developed postcard-schema and postcard-dyn crates that may or may not get pulled in. Looking at https://crates.io/crates/postcard/reverse_dependencies, unless someone tries again on wasmtime in Fedora, postcard would only be packaged as a common but minor dev-dependency for the icu4x stack, supporting examples and the occasional extra integration test. Having postcard packaged *would* save a lot of patching, and I’m not opposed to the idea in principle, but I’m not convinced it’s really worth dealing with the whole postcard stack if nothing is going to use it “in real life.”
https://release-monitoring.org/project/375846/
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-icu_collections
FEDORA-2024-4bfcabfe6f (rust-icu_collections-1.5.0-1.fc42) has been submitted as an update to Fedora 42. https://bodhi.fedoraproject.org/updates/FEDORA-2024-4bfcabfe6f
FEDORA-2024-4bfcabfe6f (rust-icu_collections-1.5.0-1.fc42) has been pushed to the Fedora 42 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-6e97b9288a (rust-icu_collections-1.5.0-1.fc41 and rust-writeable-0.5.5-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e97b9288a
FEDORA-2024-b6caf658a2 (rust-icu_collections-1.5.0-1.fc40 and rust-writeable-0.5.5-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b6caf658a2
FEDORA-2024-6e97b9288a has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6e97b9288a \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6e97b9288a See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b6caf658a2 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b6caf658a2 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b6caf658a2 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-d4da7c69d0 (rust-icu_collections-1.5.0-1.el9 and rust-writeable-0.5.5-1.el9) has been submitted as an update to Fedora EPEL 9. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d4da7c69d0
FEDORA-EPEL-2024-d2640ac5c0 (rust-displaydoc-0.2.5-3.el10_0, rust-icu_collections-1.5.0-1.el10_0, and 1 more) has been submitted as an update to Fedora EPEL 10.0. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d2640ac5c0
FEDORA-EPEL-2024-d4da7c69d0 has been pushed to the Fedora EPEL 9 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d4da7c69d0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-EPEL-2024-d2640ac5c0 has been pushed to the Fedora EPEL 10.0 testing repository. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2024-d2640ac5c0 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b6caf658a2 (rust-icu_collections-1.5.0-1.fc40 and rust-writeable-0.5.5-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-6e97b9288a (rust-icu_collections-1.5.0-1.fc41 and rust-writeable-0.5.5-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-d4da7c69d0 (rust-icu_collections-1.5.0-1.el9 and rust-writeable-0.5.5-1.el9) has been pushed to the Fedora EPEL 9 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-EPEL-2024-d2640ac5c0 (rust-displaydoc-0.2.5-3.el10_0, rust-icu_collections-1.5.0-1.el10_0, and 1 more) has been pushed to the Fedora EPEL 10.0 stable repository. If problem still persists, please make note of it in this bug report.