spec: https://download.copr.fedorainfracloud.org/results/fed500/python-cymruwhois/fedora-rawhide-x86_64/08306604-python-cymruwhois/python-cymruwhois.spec srpm: https://download.copr.fedorainfracloud.org/results/fed500/python-cymruwhois/fedora-rawhide-x86_64/08306604-python-cymruwhois/python-cymruwhois-1.6-1.fc42.src.rpm description: Perform lookups by ip address and return ASN, Country Code, and Netblock Owner:: >>> import socket >>> ip = socket.gethostbyname("www.google.com") >>> from cymruwhois import Client >>> c=Client() >>> r=c.lookup(ip) >>> print r.asn 15169 >>> print r.owner GOOGLE - Google Inc. fas: fed500 Reproducible: Always
Copr build: https://copr.fedorainfracloud.org/coprs/build/8306606 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328488-python-cymruwhois/fedora-rawhide-x86_64/08306606-python-cymruwhois/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License". 12 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/python-cymruwhois/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages/__pycache__, /usr/lib/python3.13/site-packages, /usr/lib/python3.13 [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: python3-cymruwhois (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [!]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-cymruwhois-1.6-1.fc42.noarch.rpm python-cymruwhois-1.6-1.fc42.src.rpm =============================================================================== rpmlint session starts ============================================================================== rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpijjndh75')] checks: 32, packages: 2 python-cymruwhois.src: E: spelling-error ('lookups', '%description -l en_US lookups -> lookup, lockups, hookups') python-cymruwhois.src: E: spelling-error ('ip', '%description -l en_US ip -> IP, pi, up') python-cymruwhois.src: E: spelling-error ('gethostbyname', '%description -l en_US gethostbyname ') python-cymruwhois.src: E: spelling-error ('www', '%description -l en_US www -> WWW, wow') python-cymruwhois.src: E: spelling-error ('asn', '%description -l en_US asn -> ans, as, an') python3-cymruwhois.noarch: E: spelling-error ('lookups', '%description -l en_US lookups -> lookup, lockups, hookups') python3-cymruwhois.noarch: E: spelling-error ('ip', '%description -l en_US ip -> IP, pi, up') python3-cymruwhois.noarch: E: spelling-error ('gethostbyname', '%description -l en_US gethostbyname ') python3-cymruwhois.noarch: E: spelling-error ('www', '%description -l en_US www -> WWW, wow') python3-cymruwhois.noarch: E: spelling-error ('asn', '%description -l en_US asn -> ans, as, an') python3-cymruwhois.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/cymruwhois.py 644 /usr/bin/env python python-cymruwhois.spec:38: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 38) ========================================= 2 packages and 0 specfiles checked; 11 errors, 1 warnings, 7 filtered, 11 badness; has taken 0.2 s ======================================== Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-cymruwhois.noarch: E: spelling-error ('lookups', '%description -l en_US lookups -> lookup, lockups, hookups') python3-cymruwhois.noarch: E: spelling-error ('ip', '%description -l en_US ip -> IP, pi, up') python3-cymruwhois.noarch: E: spelling-error ('gethostbyname', '%description -l en_US gethostbyname ') python3-cymruwhois.noarch: E: spelling-error ('www', '%description -l en_US www -> WWW, wow') python3-cymruwhois.noarch: E: spelling-error ('asn', '%description -l en_US asn -> ans, as, an') python3-cymruwhois.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/cymruwhois.py 644 /usr/bin/env python 1 packages and 0 specfiles checked; 6 errors, 0 warnings, 3 filtered, 6 badness; has taken 0.1 s Source checksums ---------------- https://github.com/JustinAzoff/python-cymruwhois/archive/1.6/python-cymruwhois-1.6.tar.gz : CHECKSUM(SHA256) this package : 357bd4beaab4c857062984cfd6b85606e3ff6b39e6e5420f428961ab2a9f2434 CHECKSUM(SHA256) upstream package : 357bd4beaab4c857062984cfd6b85606e3ff6b39e6e5420f428961ab2a9f2434 Requires -------- python3-cymruwhois (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python3-cymruwhois: python-cymruwhois python3-cymruwhois python3.13-cymruwhois python3.13dist(cymruwhois) python3dist(cymruwhois) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n python-cymruwhois-1.6-1.fc42.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Python, Generic Disabled plugins: SugarActivity, C/C++, Java, PHP, R, fonts, Ocaml, Perl, Haskell Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ If possible, patch this out? [!]: Packages should try to preserve timestamps of original installed files. install command should use -p. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: This is a note to make sure you don't check in the interpreted spec and use the source instead. Resolve these findings: python3-cymruwhois.noarch: E: non-executable-script /usr/lib/python3.13/site-packages/cymruwhois.py 644 /usr/bin/env python python-cymruwhois.spec:38: W: mixed-use-of-spaces-and-tabs (spaces: line 11, tab: line 38)
Thanks. pytest7 is a false positive. Updated the rest. spec: https://fed500.fedorapeople.org/python-cymruwhois.spec srpm: https://fed500.fedorapeople.org/python-cymruwhois-1.6-1.fc42.src.rpm
Created attachment 2061293 [details] The .spec file difference from Copr build 8306606 to 8343103
Copr build: https://copr.fedorainfracloud.org/coprs/build/8343103 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328488-python-cymruwhois/fedora-rawhide-x86_64/08343103-python-cymruwhois/fedora-review/review.txt Found issues: - python3-pytest7 is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package must not depend on deprecated() packages. Note: python3-pytest7 is deprecated, you must not depend on it. See: https://docs.fedoraproject.org/en-US/packaging- guidelines/deprecating-packages/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "MIT License", "Unknown or generated", "*No copyright* MIT License". 12 files have unknown license. Detailed output of licensecheck in /home/jon/Reviews/python-cymruwhois/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13/site- packages, /usr/lib/python3.13, /usr/lib/python3.13/site- packages/__pycache__ [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: python3-cymruwhois (description) [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). Rpmlint ------- Checking: python3-cymruwhois-1.6-1.fc42.noarch.rpm python-cymruwhois-1.6-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpdfi1ptxw')] checks: 32, packages: 2 python-cymruwhois.src: E: spelling-error ('lookups', '%description -l en_US lookups -> lookup, lockups, hookups') python-cymruwhois.src: E: spelling-error ('ip', '%description -l en_US ip -> IP, pi, up') python-cymruwhois.src: E: spelling-error ('gethostbyname', '%description -l en_US gethostbyname ') python-cymruwhois.src: E: spelling-error ('www', '%description -l en_US www -> WWW, wow') python-cymruwhois.src: E: spelling-error ('asn', '%description -l en_US asn -> ans, as, an') python3-cymruwhois.noarch: E: spelling-error ('lookups', '%description -l en_US lookups -> lookup, lockups, hookups') python3-cymruwhois.noarch: E: spelling-error ('ip', '%description -l en_US ip -> IP, pi, up') python3-cymruwhois.noarch: E: spelling-error ('gethostbyname', '%description -l en_US gethostbyname ') python3-cymruwhois.noarch: E: spelling-error ('www', '%description -l en_US www -> WWW, wow') python3-cymruwhois.noarch: E: spelling-error ('asn', '%description -l en_US asn -> ans, as, an') 2 packages and 0 specfiles checked; 10 errors, 0 warnings, 7 filtered, 10 badness; has taken 0.2 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-cymruwhois.noarch: E: spelling-error ('lookups', '%description -l en_US lookups -> lookup, lockups, hookups') python3-cymruwhois.noarch: E: spelling-error ('ip', '%description -l en_US ip -> IP, pi, up') python3-cymruwhois.noarch: E: spelling-error ('gethostbyname', '%description -l en_US gethostbyname ') python3-cymruwhois.noarch: E: spelling-error ('www', '%description -l en_US www -> WWW, wow') python3-cymruwhois.noarch: E: spelling-error ('asn', '%description -l en_US asn -> ans, as, an') 1 packages and 0 specfiles checked; 5 errors, 0 warnings, 3 filtered, 5 badness; has taken 0.1 s Source checksums ---------------- https://github.com/JustinAzoff/python-cymruwhois/archive/1.6/python-cymruwhois-1.6.tar.gz : CHECKSUM(SHA256) this package : 357bd4beaab4c857062984cfd6b85606e3ff6b39e6e5420f428961ab2a9f2434 CHECKSUM(SHA256) upstream package : 357bd4beaab4c857062984cfd6b85606e3ff6b39e6e5420f428961ab2a9f2434 Requires -------- python3-cymruwhois (rpmlib, GLIBC filtered): /usr/bin/python3 python(abi) Provides -------- python3-cymruwhois: python-cymruwhois python3-cymruwhois python3.13-cymruwhois python3.13dist(cymruwhois) python3dist(cymruwhois) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -r -n python-cymruwhois-1.6-1.fc42.src.rpm Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Shell-api, Generic Disabled plugins: Java, Perl, SugarActivity, Ocaml, Haskell, fonts, C/C++, R, PHP Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
[!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define autorelease(e:s:pb:n) %{?-p:0.}%{lua: Be sure not to check in the expanded spec and check in the source. The linked spec looks good. Just remove the comment "# Fill in the actual package summary to submit package to Fedora". APPROVED
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-cymruwhois
Thanks for the review. Removed the comment.
FEDORA-2024-b8827603ab (python-cymruwhois-1.6-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-b8827603ab
FEDORA-2024-f22230fa49 (python-cymruwhois-1.6-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-f22230fa49
FEDORA-2024-f22230fa49 has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-f22230fa49 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-f22230fa49 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b8827603ab has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-b8827603ab \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-b8827603ab See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-b8827603ab (python-cymruwhois-1.6-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-f22230fa49 (python-cymruwhois-1.6-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.