Bug 2328545 - Review Request: golang-github-gin-contrib-cors - Official CORS gin's middleware
Summary: Review Request: golang-github-gin-contrib-cors - Official CORS gin's middleware
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2318425
TreeView+ depends on / blocked
 
Reported: 2024-11-24 15:42 UTC by Tom.Rix
Modified: 2024-12-24 13:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-24 13:29:30 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Description Tom.Rix 2024-11-24 15:42:07 UTC
Spec URL: https://trix.fedorapeople.org/golang-github-gin-contrib-cors.spec
SRPM URL: https://trix.fedorapeople.org/golang-github-gin-contrib-cors-1.7.2-1.fc42.src.rpm

This package is a build requires for ollama

Reproducible: Always

Comment 1 Fedora Review Service 2024-11-24 15:46:32 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8308504
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328545-golang-github-gin-contrib-cors/fedora-rawhide-x86_64/08308504-golang-github-gin-contrib-cors/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/golang-github-gin-contrib-cors
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Mikel Olasagasti Uranga 2024-11-25 08:52:47 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 3 Tom.Rix 2024-11-25 13:31:37 UTC
repo already exists, how do we reenable it ?
https://pagure.io/releng/fedora-scm-requests/issue/70473

Comment 4 Mikel Olasagasti Uranga 2024-11-25 21:57:19 UTC
"Claiming Ownership of a Retired Package" procedure needs to be followed: https://docs.fedoraproject.org/en-US/package-maintainers/Package_Retirement_Process/#claiming

Comment 5 Tom.Rix 2024-11-26 12:02:57 UTC
Thanks, I have opened.
https://pagure.io/releng/issue/12476


Note You need to log in before you can comment on or make changes to this bug.