Bug 2328547 - Review Request: golang-github-pdevine-tensor - Package tensor provides efficient and generic n-dimensional arrays in Go
Summary: Review Request: golang-github-pdevine-tensor - Package tensor provides effic...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Mikel Olasagasti Uranga
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 2318425
TreeView+ depends on / blocked
 
Reported: 2024-11-24 16:18 UTC by Tom.Rix
Modified: 2024-12-24 13:28 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-24 13:28:56 UTC
Type: ---
Embargoed:
mikel: fedora-review+


Attachments (Terms of Use)

Comment 1 Tom.Rix 2024-11-24 16:21:23 UTC
My local fedora-review reports

golang-github-pdevine-tensor-devel.noarch: E: zero-length /usr/share/gocode/src/github.com/pdevine/tensor/internal/execution/empty.s

From the name of the file 'empty.s', I am assuming this is intentional and does not need to be corrected.

Comment 2 Fedora Review Service 2024-11-24 16:22:47 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8308563
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328547-golang-github-pdevine-tensor/fedora-rawhide-x86_64/08308563-golang-github-pdevine-tensor/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Mikel Olasagasti Uranga 2024-11-25 08:57:34 UTC
Golang Package Review
==============

This package was generated using go2rpm, which simplifies the review.

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated


- [x] The latest version is packaged or packaging an earlier version is justified.
- [x] The License tag reflects the package contents and uses the correct identifiers.
- [x] The package builds successfully in mock.
- [x] Package is installable (checked by fedora-review).
- [x] There are no relevant rpmlint errors.
- [x] The package runs tests in %check.
- [x] `%goipath` is set correctly.
- [-] The package's binaries don't conflict with binaries already in the distribution. (Some Go projects include utility binaries with very generic names)
- [-] There are no `%{_bindir}/*` wildcards in %files. (go2rpm includes these by default)
- [x] The package does not use `%gometa -f` if it has dependents that still build for %ix86.
- [x] The package complies with the Golang and general Packaging Guidelines.

Package approved! On import, don't forget to do the following:

- [ ] Add the package to release-monitoring.org
- [ ] Give go-sig privileges (at least commit) on the package
- [ ] Close the review bug by referencing its ID in the rpm changelog and the Bodhi ticket.
- [ ] Consider configuring Packit service to help with maintenance

Thanks!

Comment 4 Fedora Admin user for bugzilla script actions 2024-11-25 12:38:34 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-pdevine-tensor


Note You need to log in before you can comment on or make changes to this bug.