Bug 2328628 (rust-aes-kw) - Review Request: rust-aes-kw - NIST 800-38F AES Key Wrap (KW) and Key Wrap with Padding (KWP) modes
Summary: Review Request: rust-aes-kw - NIST 800-38F AES Key Wrap (KW) and Key Wrap wi...
Keywords:
Status: CLOSED ERRATA
Alias: rust-aes-kw
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/aes-kw
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-11-25 08:13 UTC by Marc-Andre Lureau
Modified: 2025-01-30 15:39 UTC (History)
2 users (show)

Fixed In Version: rust-aes-kw-0.2.1-1.fc42
Clone Of:
Environment:
Last Closed: 2025-01-27 07:04:44 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Marc-Andre Lureau 2024-11-25 08:13:51 UTC
Spec URL: https://github.com/elmarco/ironrdp-fedora/blob/master/rust-aes-kw/rust-aes-kw.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08309810/rust-aes-kw-0.2.1-1.src.rpm
Description:  NIST 800-38F AES Key Wrap (KW) and Key Wrap with Padding (KWP) modes 
Fedora Account System Username: elmarco

Comment 1 Fedora Review Service 2024-11-25 08:18:12 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8309819
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328628-rust-aes-kw/fedora-rawhide-x86_64/08309819-rust-aes-kw/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-01-21 16:48:40 UTC
The Spec URL is a GitHub HTML page, and the SRPM link looks expired. Can you re-upload somewhere that isn't set to garbage collect? :)

Comment 3 Marc-Andre Lureau 2025-01-21 19:08:56 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-aes-kw/rust-aes-kw.spec
SRPM URL: https://elmarco.fedorapeople.org/rust-aes-kw-0.2.1-1.src.rpm
Description:  NIST 800-38F AES Key Wrap (KW) and Key Wrap with Padding (KWP) modes 
Fedora Account System Username: elmarco

Comment 4 Fedora Review Service 2025-01-22 02:22:31 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8558133
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2328628-rust-aes-kw/fedora-rawhide-x86_64/08558133-rust-aes-kw/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2025-01-26 21:01:24 UTC
Looks good to me, thanks!

===

Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
✅ test suite is run and all unit tests pass
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- add @rust-sig with "commit" access as package co-maintainer
  (should happen automatically)

- set bugzilla assignee overrides to @rust-sig (optional)

- track package in koschei for all built branches
  (should happen automatically once rust-sig is co-maintainer)

Comment 6 Fedora Admin user for bugzilla script actions 2025-01-27 06:50:50 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-aes-kw

Comment 7 Fedora Update System 2025-01-27 07:00:39 UTC
FEDORA-2025-64ff9205f2 (rust-aes-kw-0.2.1-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-64ff9205f2

Comment 8 Marc-Andre Lureau 2025-01-27 07:04:44 UTC
done, thanks

Comment 9 Fedora Update System 2025-01-27 07:05:20 UTC
FEDORA-2025-64ff9205f2 (rust-aes-kw-0.2.1-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.