Bug 2329168 - Review Request: goocanvas - A canvas widget for GTK+ that uses cairo for drawing
Summary: Review Request: goocanvas - A canvas widget for GTK+ that uses cairo for drawing
Keywords:
Status: CLOSED NEXTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Nobody's working on this, feel free to take it
QA Contact: Fedora Extras Quality Assurance
URL: https://wiki.gnome.org/Projects/GooCa...
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-11-27 15:51 UTC by MartinKG
Modified: 2024-12-04 12:45 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-04 12:45:20 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)
The .spec file difference from Copr build 8319288 to 8321543 (1.31 KB, patch)
2024-11-28 07:54 UTC, Fedora Review Service
no flags Details | Diff

Description MartinKG 2024-11-27 15:51:21 UTC
Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/goocanvas.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/goocanvas-1.0.0-27.fc41.src.rpm

Description: GooCanvas is a new canvas widget for GTK+ that uses the cairo 2D library for drawing. It has a model/view split, and uses interfaces for canvas items and views, so you can easily turn any application object into canvas items.

Fedora Account System Username: martinkg

Comment 1 Fedora Review Service 2024-11-27 16:01:49 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8319288
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329168-goocanvas/fedora-rawhide-x86_64/08319288-goocanvas/fedora-review/review.txt

Found issues:

- License file COPYING is not marked as %license
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text
- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/goocanvas
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 solomoncyj 2024-11-28 01:00:08 UTC
use %make_build

Comment 3 MartinKG 2024-11-28 07:45:02 UTC
package update

Spec URL: https://martinkg.fedorapeople.org/Review/SPECS/goocanvas.spec
SRPM URL: https://martinkg.fedorapeople.org/Review/SRPMS/goocanvas-1.0.0-27.fc41.src.rpm

%changelog
* Wed Nov 27 2024 Martin Gansser <martinkg> - 1.0.0-27
- Add goocanvas.patch to fix bug (#2327765)
- Migrate to SPDX license
- Use macros in build and install section

Comment 4 Fedora Review Service 2024-11-28 07:54:21 UTC
Created attachment 2060198 [details]
The .spec file difference from Copr build 8319288 to 8321543

Comment 5 Fedora Review Service 2024-11-28 07:54:23 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8321543
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329168-goocanvas/fedora-rawhide-x86_64/08321543-goocanvas/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/goocanvas
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Elliott Sales de Andrade 2024-11-29 10:01:08 UTC
Can we remove "new" from the summary and description? The project is almost 20 years old at this point.

Comment 7 MartinKG 2024-12-04 12:45:20 UTC
successfully build for rawhide.


Note You need to log in before you can comment on or make changes to this bug.