Bug 2329210 (rust-ironrdp-tokio) - Review Request: rust-ironrdp-tokio - IronRDP traits implementation above Tokio’s traits
Summary: Review Request: rust-ironrdp-tokio - IronRDP traits implementation above Toki...
Keywords:
Status: CLOSED ERRATA
Alias: rust-ironrdp-tokio
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Fabio Valentini
QA Contact: Fedora Extras Quality Assurance
URL: https://crates.io/crates/ironrdp-tokio
Whiteboard:
Depends On: rust-ironrdp-async
Blocks: rust-ironrdp-server
TreeView+ depends on / blocked
 
Reported: 2024-11-27 19:30 UTC by Marc-Andre Lureau
Modified: 2025-03-16 07:23 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-16 07:23:57 UTC
Type: ---
Embargoed:
decathorpe: fedora-review+


Attachments (Terms of Use)

Description Marc-Andre Lureau 2024-11-27 19:30:29 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-ironrdp-tokio/rust-ironrdp-tokio.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08319766/rust-ironrdp-tokio-0.1.0-1.src.rpm
Description: IronRDP traits implementation above Tokio’s traits
Fedora Account System Username: elmarco

Comment 1 Fedora Review Service 2024-11-27 19:32:51 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8319768
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329210-rust-ironrdp-tokio/fedora-rawhide-x86_64/08319768-rust-ironrdp-tokio/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Fabio Valentini 2025-03-14 17:06:07 UTC
The SRPM URL gives me an HTTP 404 error, can you re-upload please?

Comment 3 Marc-Andre Lureau 2025-03-15 05:56:14 UTC
Spec URL: https://raw.githubusercontent.com/elmarco/ironrdp-fedora/refs/heads/master/rust-ironrdp-tokio/rust-ironrdp-tokio.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/elmarco/qemu-rdp/srpm-builds/08770164/rust-ironrdp-tokio-0.3.0-1.src.rpm
Description: IronRDP traits implementation above Tokio’s traits
Fedora Account System Username: elmarco

Comment 4 Fedora Review Service 2025-03-15 06:03:39 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8770170
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329210-rust-ironrdp-tokio/fedora-rawhide-x86_64/08770170-rust-ironrdp-tokio/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 5 Fabio Valentini 2025-03-15 13:35:20 UTC
Package was generated with rust2rpm, simplifying the review.

✅ package contains only permissible content
✅ package builds and installs without errors on rawhide
🫤 test suite is run and all unit tests pass (there are zero tests)
✅ latest version of the crate is packaged
✅ license matches upstream specification and is acceptable for Fedora
✅ license files are included with %license in %files
✅ package complies with Rust Packaging Guidelines

Package APPROVED.

===

Recommended post-import rust-sig tasks:

- set up package on release-monitoring.org:
  project: $crate
  homepage: https://crates.io/crates/$crate
  backend: crates.io
  version scheme: semantic
  version filter (*NOT* pre-release filter): alpha;beta;rc;pre
  distro: Fedora
  Package: rust-$crate

- set bugzilla assignee overrides to @rust-sig (optional)

Comment 6 Fedora Admin user for bugzilla script actions 2025-03-16 07:05:52 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-ironrdp-tokio

Comment 7 Fedora Update System 2025-03-16 07:21:30 UTC
FEDORA-2025-72579f9c45 (rust-ironrdp-tokio-0.3.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-72579f9c45

Comment 8 Fedora Update System 2025-03-16 07:23:57 UTC
FEDORA-2025-72579f9c45 (rust-ironrdp-tokio-0.3.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.