Spec URL: https://passt.top/static/rust-neli.spec SRPM URL: https://passt.top/static/rust-neli-0.6.4-1.fc41.src.rpm Description: Type safe netlink library written in Rust Fedora Account System Username: sbrivio
Copr build: https://copr.fedorainfracloud.org/coprs/build/8324350 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329412-rust-neli/fedora-rawhide-x86_64/08324350-rust-neli/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Blocked by https://github.com/jbaublitz/neli/pull/260, then I'll upload a new version.
(In reply to Stefano Brivio from comment #2) > Blocked by https://github.com/jbaublitz/neli/pull/260, then I'll upload a > new version. Well, I can't wait forever. Added a downstream patch for it, for the moment. Spec URL: https://passt.top/static/rust-neli.spec SRPM URL: https://passt.top/static/rust-neli-0.7.0~rc3-1.fc42.src.rpm Description: Type safe netlink library written in Rust Fedora Account System Username: sbrivio
Copr build: https://copr.fedorainfracloud.org/coprs/build/8594585 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329412-rust-neli/fedora-rawhide-x86_64/08594585-rust-neli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Looks mostly good to me! Can you use "rust2rpm -p" for patching Cargo.toml instead of making the patch manually? Using "rust2rpm -p" is the only supported way to patch Cargo.toml, since its contents need to be known *prior* to generating the spec file.
(In reply to Fabio Valentini from comment #5) > Looks mostly good to me! > > Can you use "rust2rpm -p" for patching Cargo.toml instead of making the > patch manually? Hah, magic, I didn't know about that. > Using "rust2rpm -p" is the only supported way to patch Cargo.toml, since its > contents need to be known *prior* to generating the spec file. Sure, makes sense. Spec URL: https://passt.top/static/rust-neli.spec SRPM URL: https://passt.top/static/rust-neli-0.7.0~rc3-1.fc42.src.rpm
Let's try again... [fedora-review-service-build] Spec URL: https://passt.top/static/rust-neli.spec SRPM URL: https://passt.top/static/rust-neli-0.7.0~rc3-1.fc42.src.rpm Description: Type safe netlink library written in Rust Fedora Account System Username: sbrivio
Created attachment 2077235 [details] The .spec file difference from Copr build 8594585 to 8675789
Copr build: https://copr.fedorainfracloud.org/coprs/build/8675789 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329412-rust-neli/fedora-rawhide-x86_64/08675789-rust-neli/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Sorry for the delay, the package looks good to me now! === Package was generated with rust2rpm, simplifying the review. ✅❌❓🫤 ✅ package contains only permissible content ✅ package builds and installs without errors on rawhide ✅ test suite is run and all unit tests pass ✅ latest version of the crate is packaged ✅ license matches upstream specification and is acceptable for Fedora ✅ license file is included with %license in %files ✅ package complies with Rust Packaging Guidelines Package APPROVED. === Recommended post-import rust-sig tasks: - set up package on release-monitoring.org: project: $crate homepage: https://crates.io/crates/$crate backend: crates.io version scheme: semantic version filter (*NOT* pre-release filter): alpha;beta;rc;pre distro: Fedora Package: rust-$crate - set bugzilla assignee overrides to @rust-sig (optional)
The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-neli
Ouch, tests fail on s390x (https://kojipkgs.fedoraproject.org//work/tasks/7795/130447795/build.log): test test::test_nl_be_u64 ... ok memory allocation of 34359738372 bytes failed That's 0x800000004 bytes, we probably have some unintended swap somewhere.
That's actually fine, though. The failing one is: test rtnl::test::test_rta_deserialize ... FAILED ...still debugging.
FEDORA-2025-716ae39cd4 (rust-neli-0.7.0~rc3-2.fc43) has been submitted as an update to Fedora 43. https://bodhi.fedoraproject.org/updates/FEDORA-2025-716ae39cd4
FEDORA-2025-716ae39cd4 (rust-neli-0.7.0~rc3-2.fc43) has been pushed to the Fedora 43 stable repository. If problem still persists, please make note of it in this bug report.