2329630 – Review Request: kefir - An implementation of C17 language compiler from scratch

Bug 2329630 - Review Request: kefir - An implementation of C17 language compiler from scratch

Summary: Review Request: kefir - An implementation of C17 language compiler from scratch

Keywords:
Status:	CLOSED ERRATA
Alias:	None
Product:	Fedora
Classification:	Fedora
Component:	Package Review
Sub Component:
Version:	rawhide
Hardware:	Unspecified
OS:	Linux
Priority:	unspecified
Severity:	medium
Target Milestone:	---
Assignee:	Simone Caronni
QA Contact:	Fedora Extras Quality Assurance
Docs Contact:
URL:	https://kefir.protopopov.lv
Whiteboard:
Depends On:
Blocks:
TreeView+	depends on / blocked

Reported:	2024-11-30 16:31 UTC by Benson Muite
Modified:	2025-01-11 01:41 UTC (History)
CC List:	2 users (show)
Fixed In Version:
Clone Of:
Environment:
Last Closed:	2025-01-11 01:25:17 UTC
Type:	---
Embargoed:
Dependent Products:
Flags:	negativo17: fedora-review+

Attachments	(Terms of Use)
The .spec file difference from Copr build 8329844 to 8455882 (4.80 KB, patch) 2024-12-30 20:51 UTC, Fedora Review Service	no flags	Details \| Diff
View All

Description Benson Muite 2024-11-30 16:31:44 UTC

spec: https://download.copr.fedorainfracloud.org/results/fed500/kefir/fedora-rawhide-x86_64/08329716-kefir/kefir.spec
srpm: https://download.copr.fedorainfracloud.org/results/fed500/kefir/fedora-rawhide-x86_64/08329716-kefir/kefir-0.4.0-1.fc42.src.rpm

description:
an implementation of C17 language compiler from scratch. No existing open
source compiler infrastructure is being reused. The main priority is
self-sufficiency of the project, compatibility with platform ABI and
compliance with C17 language standard. Any omissions or incompatibilities
between the language standard and Kefir behavior which are not explicitly
documented (see Implementation & Usage quirks section below) shall be
considered bugs.

Kefir supports modern x86-64 Linux, FreeBSD, OpenBSD and NetBSD environments
(see Supported environments section below). Compiler is also able to produce
JSON streams containing program representation on various stages of
compilation (tokens, AST, IR), as well as printing source code in preprocessed
form. The compiler targets GNU As (Intel syntax with/without prefixes and ATT
syntax are supported) and Yasm assemblers. Kefir is able to produce debug
information in DWARF5 format for GNU As. Position-independent code generation
is supported. Kefir features cc-compatible command line interface.

fas: fed500

Reproducible: Always

Comment 1 Fedora Review Service 2024-11-30 16:41:02 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8329844
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329630-kefir/fedora-rawhide-x86_64/08329844-kefir/fedora-review/review.txt

Found issues:

- kefir : /usr/include/kefir/toolchain/kefir/ast-translator/base.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/context.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/debug/translator.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/environment.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/flow_control.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/function_declaration.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/function_definition.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/initializer.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/jump.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/layout.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/lvalue.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/misc.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/global_scope_layout.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/local_scope_layout.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/scope_layout_impl.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/scoped_identifier.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/translator.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/temporaries.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/translator.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/translator_impl.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/type.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/typeconv.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/util.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/value.h kefir : /usr/include/kefir/toolchain/kefir/ast/alignment.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/analyzer.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/declarator.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/initializer.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/member_designator.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/nodes.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/type_traversal.h kefir : /usr/include/kefir/toolchain/kefir/ast/attributes.h kefir : /usr/include/kefir/toolchain/kefir/ast/base.h kefir : /usr/include/kefir/toolchain/kefir/ast/constant_expression.h kefir : /usr/include/kefir/toolchain/kefir/ast/constant_expression_impl.h kefir : /usr/include/kefir/toolchain/kefir/ast/constants.h kefir : /usr/include/kefir/toolchain/kefir/ast/context.h kefir : /usr/include/kefir/toolchain/kefir/ast/context_impl.h kefir : /usr/include/kefir/toolchain/kefir/ast/context_manager.h kefir : /usr/include/kefir/toolchain/kefir/ast/declarator.h kefir : /usr/include/kefir/toolchain/kefir/ast/declarator_specifier.h kefir : /usr/include/kefir/toolchain/kefir/ast/designator.h kefir : /usr/include/kefir/toolchain/kefir/ast/downcast.h kefir : /usr/include/kefir/toolchain/kefir/ast/flow_control.h kefir : /usr/include/kefir/toolchain/kefir/ast/format.h kefir : /usr/include/kefir/toolchain/kefir/ast/function_declaration_context.h kefir : /usr/include/kefir/toolchain/kefir/ast/global_context.h kefir : /usr/include/kefir/toolchain/kefir/ast/initializer.h kefir : /usr/include/kefir/toolchain/kefir/ast/initializer_traversal.h kefir : /usr/include/kefir/toolchain/kefir/ast/local_context.h kefir : /usr/include/kefir/toolchain/kefir/ast/node.h kefir : /usr/include/kefir/toolchain/kefir/ast/node_base.h kefir : /usr/include/kefir/toolchain/kefir/ast/node_helpers.h kefir : /usr/include/kefir/toolchain/kefir/ast/node_internal.h kefir : /usr/include/kefir/toolchain/kefir/ast/object.h kefir : /usr/include/kefir/toolchain/kefir/ast/runtime.h kefir : /usr/include/kefir/toolchain/kefir/ast/scope.h kefir : /usr/include/kefir/toolchain/kefir/ast/target_environment.h kefir : /usr/include/kefir/toolchain/kefir/ast/temporaries.h kefir : /usr/include/kefir/toolchain/kefir/ast/type.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/array.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/base.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/basic.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/enum.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/function.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/pointer.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/qualified.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/struct.h kefir : /usr/include/kefir/toolchain/kefir/ast/type_completion.h kefir : /usr/include/kefir/toolchain/kefir/ast/type_conv.h kefir : /usr/include/kefir/toolchain/kefir/ast/type_layout.h kefir : /usr/include/kefir/toolchain/kefir/cc1/cc1.h kefir : /usr/include/kefir/toolchain/kefir/cc1/options.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64-common.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/asmcmp.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/codegen.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/devirtualize.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/dwarf.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/function.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/module.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/register_allocator.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/stack_frame.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/static_data.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/symbolic_labels.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/base.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/context.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/debug.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/format.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/liveness.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/pipeline.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/type_defs.h kefir : /usr/include/kefir/toolchain/kefir/codegen/codegen.h kefir : /usr/include/kefir/toolchain/kefir/compiler/compiler.h kefir : /usr/include/kefir/toolchain/kefir/compiler/configuration.h kefir : /usr/include/kefir/toolchain/kefir/compiler/profile.h kefir : /usr/include/kefir/toolchain/kefir/core/base.h kefir : /usr/include/kefir/toolchain/kefir/core/basic-types.h kefir : /usr/include/kefir/toolchain/kefir/core/bitset.h kefir : /usr/include/kefir/toolchain/kefir/core/block_tree.h kefir : /usr/include/kefir/toolchain/kefir/core/data_model.h kefir : /usr/include/kefir/toolchain/kefir/core/error.h kefir : /usr/include/kefir/toolchain/kefir/core/error_format.h kefir : /usr/include/kefir/toolchain/kefir/core/extensions.h kefir : /usr/include/kefir/toolchain/kefir/core/graph.h kefir : /usr/include/kefir/toolchain/kefir/core/hashtree.h kefir : /usr/include/kefir/toolchain/kefir/core/hashtreeset.h kefir : /usr/include/kefir/toolchain/kefir/core/interval_tree.h kefir : /usr/include/kefir/toolchain/kefir/core/list.h kefir : /usr/include/kefir/toolchain/kefir/core/mem.h kefir : /usr/include/kefir/toolchain/kefir/core/optional.h kefir : /usr/include/kefir/toolchain/kefir/core/os_error.h kefir : /usr/include/kefir/toolchain/kefir/core/platform.h kefir : /usr/include/kefir/toolchain/kefir/core/sort.h kefir : /usr/include/kefir/toolchain/kefir/core/source_error.h kefir : /usr/include/kefir/toolchain/kefir/core/source_location.h kefir : /usr/include/kefir/toolchain/kefir/core/string_array.h kefir : /usr/include/kefir/toolchain/kefir/core/string_buffer.h kefir : /usr/include/kefir/toolchain/kefir/core/string_builder.h kefir : /usr/include/kefir/toolchain/kefir/core/string_pool.h kefir : /usr/include/kefir/toolchain/kefir/core/tree.h kefir : /usr/include/kefir/toolchain/kefir/core/trie.h kefir : /usr/include/kefir/toolchain/kefir/core/util.h kefir : /usr/include/kefir/toolchain/kefir/core/vector.h kefir : /usr/include/kefir/toolchain/kefir/core/version.h kefir : /usr/include/kefir/toolchain/kefir/driver/compiler_options.h kefir : /usr/include/kefir/toolchain/kefir/driver/configuration.h kefir : /usr/include/kefir/toolchain/kefir/driver/driver.h kefir : /usr/include/kefir/toolchain/kefir/driver/driver_prologue.h kefir : /usr/include/kefir/toolchain/kefir/driver/externals.h kefir : /usr/include/kefir/toolchain/kefir/driver/parser.h kefir : /usr/include/kefir/toolchain/kefir/driver/runner.h kefir : /usr/include/kefir/toolchain/kefir/driver/target.h kefir : /usr/include/kefir/toolchain/kefir/driver/target_configuration.h kefir : /usr/include/kefir/toolchain/kefir/driver/tools.h kefir : /usr/include/kefir/toolchain/kefir/ir/assembly.h kefir : /usr/include/kefir/toolchain/kefir/ir/bitfields.h kefir : /usr/include/kefir/toolchain/kefir/ir/builder.h kefir : /usr/include/kefir/toolchain/kefir/ir/builtins.h kefir : /usr/include/kefir/toolchain/kefir/ir/compact.h kefir : /usr/include/kefir/toolchain/kefir/ir/data.h kefir : /usr/include/kefir/toolchain/kefir/ir/debug.h kefir : /usr/include/kefir/toolchain/kefir/ir/format.h kefir : /usr/include/kefir/toolchain/kefir/ir/format_impl.h kefir : /usr/include/kefir/toolchain/kefir/ir/function.h kefir : /usr/include/kefir/toolchain/kefir/ir/instr.h kefir : /usr/include/kefir/toolchain/kefir/ir/mnemonic.h kefir : /usr/include/kefir/toolchain/kefir/ir/module.h kefir : /usr/include/kefir/toolchain/kefir/ir/opcode_defs.h kefir : /usr/include/kefir/toolchain/kefir/ir/opcodes.h kefir : /usr/include/kefir/toolchain/kefir/ir/platform.h kefir : /usr/include/kefir/toolchain/kefir/ir/type.h kefir : /usr/include/kefir/toolchain/kefir/ir/type_tree.h kefir : /usr/include/kefir/toolchain/kefir/lexer/base.h kefir : /usr/include/kefir/toolchain/kefir/lexer/buffer.h kefir : /usr/include/kefir/toolchain/kefir/lexer/context.h kefir : /usr/include/kefir/toolchain/kefir/lexer/format.h kefir : /usr/include/kefir/toolchain/kefir/lexer/lexem.h kefir : /usr/include/kefir/toolchain/kefir/lexer/lexer.h kefir : /usr/include/kefir/toolchain/kefir/lexer/source_cursor.h kefir : /usr/include/kefir/toolchain/kefir/lexer/string_literal_impl.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/analysis.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/base.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/builder.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/code.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/code_util.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/configuration.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/constructor.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/constructor_internal.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/debug.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/format.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/function.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/liveness.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/module.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/opcode_defs.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/pipeline.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/type.h kefir : /usr/include/kefir/toolchain/kefir/parser/base.h kefir : /usr/include/kefir/toolchain/kefir/parser/builder.h kefir : /usr/include/kefir/toolchain/kefir/parser/builtins.h kefir : /usr/include/kefir/toolchain/kefir/parser/cursor.h kefir : /usr/include/kefir/toolchain/kefir/parser/parser.h kefir : /usr/include/kefir/toolchain/kefir/parser/rule_helpers.h kefir : /usr/include/kefir/toolchain/kefir/parser/rules.h kefir : /usr/include/kefir/toolchain/kefir/parser/ruleset.h kefir : /usr/include/kefir/toolchain/kefir/parser/scope.h kefir : /usr/include/kefir/toolchain/kefir/platform/cli_parser.h kefir : /usr/include/kefir/toolchain/kefir/platform/filesystem.h kefir : /usr/include/kefir/toolchain/kefir/platform/filesystem_source.h kefir : /usr/include/kefir/toolchain/kefir/platform/input.h kefir : /usr/include/kefir/toolchain/kefir/platform/process.h kefir : /usr/include/kefir/toolchain/kefir/platform/tempfile.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/ast_context.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/directives.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/format.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/macro.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/macro_scope.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/predefined_macro.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/preprocessor.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/source_dependency_locator.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/source_file.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/token_sequence.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/tokenizer.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/user_macro.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/util.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/virtual_source_file.h kefir : /usr/include/kefir/toolchain/kefir/runtime/common/alloca.h kefir : /usr/include/kefir/toolchain/kefir/runtime/common/typeclass.h kefir : /usr/include/kefir/toolchain/kefir/runtime/common/typeclass_kefir_impl.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/base.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/bitfields.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/function.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/parameters.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/platform.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/return.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/bitfields.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/data.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/parameters.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/qwords.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/return.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/type_layout.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/type_layout.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/vararg.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/util.h kefir : /usr/include/kefir/toolchain/kefir/target/asm/amd64/db.h kefir : /usr/include/kefir/toolchain/kefir/target/asm/amd64/xasmgen.h kefir : /usr/include/kefir/toolchain/kefir/target/dwarf/dwarf.h kefir : /usr/include/kefir/toolchain/kefir/target/dwarf/generator.h kefir : /usr/include/kefir/toolchain/kefir/test/codegen.h kefir : /usr/include/kefir/toolchain/kefir/test/module_shim.h kefir : /usr/include/kefir/toolchain/kefir/test/unit_test.h kefir : /usr/include/kefir/toolchain/kefir/test/util.h kefir : /usr/include/kefir/toolchain/kefir/util/char32.h kefir : /usr/include/kefir/toolchain/kefir/util/json.h kefir : /usr/include/kefir/toolchain/kefir/util/uchar.h 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
- Unversioned so-files directly in %_libdir.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
- Package has .a files: kefir. Illegal package name: kefir. Does not provide -static: kefir.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Simone Caronni 2024-12-28 11:52:37 UTC

1) Please drop the first block, is not needed at all:

## START: Set by rpmautospec
## (rpmautospec version 0.7.3)
## RPMAUTOSPEC: autorelease, autochangelog
%define autorelease(e:s:pb:n) %{?-p:0.}%{lua:
    release_number = 1;
    base_release_number = tonumber(rpm.expand("%{?-b*}%{!?-b:1}"));
    print(release_number + base_release_number - 1);
}%{?-e:.%{-e*}}%{?-s:.%{-s*}}%{!?-n:%{?dist}}
## END: Set by rpmautospec

2) In the %changelog section, remove everything and just use %autochangelog to have the changelog automatically populated with git commit messages:

%changelog
%autochangelog

Comment 3 Simone Caronni 2024-12-28 11:56:41 UTC

I would also change the following for formatting and simplification in the files section, but up to you, it's not required:

%build
LC_ALL=C.UTF-8 %make_build all \
    PROFILE=reldebug \
    CC=gcc \
    DESTDIR=%{buildroot} \
    prefix=%{_prefix} \
    libdir=%{_libdir} \
    sysconfdir=%{_sysconfdir}

%install
%make_install \
    prefix=%{_prefix} \
    libdir=%{_libdir} \
    sysconfdir=%{_sysconfdir}

rm -fr %{buildroot}%{_datadir}/licenses

%check
make test

%files
%license source/runtime/LICENSE COPYING
%doc CHANGELOG README.md
%{_bindir}/kefir
%{_bindir}/kefir-cc
%{_bindir}/kefir-cc1
%{_bindir}/kefir-detect-host-env
%{_mandir}/man1/kefir.1.*
%{_mandir}/man1/kefir-cc1.1.*
%{_mandir}/man1/kefir-detect-host-env.1.*
%{_sysconfdir}/kefir.local
%{_includedir}/kefir
%{_libdir}/libkefir.so
%{_libdir}/libkefir.so.0.0
%{_libdir}/libkefir.a
%{_libdir}/libkefirrt.a

Comment 4 Benson Muite 2024-12-30 20:41:46 UTC

Thanks. Addressed all comments.

spec:  https://fed500.fedorapeople.org/kefir.spec
srpm:  https://fed500.fedorapeople.org/kefir-0.4.0-1.fc42.src.rpm

Comment 5 Fedora Review Service 2024-12-30 20:51:42 UTC

Created attachment 2064308 [details]
The .spec file difference from Copr build 8329844 to 8455882

Comment 6 Fedora Review Service 2024-12-30 20:51:44 UTC

Copr build:
https://copr.fedorainfracloud.org/coprs/build/8455882
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329630-kefir/fedora-rawhide-x86_64/08455882-kefir/fedora-review/review.txt

Found issues:

- kefir : /usr/include/kefir/toolchain/kefir/ast-translator/base.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/context.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/debug/translator.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/environment.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/flow_control.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/function_declaration.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/function_definition.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/initializer.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/jump.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/layout.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/lvalue.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/misc.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/global_scope_layout.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/local_scope_layout.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/scope_layout_impl.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/scoped_identifier.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/scope/translator.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/temporaries.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/translator.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/translator_impl.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/type.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/typeconv.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/util.h kefir : /usr/include/kefir/toolchain/kefir/ast-translator/value.h kefir : /usr/include/kefir/toolchain/kefir/ast/alignment.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/analyzer.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/declarator.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/initializer.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/member_designator.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/nodes.h kefir : /usr/include/kefir/toolchain/kefir/ast/analyzer/type_traversal.h kefir : /usr/include/kefir/toolchain/kefir/ast/attributes.h kefir : /usr/include/kefir/toolchain/kefir/ast/base.h kefir : /usr/include/kefir/toolchain/kefir/ast/constant_expression.h kefir : /usr/include/kefir/toolchain/kefir/ast/constant_expression_impl.h kefir : /usr/include/kefir/toolchain/kefir/ast/constants.h kefir : /usr/include/kefir/toolchain/kefir/ast/context.h kefir : /usr/include/kefir/toolchain/kefir/ast/context_impl.h kefir : /usr/include/kefir/toolchain/kefir/ast/context_manager.h kefir : /usr/include/kefir/toolchain/kefir/ast/declarator.h kefir : /usr/include/kefir/toolchain/kefir/ast/declarator_specifier.h kefir : /usr/include/kefir/toolchain/kefir/ast/designator.h kefir : /usr/include/kefir/toolchain/kefir/ast/downcast.h kefir : /usr/include/kefir/toolchain/kefir/ast/flow_control.h kefir : /usr/include/kefir/toolchain/kefir/ast/format.h kefir : /usr/include/kefir/toolchain/kefir/ast/function_declaration_context.h kefir : /usr/include/kefir/toolchain/kefir/ast/global_context.h kefir : /usr/include/kefir/toolchain/kefir/ast/initializer.h kefir : /usr/include/kefir/toolchain/kefir/ast/initializer_traversal.h kefir : /usr/include/kefir/toolchain/kefir/ast/local_context.h kefir : /usr/include/kefir/toolchain/kefir/ast/node.h kefir : /usr/include/kefir/toolchain/kefir/ast/node_base.h kefir : /usr/include/kefir/toolchain/kefir/ast/node_helpers.h kefir : /usr/include/kefir/toolchain/kefir/ast/node_internal.h kefir : /usr/include/kefir/toolchain/kefir/ast/object.h kefir : /usr/include/kefir/toolchain/kefir/ast/runtime.h kefir : /usr/include/kefir/toolchain/kefir/ast/scope.h kefir : /usr/include/kefir/toolchain/kefir/ast/target_environment.h kefir : /usr/include/kefir/toolchain/kefir/ast/temporaries.h kefir : /usr/include/kefir/toolchain/kefir/ast/type.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/array.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/base.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/basic.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/enum.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/function.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/pointer.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/qualified.h kefir : /usr/include/kefir/toolchain/kefir/ast/type/struct.h kefir : /usr/include/kefir/toolchain/kefir/ast/type_completion.h kefir : /usr/include/kefir/toolchain/kefir/ast/type_conv.h kefir : /usr/include/kefir/toolchain/kefir/ast/type_layout.h kefir : /usr/include/kefir/toolchain/kefir/cc1/cc1.h kefir : /usr/include/kefir/toolchain/kefir/cc1/options.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64-common.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/asmcmp.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/codegen.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/devirtualize.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/dwarf.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/function.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/module.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/register_allocator.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/stack_frame.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/static_data.h kefir : /usr/include/kefir/toolchain/kefir/codegen/amd64/symbolic_labels.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/base.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/context.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/debug.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/format.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/liveness.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/pipeline.h kefir : /usr/include/kefir/toolchain/kefir/codegen/asmcmp/type_defs.h kefir : /usr/include/kefir/toolchain/kefir/codegen/codegen.h kefir : /usr/include/kefir/toolchain/kefir/compiler/compiler.h kefir : /usr/include/kefir/toolchain/kefir/compiler/configuration.h kefir : /usr/include/kefir/toolchain/kefir/compiler/profile.h kefir : /usr/include/kefir/toolchain/kefir/core/base.h kefir : /usr/include/kefir/toolchain/kefir/core/basic-types.h kefir : /usr/include/kefir/toolchain/kefir/core/bitset.h kefir : /usr/include/kefir/toolchain/kefir/core/block_tree.h kefir : /usr/include/kefir/toolchain/kefir/core/data_model.h kefir : /usr/include/kefir/toolchain/kefir/core/error.h kefir : /usr/include/kefir/toolchain/kefir/core/error_format.h kefir : /usr/include/kefir/toolchain/kefir/core/extensions.h kefir : /usr/include/kefir/toolchain/kefir/core/graph.h kefir : /usr/include/kefir/toolchain/kefir/core/hashtree.h kefir : /usr/include/kefir/toolchain/kefir/core/hashtreeset.h kefir : /usr/include/kefir/toolchain/kefir/core/interval_tree.h kefir : /usr/include/kefir/toolchain/kefir/core/list.h kefir : /usr/include/kefir/toolchain/kefir/core/mem.h kefir : /usr/include/kefir/toolchain/kefir/core/optional.h kefir : /usr/include/kefir/toolchain/kefir/core/os_error.h kefir : /usr/include/kefir/toolchain/kefir/core/platform.h kefir : /usr/include/kefir/toolchain/kefir/core/sort.h kefir : /usr/include/kefir/toolchain/kefir/core/source_error.h kefir : /usr/include/kefir/toolchain/kefir/core/source_location.h kefir : /usr/include/kefir/toolchain/kefir/core/string_array.h kefir : /usr/include/kefir/toolchain/kefir/core/string_buffer.h kefir : /usr/include/kefir/toolchain/kefir/core/string_builder.h kefir : /usr/include/kefir/toolchain/kefir/core/string_pool.h kefir : /usr/include/kefir/toolchain/kefir/core/tree.h kefir : /usr/include/kefir/toolchain/kefir/core/trie.h kefir : /usr/include/kefir/toolchain/kefir/core/util.h kefir : /usr/include/kefir/toolchain/kefir/core/vector.h kefir : /usr/include/kefir/toolchain/kefir/core/version.h kefir : /usr/include/kefir/toolchain/kefir/driver/compiler_options.h kefir : /usr/include/kefir/toolchain/kefir/driver/configuration.h kefir : /usr/include/kefir/toolchain/kefir/driver/driver.h kefir : /usr/include/kefir/toolchain/kefir/driver/driver_prologue.h kefir : /usr/include/kefir/toolchain/kefir/driver/externals.h kefir : /usr/include/kefir/toolchain/kefir/driver/parser.h kefir : /usr/include/kefir/toolchain/kefir/driver/runner.h kefir : /usr/include/kefir/toolchain/kefir/driver/target.h kefir : /usr/include/kefir/toolchain/kefir/driver/target_configuration.h kefir : /usr/include/kefir/toolchain/kefir/driver/tools.h kefir : /usr/include/kefir/toolchain/kefir/ir/assembly.h kefir : /usr/include/kefir/toolchain/kefir/ir/bitfields.h kefir : /usr/include/kefir/toolchain/kefir/ir/builder.h kefir : /usr/include/kefir/toolchain/kefir/ir/builtins.h kefir : /usr/include/kefir/toolchain/kefir/ir/compact.h kefir : /usr/include/kefir/toolchain/kefir/ir/data.h kefir : /usr/include/kefir/toolchain/kefir/ir/debug.h kefir : /usr/include/kefir/toolchain/kefir/ir/format.h kefir : /usr/include/kefir/toolchain/kefir/ir/format_impl.h kefir : /usr/include/kefir/toolchain/kefir/ir/function.h kefir : /usr/include/kefir/toolchain/kefir/ir/instr.h kefir : /usr/include/kefir/toolchain/kefir/ir/mnemonic.h kefir : /usr/include/kefir/toolchain/kefir/ir/module.h kefir : /usr/include/kefir/toolchain/kefir/ir/opcode_defs.h kefir : /usr/include/kefir/toolchain/kefir/ir/opcodes.h kefir : /usr/include/kefir/toolchain/kefir/ir/platform.h kefir : /usr/include/kefir/toolchain/kefir/ir/type.h kefir : /usr/include/kefir/toolchain/kefir/ir/type_tree.h kefir : /usr/include/kefir/toolchain/kefir/lexer/base.h kefir : /usr/include/kefir/toolchain/kefir/lexer/buffer.h kefir : /usr/include/kefir/toolchain/kefir/lexer/context.h kefir : /usr/include/kefir/toolchain/kefir/lexer/format.h kefir : /usr/include/kefir/toolchain/kefir/lexer/lexem.h kefir : /usr/include/kefir/toolchain/kefir/lexer/lexer.h kefir : /usr/include/kefir/toolchain/kefir/lexer/source_cursor.h kefir : /usr/include/kefir/toolchain/kefir/lexer/string_literal_impl.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/analysis.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/base.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/builder.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/code.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/code_util.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/configuration.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/constructor.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/constructor_internal.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/debug.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/format.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/function.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/liveness.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/module.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/opcode_defs.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/pipeline.h kefir : /usr/include/kefir/toolchain/kefir/optimizer/type.h kefir : /usr/include/kefir/toolchain/kefir/parser/base.h kefir : /usr/include/kefir/toolchain/kefir/parser/builder.h kefir : /usr/include/kefir/toolchain/kefir/parser/builtins.h kefir : /usr/include/kefir/toolchain/kefir/parser/cursor.h kefir : /usr/include/kefir/toolchain/kefir/parser/parser.h kefir : /usr/include/kefir/toolchain/kefir/parser/rule_helpers.h kefir : /usr/include/kefir/toolchain/kefir/parser/rules.h kefir : /usr/include/kefir/toolchain/kefir/parser/ruleset.h kefir : /usr/include/kefir/toolchain/kefir/parser/scope.h kefir : /usr/include/kefir/toolchain/kefir/platform/cli_parser.h kefir : /usr/include/kefir/toolchain/kefir/platform/filesystem.h kefir : /usr/include/kefir/toolchain/kefir/platform/filesystem_source.h kefir : /usr/include/kefir/toolchain/kefir/platform/input.h kefir : /usr/include/kefir/toolchain/kefir/platform/process.h kefir : /usr/include/kefir/toolchain/kefir/platform/tempfile.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/ast_context.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/directives.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/format.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/macro.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/macro_scope.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/predefined_macro.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/preprocessor.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/source_dependency_locator.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/source_file.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/token_sequence.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/tokenizer.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/user_macro.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/util.h kefir : /usr/include/kefir/toolchain/kefir/preprocessor/virtual_source_file.h kefir : /usr/include/kefir/toolchain/kefir/runtime/common/alloca.h kefir : /usr/include/kefir/toolchain/kefir/runtime/common/typeclass.h kefir : /usr/include/kefir/toolchain/kefir/runtime/common/typeclass_kefir_impl.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/base.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/bitfields.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/function.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/parameters.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/platform.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/return.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/bitfields.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/data.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/parameters.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/qwords.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/return.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/system-v/type_layout.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/type_layout.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/amd64/vararg.h kefir : /usr/include/kefir/toolchain/kefir/target/abi/util.h kefir : /usr/include/kefir/toolchain/kefir/target/asm/amd64/db.h kefir : /usr/include/kefir/toolchain/kefir/target/asm/amd64/xasmgen.h kefir : /usr/include/kefir/toolchain/kefir/target/dwarf/dwarf.h kefir : /usr/include/kefir/toolchain/kefir/target/dwarf/generator.h kefir : /usr/include/kefir/toolchain/kefir/test/codegen.h kefir : /usr/include/kefir/toolchain/kefir/test/module_shim.h kefir : /usr/include/kefir/toolchain/kefir/test/unit_test.h kefir : /usr/include/kefir/toolchain/kefir/test/util.h kefir : /usr/include/kefir/toolchain/kefir/util/char32.h kefir : /usr/include/kefir/toolchain/kefir/util/json.h kefir : /usr/include/kefir/toolchain/kefir/util/uchar.h 
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
- Unversioned so-files directly in %_libdir.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages
- Package has .a files: kefir. Illegal package name: kefir. Does not provide -static: kefir.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 7 Simone Caronni 2025-01-01 11:13:52 UTC

The warning above about the headers not in a devel package is misleading for a compiler.

Package approved!

Comment 8 Fedora Admin user for bugzilla script actions 2025-01-02 10:58:47 UTC

The Pagure repository was created at https://src.fedoraproject.org/rpms/kefir

Comment 9 Fedora Update System 2025-01-02 11:34:59 UTC

FEDORA-2025-27a0e2aa1e (kefir-0.4.0-1.fc40) has been submitted as an update to Fedora 40.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-27a0e2aa1e

Comment 10 Fedora Update System 2025-01-02 11:39:21 UTC

FEDORA-2025-eda229cc31 (kefir-0.4.0-1.fc41) has been submitted as an update to Fedora 41.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-eda229cc31

Comment 11 Benson Muite 2025-01-02 12:59:28 UTC

Thanks for the review.

Comment 12 Benson Muite 2025-01-02 19:22:25 UTC

https://release-monitoring.org/project/376198/

Comment 13 Fedora Update System 2025-01-03 03:57:54 UTC

FEDORA-2025-27a0e2aa1e has been pushed to the Fedora 40 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-27a0e2aa1e \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-27a0e2aa1e

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 14 Fedora Update System 2025-01-03 05:03:45 UTC

FEDORA-2025-eda229cc31 has been pushed to the Fedora 41 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2025-eda229cc31 \*`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2025-eda229cc31

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 15 Fedora Update System 2025-01-11 01:25:17 UTC

FEDORA-2025-27a0e2aa1e (kefir-0.4.0-1.fc40) has been pushed to the Fedora 40 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 16 Fedora Update System 2025-01-11 01:41:52 UTC

FEDORA-2025-eda229cc31 (kefir-0.4.0-1.fc41) has been pushed to the Fedora 41 stable repository.
If problem still persists, please make note of it in this bug report.

Note You need to log in before you can comment on or make changes to this bug.