Spec URL: https://scrye.com/~kevin/fedora/review/python-jaconv/python-jaconv.spec SRPM URL: https://scrye.com/~kevin/fedora/review/python-jaconv/python-jaconv-0.3.4-1.fc42.src.rpm Description: a Python Natural Language Processing (NLP) library to transliterate hiragana, katakana and kanji (Japanese text) into rōmaji (Latin/Roman alphabet). It can handle characters in NFC form.} Fedora Account System Username: kevin This package is needed by pykakasi which is a new dep on calibre. It uses nose for tests, so since we are trying to retire nose I haven't enabled tests.
Copr build: https://copr.fedorainfracloud.org/coprs/build/8332105 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2329762-python-jaconv/fedora-rawhide-x86_64/08332105-python-jaconv/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License", "*No copyright* MIT License". 16 files have unknown license. Detailed output of licensecheck in /home/FedoraPackaging/reviews/python-jaconv/2329762- python-jaconv/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 6181 bytes in 2 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [ ]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-jaconv-0.3.4-1.fc42.noarch.rpm python-jaconv-0.3.4-1.fc42.src.rpm ======================================== rpmlint session starts ======================================= rpmlint: 2.5.0 configuration: /usr/lib/python3.12/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmpal170tpd')] checks: 32, packages: 2 python-jaconv.src: E: summary-too-long Pure-Python Japanese character interconverter for Hiragana, Katakana, Hankaku, Zenkaku and more python3-jaconv.noarch: E: summary-too-long Pure-Python Japanese character interconverter for Hiragana, Katakana, Hankaku, Zenkaku and more python-jaconv.src: E: spelling-error ('interconverter', 'Summary(en_US) interconverter -> inter converter, inter-converter, interconnection') python-jaconv.src: E: spelling-error ('rōmaji', '%description -l en_US rōmaji -> majority') python3-jaconv.noarch: E: spelling-error ('interconverter', 'Summary(en_US) interconverter -> inter converter, inter-converter, interconnection') python3-jaconv.noarch: E: spelling-error ('rōmaji', '%description -l en_US rōmaji -> majority') === 2 packages and 0 specfiles checked; 6 errors, 0 warnings, 7 filtered, 6 badness; has taken 4.1 s == Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 python3-jaconv.noarch: E: summary-too-long Pure-Python Japanese character interconverter for Hiragana, Katakana, Hankaku, Zenkaku and more python3-jaconv.noarch: E: spelling-error ('interconverter', 'Summary(en_US) interconverter -> inter converter, inter-converter, interconnection') python3-jaconv.noarch: E: spelling-error ('rōmaji', '%description -l en_US rōmaji -> majority') 1 packages and 0 specfiles checked; 3 errors, 0 warnings, 3 filtered, 3 badness; has taken 0.7 s Source checksums ---------------- https://github.com/ikegami-yukino/jaconv/archive/refs/tags/v0.3.4.tar.gz : CHECKSUM(SHA256) this package : bc5b1869a85f82dd26c62977012615c16ddfe5330685cc938905f481534c9e09 CHECKSUM(SHA256) upstream package : bc5b1869a85f82dd26c62977012615c16ddfe5330685cc938905f481534c9e09 Requires -------- python3-jaconv (rpmlib, GLIBC filtered): python(abi) Provides -------- python3-jaconv: python-jaconv python3-jaconv python3.13-jaconv python3.13dist(jaconv) python3dist(jaconv) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2329762 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, Python Disabled plugins: Java, PHP, fonts, Perl, C/C++, Ocaml, SugarActivity, Haskell, R Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Can tests be run? https://github.com/ikegami-yukino/jaconv/blob/master/test_jaconv.py b) Consider changing Source: https://github.com/ikegami-yukino/jaconv/archive/refs/tags/v0.3.4.tar.gz to Source: %{url}/archive/v%{version}/jaconv-%{version}.tar.gz to match what is in the packaging guidelines. c) Consider changing %pyproject_save_files -l jaconv to %pyproject_save_files -l jaconv -l to ensure license is always packaged https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_build_macros d) Above are no musts, so Approved, but consider making suggested changes on import.
Thanks so much for the review! a) Yeah, I could run tests... but they use nose, and my understanding is that we didn't want to use nose anymore. b) yep. Done. c) yep. Done. Thanks again.
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-jaconv
Ah ha. After looking around again I see there's a pending upstream PR to move tests to pytest: https://github.com/ikegami-yukino/jaconv/pull/36 Applying that seems to work great: + /usr/bin/pytest ============================= test session starts ============================== platform linux -- Python 3.13.0, pytest-8.3.3, pluggy-1.5.0 rootdir: /builddir/build/BUILD/python-jaconv-0.3.4-build/jaconv-0.3.4 collected 10 items test_jaconv.py .......... [100%] ============================== 10 passed in 0.04s ============================== I'll apply that
Thanks for adding the tests.