Spec URL: https://ngompa.fedorapeople.org/for-review/mingw-SDL3.spec SRPM URL: https://ngompa.fedorapeople.org/for-review/mingw-SDL3-3.1.6-1.fc41.src.rpm Description: Simple DirectMedia Layer (SDL) is a cross-platform multimedia library designed to provide fast access to the graphics frame buffer and audio device. Fedora Account System Username: ngompa
Copr build: https://copr.fedorainfracloud.org/coprs/build/8335538 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330096-mingw-sdl3/fedora-rawhide-x86_64/08335538-mingw-SDL3/fedora-review/review.txt Found issues: - mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_assert.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_atomic.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_audio.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_begin_code.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_bits.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_blendmode.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_camera.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_clipboard.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_close_code.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_copying.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_cpuinfo.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_dialog.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_egl.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_endian.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_error.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_events.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_filesystem.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_gamepad.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_gpu.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_guid.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_haptic.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_hidapi.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_hints.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_init.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_intrin.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_iostream.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_joystick.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_keyboard.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_keycode.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_loadso.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_locale.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_log.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_main.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_main_impl.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_messagebox.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_metal.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_misc.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_mouse.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_mutex.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_oldnames.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengl.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengl_glext.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2_gl2.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2_gl2ext.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2_gl2platform.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2_khrplatform.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_pen.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_pixels.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_platform.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_platform_defines.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_power.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_process.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_properties.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_rect.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_render.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_revision.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_scancode.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_sensor.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_stdinc.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_storage.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_surface.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_system.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_assert.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_common.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_compare.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_crc32.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_font.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_fuzzer.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_harness.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_log.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_md5.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_memory.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_thread.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_time.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_timer.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_touch.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_version.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_video.h mingw32-SDL3 : /usr/i686-w64-mingw32/sys-root/mingw/include/SDL3/SDL_vulkan.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_assert.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_atomic.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_audio.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_begin_code.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_bits.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_blendmode.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_camera.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_clipboard.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_close_code.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_copying.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_cpuinfo.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_dialog.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_egl.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_endian.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_error.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_events.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_filesystem.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_gamepad.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_gpu.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_guid.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_haptic.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_hidapi.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_hints.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_init.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_intrin.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_iostream.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_joystick.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_keyboard.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_keycode.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_loadso.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_locale.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_log.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_main.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_main_impl.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_messagebox.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_metal.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_misc.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_mouse.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_mutex.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_oldnames.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengl.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengl_glext.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2_gl2.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2_gl2ext.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2_gl2platform.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_opengles2_khrplatform.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_pen.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_pixels.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_platform.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_platform_defines.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_power.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_process.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_properties.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_rect.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_render.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_revision.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_scancode.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_sensor.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_stdinc.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_storage.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_surface.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_system.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_assert.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_common.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_compare.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_crc32.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_font.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_fuzzer.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_harness.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_log.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_md5.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_test_memory.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_thread.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_time.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_timer.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_touch.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_version.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_video.h mingw64-SDL3 : /usr/x86_64-w64-mingw32/sys-root/mingw/include/SDL3/SDL_vulkan.h Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages - License file SDL_copying.h is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Package has .a files: mingw32-SDL3, mingw32-SDL3-static, mingw64-SDL3, mingw64-SDL3-static. Illegal package name: mingw32-SDL3, mingw64-SDL3. Does not provide -static: mingw32-SDL3, mingw64-SDL3. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
fedora-review is... not happy with this. Similarly to SDL3, please add a bundled provides for hidapi on import as it's being vendored. Should be good to go otherwise.
The Pagure repository was created at https://src.fedoraproject.org/rpms/mingw-SDL3
FEDORA-2024-6bb2476baf (mingw-SDL3-3.1.6-1.fc41 and SDL3-3.1.6-1.fc41) has been submitted as an update to Fedora 41. https://bodhi.fedoraproject.org/updates/FEDORA-2024-6bb2476baf
FEDORA-2024-2359c79d49 (mingw-SDL3-3.1.6-1.fc40 and SDL3-3.1.6-1.fc40) has been submitted as an update to Fedora 40. https://bodhi.fedoraproject.org/updates/FEDORA-2024-2359c79d49
FEDORA-2024-6bb2476baf has been pushed to the Fedora 41 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-6bb2476baf \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-6bb2476baf See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-2359c79d49 has been pushed to the Fedora 40 testing repository. Soon you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --refresh --advisory=FEDORA-2024-2359c79d49 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2024-2359c79d49 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2024-6bb2476baf (mingw-SDL3-3.1.6-1.fc41 and SDL3-3.1.6-1.fc41) has been pushed to the Fedora 41 stable repository. If problem still persists, please make note of it in this bug report.
FEDORA-2024-2359c79d49 (mingw-SDL3-3.1.6-1.fc40 and SDL3-3.1.6-1.fc40) has been pushed to the Fedora 40 stable repository. If problem still persists, please make note of it in this bug report.