Spec URL: https://jskarvad.fedorapeople.org/tk8/tk8.spec SRPM URL: https://jskarvad.fedorapeople.org/tk8/tk8-8.6.15-2.fc42.src.rpm Description: When paired with the Tcl scripting language, Tk provides a fast and powerful way to create cross-platform GUI applications. Fedora Account System Username: jskarvad For: https://fedoraproject.org/wiki/Changes/TclTk9.0
Copr build: https://copr.fedorainfracloud.org/coprs/build/8344730 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330617-tk8/fedora-rawhide-x86_64/08344730-tk8/fedora-review/review.txt Found issues: - License file license.terms is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - Package has .a files: tk8-devel. Does not provide -static: tk8-devel. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/#packaging-static-libraries Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
> BuildRequires: tcl-devel = %{epoch}:%{vers}, autoconf Consider explicitly BuildRequireing tcl8-devel. Other comments from bz2330615 also apply here (including Obsoletes for tile).
Thanks for the review. New version: Spec URL: https://jskarvad.fedorapeople.org/tk8/tk8.spec SRPM URL: https://jskarvad.fedorapeople.org/tk8/tk8-8.6.15-3.fc42.src.rpm
Created attachment 2061975 [details] The .spec file difference from Copr build 8344730 to 8373816
Copr build: https://copr.fedorainfracloud.org/coprs/build/8373816 (failed) Build log: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330617-tk8/fedora-rawhide-x86_64/08373816-tk8/builder-live.log.gz Please make sure the package builds successfully at least for Fedora Rawhide. - If the build failed for unrelated reasons (e.g. temporary network unavailability), please ignore it. - If the build failed because of missing BuildRequires, please make sure they are listed in the "Depends On" field --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package APPROVED.
The Pagure repository was created at https://src.fedoraproject.org/rpms/tk8