Bug 2330850 - Review Request: anir-samaano-fonts - Mono-space Multi-Lingual Multi-axis Variable Font
Summary: Review Request: anir-samaano-fonts - Mono-space Multi-Lingual Multi-axis Vari...
Keywords:
Status: ASSIGNED
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Benson Muite
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-12-06 17:32 UTC by Dr Anirban Mitra
Modified: 2025-06-10 15:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed:
Type: ---
Embargoed:
benson_muite: fedora-review?


Attachments (Terms of Use)
The .spec file difference from Copr build 9150220 to 9150221 (1.55 KB, patch)
2025-06-10 15:49 UTC, Fedora Review Service
no flags Details | Diff

Description Dr Anirban Mitra 2024-12-06 17:32:39 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/mitradranirban/samaano-fonts/fedora-rawhide-x86_64/08351359-samaano-fonts/samaano-fonts.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mitradranirban/samaano-fonts/fedora-rawhide-x86_64/08351359-samaano-fonts/samaano-fonts-v2.010-1.fc42.src.rpm
Description: Samaano is a variable width, weight, and slant mono-space font created 
using mostly rectangular components. It is fully created using open source
tools. It covers wide range of Latin and Devanagari based languages.
Fedora Account System Username:mitradranirban

Comment 1 Fedora Review Service 2024-12-06 17:35:27 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8351404
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330850-samaano-fonts/fedora-rawhide-x86_64/08351404-samaano-fonts/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 2 Benson Muite 2025-06-09 08:41:30 UTC
Build log contains the following:
realpath: '*.ttf': No such file or directory
realpath: 56-0-samaano-fonts.conf: No such file or directory

Should there be a configuration file?

Comment 3 Dr Anirban Mitra 2025-06-09 11:15:37 UTC
Ok, I will regenerate the srpm and spec and check where is the error.

Comment 4 Dr Anirban Mitra 2025-06-09 17:20:21 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/mitradranirban/samaano-fonts/fedora-rawhide-x86_64/09147790-samaano-fonts/samaano-fonts.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mitradranirban/samaano-fonts/fedora-rawhide-x86_64/09147790-samaano-fonts/samaano-fonts-2.301-1.fc43.src.rpm
Description: Samaano is a variable width, weight, and slant mono-space font created 
using mostly rectangular components. It is fully created using open source
tools. It covers wide range of Latin, Greek and Devanagari based languages.
Fedora Account System Username: mitradranirban

Updated source to latest version and added fontconfig in source itself.

Comment 5 Dr Anirban Mitra 2025-06-09 17:44:02 UTC
[fedora-review-service-build]

Comment 6 Dr Anirban Mitra 2025-06-10 07:22:31 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/mitradranirban/samaano-fonts/fedora-rawhide-x86_64/09148953-samaano-fonts/samaano-fonts.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mitradranirban/samaano-fonts/fedora-rawhide-x86_64/09148953-samaano-fonts/samaano-fonts-2.301-1.fc43.src.rpm
Description: Samaano is a variable width, weight, and slant mono-space font created 
using mostly rectangular components. It is fully created using open source
tools. It covers wide range of Latin, Greek and Devanagari based languages.
Fedora Account System Username: mitradranirban

Modified build process to include static fonts also in the build as mandated in https://docs.fedoraproject.org/en-US/packaging-guidelines/FontsPolicy/

Comment 7 Benson Muite 2025-06-10 10:36:11 UTC
Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed



===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "SIL Open Font License 1.1", "*No
     copyright* SIL Open Font License 1.1", "SIL Open Font License". 9901
     files have unknown license. Detailed output of licensecheck in
     /home/fedora-packaging/reviews/samaano-fonts/2330850-samaano-
     fonts/licensecheck.txt
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[!]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[x]: Package is not known to require an ExcludeArch tag.
[ ]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Package installs properly.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: The License field must be a valid SPDX expression.
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 3379 bytes in 1 files.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[x]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[x]: Rpmlint is run on all installed packages.
     Note: There are rpmlint messages (see attachment).
[x]: Spec file according to URL is the same as in SRPM.

fonts:
[!]: Run fc-query on all fonts in package.
     Note: Cannot find fc-query command, install fontconfig package to make
     a comprehensive font review.
     See: url: undefined
[!]: Run repo-font-audit on all fonts in package.
     Note: Cannot find repo-font-audit, install fontpackages-tools package
     to make a comprehensive font review.
     See: url: undefined


Rpmlint
-------
Checking: samaano-fonts-2.301-1.fc43.noarch.rpm
          samaano-fonts-2.301-1.fc43.src.rpm
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
rpmlintrc: [PosixPath('/tmp/tmpzce5m43l')]
checks: 32, packages: 2

samaano-fonts.noarch: E: spelling-error ('Monospace', 'Summary(en_US) Monospace -> Mono space, Mono-space, Aerospace')
samaano-fonts.src: E: spelling-error ('Monospace', 'Summary(en_US) Monospace -> Mono space, Mono-space, Aerospace')
 2 packages and 0 specfiles checked; 2 errors, 0 warnings, 7 filtered, 2 badness; has taken 1.0 s 




Rpmlint (installed packages)
----------------------------
============================ rpmlint session starts ============================
rpmlint: 2.7.0
configuration:
    /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml
    /etc/xdg/rpmlint/fedora-spdx-licenses.toml
    /etc/xdg/rpmlint/fedora.toml
    /etc/xdg/rpmlint/scoring.toml
    /etc/xdg/rpmlint/users-groups.toml
    /etc/xdg/rpmlint/warn-on-functions.toml
checks: 32, packages: 1

samaano-fonts.noarch: E: spelling-error ('Monospace', 'Summary(en_US) Monospace -> Mono space, Mono-space, Aerospace')
 1 packages and 0 specfiles checked; 1 errors, 0 warnings, 3 filtered, 1 badness; has taken 0.1 s 



Source checksums
----------------
https://github.com/mitradranirban/samaanoVF/raw/refs/heads/main/56-0-samaano-fonts.conf :
  CHECKSUM(SHA256) this package     : 9fd527f682d494dfdd30df4f1c4bf5fdd42b8dcae2ce088df9d2a6c00924e60d
  CHECKSUM(SHA256) upstream package : 9fd527f682d494dfdd30df4f1c4bf5fdd42b8dcae2ce088df9d2a6c00924e60d
https://github.com/mitradranirban/samaano-fonts/archive/v2.301/samaano-fonts-2.301.tar.gz :
  CHECKSUM(SHA256) this package     : e2db3a5033b3eccd2ca65ce0669778aa0e23e3c77996bded381a5ea6af887e62
  CHECKSUM(SHA256) upstream package : e2db3a5033b3eccd2ca65ce0669778aa0e23e3c77996bded381a5ea6af887e62


Requires
--------
samaano-fonts (rpmlib, GLIBC filtered):
    config(samaano-fonts)
    fontpackages-filesystem



Provides
--------
samaano-fonts:
    config(samaano-fonts)
    font(samaano)
    font(samaanoboldslanted)
    font(samaanothin)
    font(samaanothinslanted)
    font(samaanowidethinslanted)
    metainfo()
    metainfo(org.fedoraproject.samaano-fonts.metainfo.xml)
    samaano-fonts



Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24
Command line :/usr/bin/fedora-review -b 2330850
Buildroot used: fedora-rawhide-x86_64
Active plugins: Shell-api, fonts, Generic
Disabled plugins: R, Java, Python, Ocaml, SugarActivity, C/C++, Perl, PHP, Haskell
Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH

Comments:
a) There is an extra file README.md.orig in the sources, consider removing it from
the repository. It does not block the review.
b) Can adjust the variable fonts in Inkscape.

c) Can you register a foundry at:
https://learn.microsoft.com/en-us/typography/vendors/register
https://learn.microsoft.com/en-us/typography/vendors/

Once done update the font name to include the foundry. For example if you choose a
foundry name dam then the name should be dam-samaano-fonts

Comment 8 Benson Muite 2025-06-10 12:12:22 UTC
Font configuration file should probably be 67 or higher, see
/usr/share/fontconfig/templates/fontconfig-priorities.txt

Comment 9 Fedora Review Service 2025-06-10 15:48:30 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9150220
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330850-samaano-fonts/fedora-rawhide-x86_64/09150220-samaano-fonts/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 10 Fedora Review Service 2025-06-10 15:49:04 UTC
Created attachment 2093554 [details]
The .spec file difference from Copr build 9150220 to 9150221

Comment 11 Fedora Review Service 2025-06-10 15:49:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9150221
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330850-samaano-fonts/fedora-rawhide-x86_64/09150221-samaano-fonts/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 12 Dr Anirban Mitra 2025-06-10 15:50:51 UTC
Spec URL: https://download.copr.fedorainfracloud.org/results/mitradranirban/samaano-fonts/fedora-rawhide-x86_64/09150211-anir-samaano-fonts/anir-samaano-fonts.spec
SRPM URL: https://download.copr.fedorainfracloud.org/results/mitradranirban/samaano-fonts/fedora-rawhide-x86_64/09150211-anir-samaano-fonts/anir-samaano-fonts-2.301-1.fc43.src.rpm
Description: Samaano is a variable width, weight, and slant axes mono-space font created 
using mostly rectangular components. It is fully created using open source
tools. It covers a wide range of Latin, Greek and Devanagari based languages.
 

* Modified Package name to %{foundry}-{fontfamily}-fonts format 
* Changed fontconfig file numerical prefix to 67-0

Comment 13 Fedora Review Service 2025-06-10 15:52:46 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9150231
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330850-samaano-fonts/fedora-rawhide-x86_64/09150231-samaano-fonts/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 14 Fedora Review Service 2025-06-10 15:53:19 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/9150233
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2330850-anir-samaano-fonts/fedora-rawhide-x86_64/09150233-anir-samaano-fonts/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.


Note You need to log in before you can comment on or make changes to this bug.