Bug 2331350 - python-inkex fails to build with Python 3.14: InxTestCase.test_inx_files: ValueError: badly formed help string
Summary: python-inkex fails to build with Python 3.14: InxTestCase.test_inx_files: Val...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: python-inkex
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Benson Muite
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.14 2328713
TreeView+ depends on / blocked
 
Reported: 2024-12-10 11:42 UTC by Karolina Surma
Modified: 2025-01-19 13:48 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-01-19 13:48:58 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Gitlab inkscape extensions merge_requests 668 0 None opened Avoid "unsupported format character ')'" on Python 3.14 2025-01-06 14:25:08 UTC

Description Karolina Surma 2024-12-10 11:42:16 UTC
python-inkex fails to build with Python 3.14.0a2.

__________________________ InxTestCase.test_inx_files __________________________

self = ArgumentParser(prog='pytest', usage=None, description='Snap objects to pixels', formatter_class=<class 'argparse.HelpFormatter'>, conflict_handler='error', add_help=True)
action = _StoreAction(option_strings=['-g', '--max_gradient'], dest='max_gradient', nargs=None, const=None, default=0.5, type=<... 'float'>, choices=None, required=False, help='Maximum slope to consider straight (%)', metavar=None, deprecated=False)

    def _check_help(self, action):
        if action.help and hasattr(self, "_get_formatter"):
            formatter = self._get_formatter()
            try:
>               formatter._expand_help(action)

/usr/lib64/python3.14/argparse.py:1665: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <argparse.HelpFormatter object at 0x7fce6f35aa40>
action = _StoreAction(option_strings=['-g', '--max_gradient'], dest='max_gradient', nargs=None, const=None, default=0.5, type=<... 'float'>, choices=None, required=False, help='Maximum slope to consider straight (%)', metavar=None, deprecated=False)

    def _expand_help(self, action):
        help_string = self._get_help_string(action)
        if '%' not in help_string:
            return help_string
        params = dict(vars(action), prog=self._prog)
        for name in list(params):
            value = params[name]
            if value is SUPPRESS:
                del params[name]
            elif hasattr(value, '__name__'):
                params[name] = value.__name__
        if params.get('choices') is not None:
            params['choices'] = ', '.join(map(str, params['choices']))
>       return help_string % params
E       ValueError: unsupported format character ')' (0x29) at index 37

/usr/lib64/python3.14/argparse.py:604: ValueError

The above exception was the direct cause of the following exception:

self = <tests.test_inkex_inx.InxTestCase testMethod=test_inx_files>

    def test_inx_files(self):
        """Get all inx files and test each of them"""
        if not PY3:
            self.skipTest("No INX testing in python2")
            return
        for inx_file in glob(os.path.join(self._testdir(), "..", "*.inx")):
            with self.subTest(inx_file=inx_file):
                self.assertInxSchemaValid(inx_file)
>               self.assertInxIsGood(inx_file)

tests/test_inkex_inx.py:159: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
inkex/tester/inx.py:52: in assertInxIsGood
    self.assertParams(inx, cls)
inkex/tester/inx.py:60: in assertParams
    args = dict(self.introspect_arg_parser(cls().arg_parser))
inkex/base.py:475: in __init__
    super().__init__()
inkex/base.py:91: in __init__
    self.add_arguments(self.arg_parser)
pixelsnap.py:130: in add_arguments
    pars.add_argument(
/usr/lib64/python3.14/argparse.py:1479: in add_argument
    self._check_help(action)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = ArgumentParser(prog='pytest', usage=None, description='Snap objects to pixels', formatter_class=<class 'argparse.HelpFormatter'>, conflict_handler='error', add_help=True)
action = _StoreAction(option_strings=['-g', '--max_gradient'], dest='max_gradient', nargs=None, const=None, default=0.5, type=<... 'float'>, choices=None, required=False, help='Maximum slope to consider straight (%)', metavar=None, deprecated=False)

    def _check_help(self, action):
        if action.help and hasattr(self, "_get_formatter"):
            formatter = self._get_formatter()
            try:
                formatter._expand_help(action)
            except (ValueError, TypeError, KeyError) as exc:
>               raise ValueError('badly formed help string') from exc
E               ValueError: badly formed help string

/usr/lib64/python3.14/argparse.py:1667: ValueError
=========================== short test summary info ============================
FAILED tests/test_inkex_inx.py::InxTestCase::test_inx_files - ValueError: bad...
====== 1 failed, 571 passed, 9 skipped, 33 deselected, 2 xfailed in 4.26s ======

https://docs.python.org/3.14/whatsnew/3.14.html

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.14/fedora-rawhide-x86_64/08330250-python-inkex/

For all our attempts to build python-inkex with Python 3.14, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14/package/python-inkex/

Testing and mass rebuild of packages is happening in copr.
You can follow these instructions to test locally in mock if your package builds with Python 3.14:
https://copr.fedorainfracloud.org/coprs/g/python/python3.14/

Let us know here if you have any questions.

Python 3.14 is planned to be included in Fedora 43.
To make that update smoother, we're building Fedora packages with all pre-releases of Python 3.14.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires),
so if this package is required a lot, it's important for us to get it fixed soon.

We'd appreciate help from the people who know this package best,
but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Miro Hrončok 2025-01-06 14:25:09 UTC
https://gitlab.com/inkscape/extensions/-/merge_requests/668 fixes this


Note You need to log in before you can comment on or make changes to this bug.