Bug 233152 - ip=dhcp seems to be inverted
ip=dhcp seems to be inverted
Status: CLOSED RAWHIDE
Product: Fedora
Classification: Fedora
Component: anaconda (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: David Cantrell
:
Depends On:
Blocks: FC7Blocker 235441
  Show dependency treegraph
 
Reported: 2007-03-20 14:00 EDT by Will Woods
Modified: 2008-05-23 13:27 EDT (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2007-03-21 17:08:13 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:


Attachments (Terms of Use)

  None (edit)
Description Will Woods 2007-03-20 14:00:58 EDT
If I boot rawhide with 'ip=dhcp ks=[url]' on the commandline, my system does not
attempt dhcp, and fails to retrieve the kickstart.

If I boot without 'ip=dhcp', the system *does* perform a DHCP request, gets an
address, and happily continues.

This is with anaconda-11.2.0.38, from today's rawhide.
Comment 1 David Cantrell 2007-03-21 17:08:13 EDT
Figured it out.  Here's the patch:

RCS file: /usr/local/CVS/anaconda/loader2/loader.c,v
retrieving revision 1.233
diff -u -p -r1.233 loader.c
--- loader.c    14 Mar 2007 20:24:47 -0000      1.233
+++ loader.c    21 Mar 2007 21:04:08 -0000
@@ -514,7 +514,7 @@ static void parseCmdLineIp(struct loader
     start = argv + 3;
     end = strstr(start, ":");
     loaderData->ip = strndup(start, end-start);
-    loaderData->ipinfo_set = 1;
+    loaderData->ipinfo_set = 0;
 
     /* Boot server */
     if (end + 1 == '\0')
@@ -542,7 +542,7 @@ static void parseCmdLineIp(struct loader
     loaderData->netmask = strdup(start);
   } else {
     loaderData->ip = strdup(argv + 3);
-    loaderData->ipinfo_set = 1;
+    loaderData->ipinfo_set = 0;
   }
 }

I love loader.  Fixed in anaconda CVS, closing as rawhide.  Will appear in the
next anaconda build.  You know the drill.
Comment 2 Christoph Dworzak 2008-05-23 13:27:32 EDT
I think this patch caused BUG #392021.

It makes no sense to clear ipinfo_set right after we set the ip.

This problem here is the probably somewhere else...

Note You need to log in before you can comment on or make changes to this bug.