Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-x86_64/08394788-hypershell/hypershell.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-x86_64/08394788-hypershell/hypershell-2.6.0-1.fc42.src.rpm Description: HyperShell is an elegant, cross-platform, high-throughput computing utility for processing shell commands over a distributed, asynchronous queue. It is a highly scalable workflow automation tool for many-task scenarios. Fedora Account System Username: jonathanspw
Copr build: https://copr.fedorainfracloud.org/coprs/build/8394789 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332450-hypershell/fedora-rawhide-x86_64/08394789-hypershell/fedora-review/review.txt Found issues: - python3-toml is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ - License file LICENSE is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-aarch64/08400453-hypershell/hypershell-2.6.0-1.fc42.src.rpm Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-aarch64/08400453-hypershell/hypershell.spec This fixes the LICENSE file and also includes the man pages in the final package. > python3-toml is deprecated, you must not depend on it. Upstream is already working on removing this. It's been removed from the dependency stack (python-cmdkit) but not here yet. Upstream is moving to a different-named GH repo and waiting until that is done to publish the next release which should deal with it in hypershell too. This should not hold up the review.
Created attachment 2062722 [details] The .spec file difference from Copr build 8394789 to 8400636
Copr build: https://copr.fedorainfracloud.org/coprs/build/8400636 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332450-hypershell/fedora-rawhide-x86_64/08400636-hypershell/fedora-review/review.txt Found issues: - python3-toml is deprecated, you must not depend on it. Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/ Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
toml dependency seems to be worked on upstream: https://github.com/glentner/hypershell/issues/33 Waiting for new package.
Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-x86_64/08468290-hypershell/hypershell.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-x86_64/08468290-hypershell/hypershell-2.6.2-1.fc42.src.rpm
Created attachment 2064589 [details] The .spec file difference from Copr build 8400636 to 8468446
Copr build: https://copr.fedorainfracloud.org/coprs/build/8468446 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332450-hypershell/fedora-rawhide-x86_64/08468446-hypershell/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Fixes rpmlint issues. Spec URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-x86_64/08468556-hypershell/hypershell.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/jonathanspw/hypershell/fedora-rawhide-x86_64/08468556-hypershell/hypershell-2.6.2-1.fc42.src.rpm
Created attachment 2064590 [details] The .spec file difference from Copr build 8468446 to 8468569
Copr build: https://copr.fedorainfracloud.org/coprs/build/8468569 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2332450-hypershell/fedora-rawhide-x86_64/08468569-hypershell/fedora-review/review.txt Please take a look if any issues were found. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* Apache License 2.0", "*No copyright* Apache License", "Apache License 2.0". 115 files have unknown license. Detailed output of licensecheck in /FedoraPackaging/reviews/hypershell/2332450-hypershell/licensecheck.txt [x]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib/python3.13, /usr/lib/python3.13/site-packages [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [ ]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 3249 bytes in 1 files. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [-]: Python eggs must not download any dependencies during the build process. [-]: A package which is used by another package via an egg interface should provide egg info. [ ]: Package meets the Packaging Guidelines::Python [x]: Package contains BR: python2-devel or python3-devel [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [!]: Sources can be downloaded from URI in Source: tag Note: Could not download Source0: https://github.com/glentner/hypershell/archive/v2.6.2/hypershell-2.6.2.tar.gz See: https://docs.fedoraproject.org/en-US/packaging- guidelines/SourceURL/ [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [!]: Patches link to upstream bugs/comments/lists or are otherwise justified. [x]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Package should compile and build into binary rpms on all supported architectures. [!]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: hypershell-2.6.2-1.fc42.noarch.rpm hypershell-2.6.2-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmp4xnjmwd2')] checks: 32, packages: 2 hypershell.noarch: W: files-duplicate /usr/bin/hyper-shell /usr/bin/hs 2 packages and 0 specfiles checked; 0 errors, 1 warnings, 15 filtered, 0 badness; has taken 1.4 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 1 hypershell.noarch: W: files-duplicate /usr/bin/hyper-shell /usr/bin/hs 1 packages and 0 specfiles checked; 0 errors, 1 warnings, 10 filtered, 0 badness; has taken 0.7 s Requires -------- hypershell (rpmlib, GLIBC filtered): (python3.13dist(cmdkit) < 3~~ with python3.13dist(cmdkit) >= 2.7.7) (python3.13dist(cmdkit[toml]) < 3~~ with python3.13dist(cmdkit[toml]) >= 2.7.7) (python3.13dist(paramiko) < 4~~ with python3.13dist(paramiko) >= 2.12) (python3.13dist(pyyaml) < 7~~ with python3.13dist(pyyaml) >= 5.4) (python3.13dist(rich) < 15~~ with python3.13dist(rich) >= 13.1) (python3.13dist(sqlalchemy) < 3~~ with python3.13dist(sqlalchemy) >= 1.4) (python3.13dist(tomlkit) < 1~~ with python3.13dist(tomlkit) >= 0.11) /usr/bin/python3 python(abi) Provides -------- hypershell: hypershell python3.13dist(hypershell) python3dist(hypershell) Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2332450 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Python Disabled plugins: Ocaml, Java, PHP, SugarActivity, Perl, C/C++, Haskell, R, fonts Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH Comments: a) Please check package imports change ##check to %check %pyproject_check_import This is required if tests are not run. b) Tests seem ok on Rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=127539255 Consider enabling them at least on Fedora c) The relaxed version requirements may cause functionality to break in EPEL. Have not checked all the code, but may want to get the version loosening patch merged upstream. This does not block the current review.
There is also a conflict with the heatseeker package https://src.fedoraproject.org/rpms/rust-heatseeker/blob/rawhide/f/rust-heatseeker.spec which provides /usr/bin/hs