Bug 2333029 - Review Request: screengrab - Crossplatform tool for fast making screenshots
Summary: Review Request: screengrab - Crossplatform tool for fast making screenshots
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL: https://lxqt-project.org/
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2024-12-18 15:14 UTC by Steve Cossette
Modified: 2025-03-24 01:29 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-24 01:29:25 UTC
Type: ---
Embargoed:
ngompa13: fedora-review+


Attachments (Terms of Use)
The .spec file difference from Copr build 8411140 to 8411149 (359 bytes, patch)
2024-12-18 15:23 UTC, Fedora Review Service
no flags Details | Diff

Description Steve Cossette 2024-12-18 15:14:28 UTC
Spec URL: https://farchord.fedorapeople.org/reviews/screengrab/screengrab.spec
SRPM URL: https://farchord.fedorapeople.org/reviews/screengrab/screengrab-2.9.0-1.fc41.src.rpm

Description:
An application for creating screenshots. ScreenGrab uses
the Qt framework and thus, it is independent from any
desktop environment.

Fedora Account System Username: farchord
(NOTE: This is a package unretirement request)

Comment 1 Neal Gompa 2024-12-18 15:19:16 UTC
Taking this review.

Comment 3 Fedora Review Service 2024-12-18 15:21:25 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8411140
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333029-screengrab/fedora-rawhide-x86_64/08411140-screengrab/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/screengrab
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 4 Fedora Review Service 2024-12-18 15:23:39 UTC
Created attachment 2063002 [details]
The .spec file difference from Copr build 8411140 to 8411149

Comment 5 Fedora Review Service 2024-12-18 15:23:41 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8411149
(failed)

Build log:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333029-screengrab/fedora-rawhide-x86_64/08411149-screengrab/builder-live.log.gz

Please make sure the package builds successfully at least for Fedora Rawhide.

- If the build failed for unrelated reasons (e.g. temporary network
  unavailability), please ignore it.
- If the build failed because of missing BuildRequires, please make sure they
  are listed in the "Depends On" field


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 6 Neal Gompa 2025-01-19 17:38:21 UTC
> BuildRequires:  perl

Can this just be "perl-interpreter"?

Comment 8 Fedora Review Service 2025-02-24 21:37:04 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8695808
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333029-screengrab/fedora-rawhide-x86_64/08695808-screengrab/fedora-review/review.txt

Found issues:

- A package with this name already exists. Please check https://src.fedoraproject.org/rpms/screengrab
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 9 Neal Gompa 2025-03-20 23:52:31 UTC
Review notes:

* Package follows Fedora packaging guidelines
* Package builds and installs
* Package licensing is correct and license file is installed
* No serious issues from rpmlint

PACKAGE APPROVED.

Comment 10 Steve Cossette 2025-03-24 01:29:25 UTC
Unretired, and built in rawhide.


Note You need to log in before you can comment on or make changes to this bug.