Spec URL: https://mattia.fedorapeople.org/java-websocket/Java-WebSocket.spec SRPM URL: https://mattia.fedorapeople.org/java-websocket/Java-WebSocket-1.6.0-1.fc42.src.rpm Description: A barebones WebSocket server and client implementation written in 100% Java. The underlying classes are implemented java.nio, which allows for a non-blocking event-driven model (similar to the WebSocket API for web browsers). Fedora Account System Username: mattia This is an unretirement request to allow unbundling the package from LibreOffice sources. Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=126988568
Copr build: https://copr.fedorainfracloud.org/coprs/build/8412263 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333051-java-websocket/fedora-rawhide-x86_64/08412263-Java-WebSocket/fedora-review/review.txt Found issues: - License file ADDITIONAL_LICENSE_INFO is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/Java-WebSocket Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file ADDITIONAL_LICENSE_INFO is not marked as %license See: https://docs.fedoraproject.org/en-US/packaging- guidelines/LicensingGuidelines/#_license_text Add License breakdown Include pom.xml ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "MIT License". 47 files have unknown license. Detailed output of licensecheck in /home/gwyn/2333051-Java- WebSocket/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [x]: Macros in Summary, %description expandable at SRPM build time. Note: Macros in: Java-WebSocket (summary), Java-WebSocket (description) [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 38826 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: The License field must be a valid SPDX expression. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Java: [x]: Bundled jar/class files should be removed before build [x]: Packages have proper BuildRequires/Requires on javapackages-tools (jpackage-utils) Note: Maven packages do not need to (Build)Require jpackage-utils. It is pulled in by maven-local [x]: Javadoc documentation files are generated and included in -javadoc subpackage [x]: Javadoc subpackages should not have Requires: javapackages-tools (jpackage-utils) [x]: Javadocs are placed in %{_javadocdir}/%{name} (no -%{version} symlink) Maven: [-]: If package contains pom.xml files install it (including metadata) even when building with ant [x]: POM files have correct Maven mapping [x]: Maven packages should use new style packaging [x]: Old add_to_maven_depmap macro is not being used [x]: Packages DO NOT have Requires(post) and Requires(postun) on jpackage- utils for %update_maven_depmap macro [x]: Package DOES NOT use %update_maven_depmap in %post/%postun [x]: Packages use .mfiles file list instead of %{_datadir}/maven2/poms ===== SHOULD items ===== Generic: [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. Java: [x]: Package uses upstream build method (ant/maven/etc.) [x]: Packages are noarch unless they use JNI ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: Java-WebSocket-1.6.0-1.fc42.noarch.rpm Java-WebSocket-javadoc-1.6.0-1.fc42.noarch.rpm Java-WebSocket-1.6.0-1.fc42.src.rpm ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-legacy-licenses.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml rpmlintrc: [PosixPath('/tmp/tmptsqpm2zc')] checks: 32, packages: 3 Java-WebSocket.noarch: E: spelling-error ('barebones', 'Summary(en_US) barebones -> bare bones, bare-bones, baronesses') Java-WebSocket.noarch: E: spelling-error ('barebones', '%description -l en_US barebones -> bare bones, bare-bones, baronesses') Java-WebSocket.noarch: E: spelling-error ('nio', '%description -l en_US nio -> bio, nip, no') Java-WebSocket.src: E: spelling-error ('barebones', 'Summary(en_US) barebones -> bare bones, bare-bones, baronesses') Java-WebSocket.src: E: spelling-error ('barebones', '%description -l en_US barebones -> bare bones, bare-bones, baronesses') Java-WebSocket.src: E: spelling-error ('nio', '%description -l en_US nio -> bio, nip, no') Java-WebSocket-javadoc.noarch: W: package-with-huge-docs 99% 3 packages and 0 specfiles checked; 6 errors, 1 warnings, 11 filtered, 6 badness; has taken 0.9 s Rpmlint (installed packages) ---------------------------- ============================ rpmlint session starts ============================ rpmlint: 2.5.0 configuration: /usr/lib/python3.13/site-packages/rpmlint/configdefaults.toml /etc/xdg/rpmlint/fedora-spdx-licenses.toml /etc/xdg/rpmlint/fedora.toml /etc/xdg/rpmlint/scoring.toml /etc/xdg/rpmlint/users-groups.toml /etc/xdg/rpmlint/warn-on-functions.toml checks: 32, packages: 2 Java-WebSocket.noarch: E: spelling-error ('barebones', 'Summary(en_US) barebones -> bare bones, bare-bones, baronesses') Java-WebSocket.noarch: E: spelling-error ('barebones', '%description -l en_US barebones -> bare bones, bare-bones, baronesses') Java-WebSocket.noarch: E: spelling-error ('nio', '%description -l en_US nio -> bio, nip, no') Java-WebSocket-javadoc.noarch: W: package-with-huge-docs 99% 2 packages and 0 specfiles checked; 3 errors, 1 warnings, 7 filtered, 3 badness; has taken 0.4 s Source checksums ---------------- https://github.com/TooTallNate/Java-WebSocket/archive/v1.6.0/Java-WebSocket-1.6.0.tar.gz : CHECKSUM(SHA256) this package : f3ce29efde338707241d47ab4784b19a1e3658bfa0564b5bc5f80c27e5118728 CHECKSUM(SHA256) upstream package : f3ce29efde338707241d47ab4784b19a1e3658bfa0564b5bc5f80c27e5118728 Requires -------- Java-WebSocket (rpmlib, GLIBC filtered): java-headless javapackages-filesystem mvn(org.slf4j:slf4j-api) Java-WebSocket-javadoc (rpmlib, GLIBC filtered): javapackages-filesystem Provides -------- Java-WebSocket: Java-WebSocket bundled(net.iharder:base64) jpms(org.java_websocket) mvn(org.java-websocket:Java-WebSocket) mvn(org.java-websocket:Java-WebSocket:pom:) Java-WebSocket-javadoc: Java-WebSocket-javadoc Generated by fedora-review 0.10.0 (e79b66b) last change: 2023-07-24 Command line :/usr/bin/fedora-review -b 2333051 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, Java Disabled plugins: SugarActivity, C/C++, PHP, R, Perl, Haskell, fonts, Ruby, Python, Ocaml Disabled flags: EXARCH, EPEL6, EPEL7, DISTTAG, BATCH
Spec URL: https://mattia.fedorapeople.org/java-websocket/Java-WebSocket.spec SRPM URL: https://mattia.fedorapeople.org/java-websocket/Java-WebSocket-1.6.0-2.fc42.src.rpm The 'ADDITIONAL_LICENSE_INFO' file is autogenerated and injected by java docs macro, as well as other license exceptions files regarding assembler code and jquery. I've checked some other java packages in Fedora and it seems no one is marking them as actual licenses... About the pom.xml file, docs says it should be automatically installed by %mvn_install. I see that macro is installing it as Java-WebSocket.pom. The packaging guidelines aren't very clear, but I assume it's the way it should be?
Created attachment 2063671 [details] The .spec file difference from Copr build 8412263 to 8442253
Copr build: https://copr.fedorainfracloud.org/coprs/build/8442253 (succeeded) Review template: https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333051-java-websocket/fedora-rawhide-x86_64/08442253-Java-WebSocket/fedora-review/review.txt Found issues: - License file ADDITIONAL_LICENSE_INFO is not marked as %license Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_license_text - A package with this name already exists. Please check https://src.fedoraproject.org/rpms/Java-WebSocket Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/Naming/#_conflicting_package_names Please know that there can be false-positives. --- This comment was created by the fedora-review-service https://github.com/FrostyX/fedora-review-service If you want to trigger a new Copr build, add a comment containing new Spec and SRPM URLs or [fedora-review-service-build] string.
Seems good to me. APPROVED.
Package unretired and built, thanks.