Bug 2333266 - Review Request: python-toml-cli - Read and write keys/values to/from toml files
Summary: Review Request: python-toml-cli - Read and write keys/values to/from toml files
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/mrijken/toml-cli
Whiteboard:
Depends On:
Blocks: 2337407 2333267
TreeView+ depends on / blocked
 
Reported: 2024-12-19 07:55 UTC by Davide Cavalca
Modified: 2025-03-05 02:53 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2025-03-05 02:53:52 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-12-19 07:55:37 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/python-toml-cli/python-toml-cli.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-toml-cli/python-toml-cli-0.7.0-1.fc42.src.rpm

Description:
Command line interface for toml files.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-12-19 07:55:40 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=127008268

Comment 2 Fedora Review Service 2024-12-20 00:40:06 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8422620
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333266-python-toml-cli/fedora-rawhide-x86_64/08422620-python-toml-cli/fedora-review/review.txt

Found issues:

- python3-pytest7 is deprecated, you must not depend on it.
  Read more: https://docs.fedoraproject.org/en-US/packaging-guidelines/deprecating-packages/

Please know that there can be false-positives.

---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2025-03-05 02:40:49 UTC
Package was generated with pyp2spec, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the software is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with the Python Packaging Guidelines

Package APPROVED.

===

Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:

- add @python-packagers-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches

Comment 4 Fedora Admin user for bugzilla script actions 2025-03-05 02:42:01 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-toml-cli

Comment 5 Fedora Update System 2025-03-05 02:49:50 UTC
FEDORA-2025-71654c954d (python-toml-cli-0.7.0-1.fc43) has been submitted as an update to Fedora 43.
https://bodhi.fedoraproject.org/updates/FEDORA-2025-71654c954d

Comment 6 Fedora Update System 2025-03-05 02:53:52 UTC
FEDORA-2025-71654c954d (python-toml-cli-0.7.0-1.fc43) has been pushed to the Fedora 43 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.