Bug 2333292 - Review Request: python-mkdocs-macros-test - Test macros library for the MkDocs macros plugin
Summary: Review Request: python-mkdocs-macros-test - Test macros library for the MkDoc...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Michel Lind
QA Contact: Fedora Extras Quality Assurance
URL: https://github.com/fralau/mkdocs-macr...
Whiteboard:
Depends On:
Blocks: 2333293
TreeView+ depends on / blocked
 
Reported: 2024-12-19 09:36 UTC by Davide Cavalca
Modified: 2024-12-29 22:19 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2024-12-29 22:19:50 UTC
Type: ---
Embargoed:
michel: fedora-review+


Attachments (Terms of Use)

Description Davide Cavalca 2024-12-19 09:36:16 UTC
Spec URL: https://dcavalca.fedorapeople.org/review/python-mkdocs-macros-test/python-mkdocs-macros-test.spec
SRPM URL: https://dcavalca.fedorapeople.org/review/python-mkdocs-macros-test/python-mkdocs-macros-test-0.1.0-1.fc42.src.rpm

Description:
This is a test pluglet for mkdocs-macros. Its purpose is to serve as a template
for pluglets.

Fedora Account System Username: dcavalca

Comment 1 Davide Cavalca 2024-12-19 09:36:19 UTC
This package built on koji:  https://koji.fedoraproject.org/koji/taskinfo?taskID=127010305

Comment 2 Fedora Review Service 2024-12-20 00:34:21 UTC
Copr build:
https://copr.fedorainfracloud.org/coprs/build/8422571
(succeeded)

Review template:
https://download.copr.fedorainfracloud.org/results/@fedora-review/fedora-review-2333292-python-mkdocs-macros-test/fedora-rawhide-x86_64/08422571-python-mkdocs-macros-test/fedora-review/review.txt

Please take a look if any issues were found.


---
This comment was created by the fedora-review-service
https://github.com/FrostyX/fedora-review-service

If you want to trigger a new Copr build, add a comment containing new
Spec and SRPM URLs or [fedora-review-service-build] string.

Comment 3 Michel Lind 2024-12-27 21:22:19 UTC
So technically this is actually a post-release snapshot, so you might want to follow https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_snapshots

But then again the change is mostly cosmetic and documentation (it's basically the second commit in the repo, so checking is easy) so I'll leave that as an option what you want to do -- also upstream has not touched this in... over 4 years.

Comment 4 Michel Lind 2024-12-27 21:22:53 UTC
Ah, my mistake, you're only using the commit to grab the missing files

Comment 5 Michel Lind 2024-12-27 21:24:19 UTC
Package was generated with pyp2spec, simplifying the review.

- package builds and installs without errors on rawhide
- test suite is run and all unit tests pass
- latest version of the sotware is packaged
- license matches upstream specification (MIT) and is acceptable for Fedora
- license file is included with %license in %files
- package complies with the Python Packaging Guidelines

Package APPROVED.

===

Recommended post-import python-packagers-sig tasks (use `fedora-sig-onboard onboard pkgname`:

- add @python-packagers-sig with "commit" access as package co-maintainer

- track package in koschei for all built branches

Comment 6 Fedora Admin user for bugzilla script actions 2024-12-29 22:05:40 UTC
The Pagure repository was created at https://src.fedoraproject.org/rpms/python-mkdocs-macros-test

Comment 7 Fedora Update System 2024-12-29 22:15:27 UTC
FEDORA-2024-57a2063743 (python-mkdocs-macros-test-0.1.0-1.fc42) has been submitted as an update to Fedora 42.
https://bodhi.fedoraproject.org/updates/FEDORA-2024-57a2063743

Comment 8 Fedora Update System 2024-12-29 22:19:50 UTC
FEDORA-2024-57a2063743 (python-mkdocs-macros-test-0.1.0-1.fc42) has been pushed to the Fedora 42 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.