Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/goocanvas.spec SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/goocanvas-0.6-1.fc6.src.rpm Description: GooCanvas is a new canvas widget for GTK+ that uses the cairo 2D library for drawing. It has a model/view split, and uses interfaces for canvas items and views, so you can easily turn any application object into canvas items.
rpmlint clean with one exception: [limb@fawkes SPECS]$ rpmlint -i ../RPMS/i386/goocanvas-devel-0.6-1.i386.rpm W: goocanvas-devel no-documentation The package contains no documentation (README, doc, etc). You have to include documentation files.
Meets Package Naming Guidelines. Spec name is good. License OK, OK in spec and included. Spec in American English and legible. Source MD5 matches upstream Is there a reason you're not packaging 0.8? Compiles and builds on FC6/i386.
Builds in mock, BuildRequires are OK. Locales handled properly. Runs ldconfig properly. Not relocatable. Directory handling is correct. No duplicate files. Permissions are correct, defattr line in place. Clean section correct and in place. Macros are consistent. Code, not content. No large docs. Headers are in -devel. pkgconfig Required, correctly. .so is in -devel. Correctly versioned -devel Requires for main package. All .la removed. Not a desktop application. No conflicting ownership. Install starts by clearing buildroot. All UTF-8 filenames. Except for -devel doc issue and possible version update, all MUSTS met.
No weird scriptlets or file Requires.
(In reply to comment #1) > W: goocanvas-devel no-documentation > The package contains no documentation (README, doc, etc). > You have to include documentation files. There is no documentation relevent to the -devel package. (In reply to comment #2) > Is there a reason you're not packaging 0.8? Actually, yes, and I should have stated it when I submitted. This package set (goocanvas and pygoocanvas) were submitted as requirements for the Conduit (http://www.conduit-project.org/) package I was going to submit. Current release of conduit require goocanvas/pygoocanvas 0.6. There is a new release of Conduit that will be out this week that should run on 0.7 or 0.8, but I haven't had a chance to compile it yet.
Those explanations are both eminently reasonable. APPROVED.
New Package CVS Request ======================= Package Name: goocanvas Short Description: A new canvas widget for GTK+ that uses cairo for drawing Owners: bjohnson Branches: FC-5 FC-6 InitialCC: bjohnson
no need to add yourself as the initial cc as the owner you get all bugzilla mail. cvs is done
Thanks for the review.
Package Change Request ====================== Package Name: goocanvas Sorry, FC-5 has some bugs in the BRs that make this package very hard to build. Given the limited life of FC-5 at this time, I will not be supporting it. Please remove FC-5 branch.
Package Change Request ====================== Package Name: goocanvas New Branches: el5 el6 Owners: sparks
Git done (by process-git-requests).
You don't have to change the bug status to get CVS attention. Also, I'm changing this back to NEXTRELEASE which is the proper status - NOTABUG indicates a cancelled review.
Package Change Request ====================== Package Name: goocanvas New Branches: epel7 Owners: sparks