Bug 233340 - Review Request: goocanvas - A new canvas widget for GTK+ that uses cairo for drawing
Review Request: goocanvas - A new canvas widget for GTK+ that uses cairo for ...
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Gwyn Ciesla
Fedora Package Reviews List
: Reopened
Depends On:
Blocks: 233342
  Show dependency treegraph
 
Reported: 2007-03-21 14:29 EDT by Bernard Johnson
Modified: 2014-01-27 15:27 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2012-02-03 11:29:10 EST
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
limburgher: fedora‑review+
limburgher: fedora‑cvs+


Attachments (Terms of Use)

  None (edit)
Description Bernard Johnson 2007-03-21 14:29:20 EDT
Spec URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/goocanvas.spec
SRPM URL: http://www.symetrix.com/~bjohnson/projects/Fedora-Extras/goocanvas-0.6-1.fc6.src.rpm
Description:
GooCanvas is a new canvas widget for GTK+ that uses the cairo 2D library for
drawing. It has a model/view split, and uses interfaces for canvas items and
views, so you can easily turn any application object into canvas items.
Comment 1 Gwyn Ciesla 2007-05-04 08:42:53 EDT
rpmlint clean with one exception:
[limb@fawkes SPECS]$ rpmlint -i ../RPMS/i386/goocanvas-devel-0.6-1.i386.rpm 
W: goocanvas-devel no-documentation
The package contains no documentation (README, doc, etc).
You have to include documentation files.
Comment 2 Gwyn Ciesla 2007-05-04 09:41:27 EDT
Meets Package Naming Guidelines.
Spec name is good.
License OK, OK in spec and included.
Spec in American English and legible.
Source MD5 matches upstream

Is there a reason you're not packaging 0.8?

Compiles and builds on FC6/i386.
Comment 3 Gwyn Ciesla 2007-05-04 10:13:59 EDT
Builds in mock, BuildRequires are OK.
Locales handled properly.
Runs ldconfig properly.
Not relocatable.
Directory handling is correct.
No duplicate files.
Permissions are correct, defattr line in place.
Clean section correct and in place.
Macros are consistent.
Code, not content.
No large docs.
Headers are in -devel.
pkgconfig Required, correctly.
.so is in -devel.
Correctly versioned -devel Requires for main package.
All .la removed.
Not a desktop application.
No conflicting ownership.
Install starts by clearing buildroot.
All UTF-8 filenames.

Except for -devel doc issue and possible version update, all MUSTS met.
Comment 4 Gwyn Ciesla 2007-05-04 10:15:49 EDT
No weird scriptlets or file Requires.
Comment 5 Bernard Johnson 2007-05-04 11:40:23 EDT
(In reply to comment #1)
> W: goocanvas-devel no-documentation
> The package contains no documentation (README, doc, etc).
> You have to include documentation files.

There is no documentation relevent to the -devel package.



(In reply to comment #2)
> Is there a reason you're not packaging 0.8?

Actually, yes, and I should have stated it when I submitted.  This package set
(goocanvas and pygoocanvas) were submitted as requirements for the Conduit
(http://www.conduit-project.org/) package I was going to submit.  Current
release of conduit require goocanvas/pygoocanvas 0.6.  There is a new release of
Conduit that will be out this week that should run on 0.7 or 0.8, but I haven't
had a chance to compile it yet.
Comment 6 Gwyn Ciesla 2007-05-04 11:48:47 EDT
Those explanations are both eminently reasonable.
APPROVED.
Comment 7 Bernard Johnson 2007-05-04 12:22:26 EDT
New Package CVS Request
=======================
Package Name: goocanvas
Short Description: A new canvas widget for GTK+ that uses cairo for drawing
Owners: bjohnson@symetrix.com
Branches: FC-5 FC-6
InitialCC: bjohnson@symetrix.com
Comment 8 Dennis Gilmore 2007-05-05 11:50:28 EDT
no need to add yourself as the initial cc  as the owner you get all bugzilla 
mail.  cvs is done
Comment 9 Bernard Johnson 2007-05-06 15:27:32 EDT
Thanks for the review.
Comment 10 Bernard Johnson 2007-05-07 14:33:04 EDT
Package Change Request
======================
Package Name: goocanvas

Sorry, FC-5 has some bugs in the BRs that make this package very hard to build.
Given the limited life of FC-5 at this time, I will not be supporting it.

Please remove FC-5 branch.
Comment 11 eric@christensenplace.us 2012-02-02 17:43:18 EST
Package Change Request
======================
Package Name: goocanvas
New Branches: el5 el6
Owners: sparks
Comment 12 Gwyn Ciesla 2012-02-03 07:55:24 EST
Git done (by process-git-requests).
Comment 13 Bernard Johnson 2012-02-03 12:17:59 EST
You don't have to change the bug status to get CVS attention.  Also, I'm changing this back to NEXTRELEASE which is the proper status - NOTABUG indicates a cancelled review.
Comment 14 Eric Christensen 2014-01-27 15:18:10 EST
Package Change Request
======================
Package Name: goocanvas
New Branches: epel7
Owners: sparks
Comment 15 Gwyn Ciesla 2014-01-27 15:27:25 EST
Git done (by process-git-requests).

Note You need to log in before you can comment on or make changes to this bug.